* [dm-devel] [PATCH] dm-writecache: crash on invalid returned status
@ 2021-07-27 13:45 Mikulas Patocka
0 siblings, 0 replies; only message in thread
From: Mikulas Patocka @ 2021-07-27 13:45 UTC (permalink / raw)
To: Mike Snitzer; +Cc: dm-devel
If some "writecache_map_*" function returns invalid status, it is a bug.
So, we should report it and not fail silently.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
---
drivers/md/dm-writecache.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: linux-2.6/drivers/md/dm-writecache.c
===================================================================
--- linux-2.6.orig/drivers/md/dm-writecache.c 2021-07-27 15:29:19.000000000 +0200
+++ linux-2.6/drivers/md/dm-writecache.c 2021-07-27 15:37:30.000000000 +0200
@@ -1585,10 +1585,13 @@ done:
return DM_MAPIO_SUBMITTED;
case WC_MAP_ERROR:
- default:
wc_unlock(wc);
bio_io_error(bio);
return DM_MAPIO_SUBMITTED;
+
+ default:
+ BUG();
+ return -1;
}
}
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-27 13:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27 13:45 [dm-devel] [PATCH] dm-writecache: crash on invalid returned status Mikulas Patocka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.