From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933442AbdGLH7m (ORCPT ); Wed, 12 Jul 2017 03:59:42 -0400 Received: from namei.org ([65.99.196.166]:41920 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933181AbdGLH7l (ORCPT ); Wed, 12 Jul 2017 03:59:41 -0400 Date: Wed, 12 Jul 2017 17:59:31 +1000 (AEST) From: James Morris To: Stefan Berger <"Stefan Bergerstefanb"@linux.vnet.ibm.com> cc: ebiederm@xmission.com, containers@lists.linux-foundation.org, lkp@01.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, linux-security-module@vger.kernel.org, casey@schaufler-ca.com, zohar@linux.vnet.ibm.com Subject: Re: [PATCH v2] xattr: Enable security.capability in user namespaces In-Reply-To: <1499785511-17192-2-git-send-email-stefanb@linux.vnet.ibm.com> Message-ID: References: <1499785511-17192-1-git-send-email-stefanb@linux.vnet.ibm.com> <1499785511-17192-2-git-send-email-stefanb@linux.vnet.ibm.com> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Jul 2017, Stefan Berger wrote: > + buflen = sizeof("@uid=") - 1 + sizeof("4294967295") - 1 + 1; Why not strlen() here? -- James Morris From mboxrd@z Thu Jan 1 00:00:00 1970 From: jmorris@namei.org (James Morris) Date: Wed, 12 Jul 2017 17:59:31 +1000 (AEST) Subject: [PATCH v2] xattr: Enable security.capability in user namespaces In-Reply-To: <1499785511-17192-2-git-send-email-stefanb@linux.vnet.ibm.com> References: <1499785511-17192-1-git-send-email-stefanb@linux.vnet.ibm.com> <1499785511-17192-2-git-send-email-stefanb@linux.vnet.ibm.com> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Tue, 11 Jul 2017, Stefan Berger wrote: > + buflen = sizeof("@uid=") - 1 + sizeof("4294967295") - 1 + 1; Why not strlen() here? -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2629492976388720670==" MIME-Version: 1.0 From: James Morris To: lkp@lists.01.org Subject: Re: [PATCH v2] xattr: Enable security.capability in user namespaces Date: Wed, 12 Jul 2017 17:59:31 +1000 Message-ID: In-Reply-To: <1499785511-17192-2-git-send-email-stefanb@linux.vnet.ibm.com> List-Id: --===============2629492976388720670== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, 11 Jul 2017, Stefan Berger wrote: > + buflen =3D sizeof("@uid=3D") - 1 + sizeof("4294967295") - 1 + 1; Why not strlen() here? -- = James Morris --===============2629492976388720670==--