From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from namei.org ([65.99.196.166]:47529 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbdHQCmd (ORCPT ); Wed, 16 Aug 2017 22:42:33 -0400 Date: Thu, 17 Aug 2017 12:42:16 +1000 (AEST) From: James Morris To: Mimi Zohar cc: Christoph Hellwig , Al Viro , Matthew Garrett , linux-fsdevel@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, Matthew Garrett Subject: Re: [PATCH v6 1/6] libfs: define simple_read_iter_from_buffer In-Reply-To: <1502905386.21278.2.camel@linux.vnet.ibm.com> Message-ID: References: <1502808237-2035-1-git-send-email-zohar@linux.vnet.ibm.com> <1502808237-2035-2-git-send-email-zohar@linux.vnet.ibm.com> <20170816063508.GA16683@lst.de> <1502905386.21278.2.camel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="1665246916-128642776-1502937736=:10905" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1665246916-128642776-1502937736=:10905 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 16 Aug 2017, Mimi Zohar wrote: > On Wed, 2017-08-16 at 08:35 +0200, Christoph Hellwig wrote: > > Looks good, > > > > Reviewed-by: Christoph Hellwig > > Thank you for the reviewed-by's. > > Up to now I haven't been removing the Changelog before sending James a > pull request.  Adding the dashes in the commit itself, only changes > how the patches are applied by others to their local branch, not to > what would be upstreamed.  Am I suppose to be removing the changelog > before sending a pull request? I don't really understand this, but leave the changelog in? -- James Morris --1665246916-128642776-1502937736=:10905-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: jmorris@namei.org (James Morris) Date: Thu, 17 Aug 2017 12:42:16 +1000 (AEST) Subject: [PATCH v6 1/6] libfs: define simple_read_iter_from_buffer In-Reply-To: <1502905386.21278.2.camel@linux.vnet.ibm.com> References: <1502808237-2035-1-git-send-email-zohar@linux.vnet.ibm.com> <1502808237-2035-2-git-send-email-zohar@linux.vnet.ibm.com> <20170816063508.GA16683@lst.de> <1502905386.21278.2.camel@linux.vnet.ibm.com> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Wed, 16 Aug 2017, Mimi Zohar wrote: > On Wed, 2017-08-16 at 08:35 +0200, Christoph Hellwig wrote: > > Looks good, > > > > Reviewed-by: Christoph Hellwig > > Thank you for the reviewed-by's. > > Up to now I haven't been removing the Changelog before sending James a > pull request.??Adding the dashes in the commit itself, only changes > how the patches are applied by others to their local branch, not to > what would be upstreamed.??Am I suppose to be removing the changelog > before sending a pull request? I don't really understand this, but leave the changelog in? -- James Morris