From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756161AbeDYTCl (ORCPT ); Wed, 25 Apr 2018 15:02:41 -0400 Received: from namei.org ([65.99.196.166]:58270 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbeDYTCi (ORCPT ); Wed, 25 Apr 2018 15:02:38 -0400 Date: Thu, 26 Apr 2018 05:02:27 +1000 (AEST) From: James Morris To: Paul Moore cc: David Herrmann , linux-kernel@vger.kernel.org, teg@jklm.no, Stephen Smalley , selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, Eric Paris , "Serge E. Hallyn" , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH 0/3] Introduce LSM-hook for socketpair(2) In-Reply-To: Message-ID: References: <20180423133015.5455-1-dh.herrmann@gmail.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Apr 2018, Paul Moore wrote: > On Wed, Apr 25, 2018 at 2:44 PM, James Morris wrote: > > On Mon, 23 Apr 2018, David Herrmann wrote: > >> This patch series tries to close this gap and makes both behave the > >> same. A new LSM-hook is added which allows LSMs to cache the correct > >> peer information on newly created socket-pairs. > > > > Looks okay to me. > > > > Once it's respun with the Smack backend and maybe the hook name change, > > I'll merge this unless DaveM wants it to go in via his networking tree. > > Note my objection to the hook placement in patch 2/3; I think we > should move the hook out of the AF_UNIX layer and up into the socket > layer. I vote for this as it maintains the intended abstraction of the socket API. -- James Morris From mboxrd@z Thu Jan 1 00:00:00 1970 From: jmorris@namei.org (James Morris) Date: Thu, 26 Apr 2018 05:02:27 +1000 (AEST) Subject: [PATCH 0/3] Introduce LSM-hook for socketpair(2) In-Reply-To: References: <20180423133015.5455-1-dh.herrmann@gmail.com> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Wed, 25 Apr 2018, Paul Moore wrote: > On Wed, Apr 25, 2018 at 2:44 PM, James Morris wrote: > > On Mon, 23 Apr 2018, David Herrmann wrote: > >> This patch series tries to close this gap and makes both behave the > >> same. A new LSM-hook is added which allows LSMs to cache the correct > >> peer information on newly created socket-pairs. > > > > Looks okay to me. > > > > Once it's respun with the Smack backend and maybe the hook name change, > > I'll merge this unless DaveM wants it to go in via his networking tree. > > Note my objection to the hook placement in patch 2/3; I think we > should move the hook out of the AF_UNIX layer and up into the socket > layer. I vote for this as it maintains the intended abstraction of the socket API. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html