From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D310C64EB8 for ; Wed, 3 Oct 2018 18:17:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E45DF2089F for ; Wed, 3 Oct 2018 18:17:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E45DF2089F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=namei.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727432AbeJDBHU (ORCPT ); Wed, 3 Oct 2018 21:07:20 -0400 Received: from namei.org ([65.99.196.166]:35422 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbeJDBHU (ORCPT ); Wed, 3 Oct 2018 21:07:20 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id w93IHJ2b015270; Wed, 3 Oct 2018 18:17:19 GMT Date: Thu, 4 Oct 2018 04:17:19 +1000 (AEST) From: James Morris To: John Johansen cc: Kees Cook , Jordan Glover , Stephen Smalley , Paul Moore , Casey Schaufler , Tetsuo Handa , "Schaufler, Casey" , linux-security-module , Jonathan Corbet , "open list:DOCUMENTATION" , linux-arch , LKML Subject: Re: [PATCH security-next v4 23/32] selinux: Remove boot parameter In-Reply-To: <5955f5ce-b803-4f58-8b07-54c291e33da5@canonical.com> Message-ID: References: <20181002005505.6112-1-keescook@chromium.org> <20181002005505.6112-24-keescook@chromium.org> <785ef6a9-ae46-3533-0348-74bcf6f10928@tycho.nsa.gov> <809f1cfd-077b-ee58-51ba-b22daf46d12b@tycho.nsa.gov> <5955f5ce-b803-4f58-8b07-54c291e33da5@canonical.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Oct 2018, John Johansen wrote: > To me a list like > lsm.enable=X,Y,Z What about even simpler: lsm=selinux,!apparmor,yama > > is best as a single explicit enable list, and it would be best to avoid > lsm.disable as it just introduces confusion. > > I do think per-LSM bootparams looses the advantages of centralization, > and still requires the user to know some Kconfig info but it also gets > rid of the lsm.disable confusion. > > With ordering separated out from being enabled there is a certain > cleanness to it. And perhaps most users are looking to enable/disable > a single lsm, instead of specifying exactly what security they want > on their system. > > If we were to go this route I would rather drop the lsm. prefix > > > > I think the current proposal (in the other thread) is likely the > > sanest approach: > > > > - Drop CONFIG_SECURITY_SELINUX_BOOTPARAM_VALUE > > - Drop CONFIG_SECURITY_APPARMOR_BOOTPARAM_VALUE > > - All enabled LSMs are listed at build-time in CONFIG_LSM_ENABLE > > Hrrmmm isn't this a Kconfig selectable list, with each built-in LSM > available to be enabled by default at boot. > > > - Boot time enabling for selinux= and apparmor= remain > > - lsm.enable= is explicit: overrides above and omissions are disabled > wfm > > > - maybe include lsm.disable= to disable anything > -- James Morris