From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D065EC43219 for ; Mon, 29 Apr 2019 19:59:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAF1921670 for ; Mon, 29 Apr 2019 19:59:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729287AbfD2T7D (ORCPT ); Mon, 29 Apr 2019 15:59:03 -0400 Received: from namei.org ([65.99.196.166]:36452 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728928AbfD2T7D (ORCPT ); Mon, 29 Apr 2019 15:59:03 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id x3TJwux6025677; Mon, 29 Apr 2019 19:58:57 GMT Date: Tue, 30 Apr 2019 05:58:56 +1000 (AEST) From: James Morris To: Casey Schaufler cc: Tetsuo Handa , linux-security-module@vger.kernel.org Subject: Re: [PATCH 2/3] smack: Check address length before reading address family In-Reply-To: <738815cc-ac59-63c9-1768-26df95689d7a@schaufler-ca.com> Message-ID: References: <1555066776-9758-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> <1555066776-9758-2-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> <738815cc-ac59-63c9-1768-26df95689d7a@schaufler-ca.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Fri, 12 Apr 2019, Casey Schaufler wrote: > On 4/12/2019 3:59 AM, Tetsuo Handa wrote: > > KMSAN will complain if valid address length passed to bind()/connect()/ > > sendmsg() is shorter than sizeof("struct sockaddr"->sa_family) bytes. > > > > Also, since smk_ipv6_port_label()/smack_netlabel_send()/ > > smack_ipv6host_label()/smk_ipv6_check()/smk_ipv6_port_check() are not > > checking valid address length and/or address family, make sure we check > > both. The minimal valid length in smack_socket_connect() is changed from > > sizeof(struct sockaddr_in6) bytes to SIN6_LEN_RFC2133 bytes, for it seems > > that Smack is not using "struct sockaddr_in6"->sin6_scope_id field. > > > > Signed-off-by: Tetsuo Handa > > Acked-by: Casey Schaufler Casey: will you be taking this via your tree? -- James Morris