All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Morris <jmorris@namei.org>
To: Paul Moore <paul@paul-moore.com>
Cc: netdev@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>,
	linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Subject: Re: [PATCH] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist()
Date: Sat, 14 Nov 2020 18:03:56 +1100 (AEDT)	[thread overview]
Message-ID: <alpine.LRH.2.21.2011141803490.23236@namei.org> (raw)
In-Reply-To: <160530304068.15651.18355773009751195447.stgit@sifl>

On Fri, 13 Nov 2020, Paul Moore wrote:

> Static checking revealed that a previous fix to
> netlbl_unlabel_staticlist() leaves a stack variable uninitialized,
> this patches fixes that.
> 
> Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Paul Moore <paul@paul-moore.com>


Reviewed-by: James Morris <jamorris@linux.microsoft.com>

> ---
>  net/netlabel/netlabel_unlabeled.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netlabel_unlabeled.c
> index fc55c9116da0..ccb491642811 100644
> --- a/net/netlabel/netlabel_unlabeled.c
> +++ b/net/netlabel/netlabel_unlabeled.c
> @@ -1167,7 +1167,7 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb,
>  	u32 skip_bkt = cb->args[0];
>  	u32 skip_chain = cb->args[1];
>  	u32 skip_addr4 = cb->args[2];
> -	u32 iter_bkt, iter_chain, iter_addr4 = 0, iter_addr6 = 0;
> +	u32 iter_bkt, iter_chain = 0, iter_addr4 = 0, iter_addr6 = 0;
>  	struct netlbl_unlhsh_iface *iface;
>  	struct list_head *iter_list;
>  	struct netlbl_af4list *addr4;
> 

-- 
James Morris
<jmorris@namei.org>


  reply	other threads:[~2020-11-14  7:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 21:30 Paul Moore
2020-11-14  7:03 ` James Morris [this message]
2020-11-14 20:09   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.21.2011141803490.23236@namei.org \
    --to=jmorris@namei.org \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=selinux@vger.kernel.org \
    --subject='Re: [PATCH] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.