* [PATCH] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist()
@ 2020-11-13 21:30 Paul Moore
2020-11-14 7:03 ` James Morris
0 siblings, 1 reply; 3+ messages in thread
From: Paul Moore @ 2020-11-13 21:30 UTC (permalink / raw)
To: netdev; +Cc: Dan Carpenter, linux-security-module, selinux
Static checking revealed that a previous fix to
netlbl_unlabel_staticlist() leaves a stack variable uninitialized,
this patches fixes that.
Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
---
net/netlabel/netlabel_unlabeled.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netlabel_unlabeled.c
index fc55c9116da0..ccb491642811 100644
--- a/net/netlabel/netlabel_unlabeled.c
+++ b/net/netlabel/netlabel_unlabeled.c
@@ -1167,7 +1167,7 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb,
u32 skip_bkt = cb->args[0];
u32 skip_chain = cb->args[1];
u32 skip_addr4 = cb->args[2];
- u32 iter_bkt, iter_chain, iter_addr4 = 0, iter_addr6 = 0;
+ u32 iter_bkt, iter_chain = 0, iter_addr4 = 0, iter_addr6 = 0;
struct netlbl_unlhsh_iface *iface;
struct list_head *iter_list;
struct netlbl_af4list *addr4;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist()
2020-11-13 21:30 [PATCH] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist() Paul Moore
@ 2020-11-14 7:03 ` James Morris
2020-11-14 20:09 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: James Morris @ 2020-11-14 7:03 UTC (permalink / raw)
To: Paul Moore; +Cc: netdev, Dan Carpenter, linux-security-module, selinux
On Fri, 13 Nov 2020, Paul Moore wrote:
> Static checking revealed that a previous fix to
> netlbl_unlabel_staticlist() leaves a stack variable uninitialized,
> this patches fixes that.
>
> Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Paul Moore <paul@paul-moore.com>
Reviewed-by: James Morris <jamorris@linux.microsoft.com>
> ---
> net/netlabel/netlabel_unlabeled.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netlabel_unlabeled.c
> index fc55c9116da0..ccb491642811 100644
> --- a/net/netlabel/netlabel_unlabeled.c
> +++ b/net/netlabel/netlabel_unlabeled.c
> @@ -1167,7 +1167,7 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb,
> u32 skip_bkt = cb->args[0];
> u32 skip_chain = cb->args[1];
> u32 skip_addr4 = cb->args[2];
> - u32 iter_bkt, iter_chain, iter_addr4 = 0, iter_addr6 = 0;
> + u32 iter_bkt, iter_chain = 0, iter_addr4 = 0, iter_addr6 = 0;
> struct netlbl_unlhsh_iface *iface;
> struct list_head *iter_list;
> struct netlbl_af4list *addr4;
>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist()
2020-11-14 7:03 ` James Morris
@ 2020-11-14 20:09 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-11-14 20:09 UTC (permalink / raw)
To: James Morris
Cc: Paul Moore, netdev, Dan Carpenter, linux-security-module, selinux
On Sat, 14 Nov 2020 18:03:56 +1100 (AEDT) James Morris wrote:
> > Static checking revealed that a previous fix to
> > netlbl_unlabel_staticlist() leaves a stack variable uninitialized,
> > this patches fixes that.
> >
> > Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()")
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Paul Moore <paul@paul-moore.com>
>
> Reviewed-by: James Morris <jamorris@linux.microsoft.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-14 20:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 21:30 [PATCH] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist() Paul Moore
2020-11-14 7:03 ` James Morris
2020-11-14 20:09 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.