From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55595C61DD8 for ; Sat, 14 Nov 2020 07:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26486217A0 for ; Sat, 14 Nov 2020 07:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbgKNHEC (ORCPT ); Sat, 14 Nov 2020 02:04:02 -0500 Received: from namei.org ([65.99.196.166]:53158 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726479AbgKNHEC (ORCPT ); Sat, 14 Nov 2020 02:04:02 -0500 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id 0AE73uCd023314; Sat, 14 Nov 2020 07:03:56 GMT Date: Sat, 14 Nov 2020 18:03:56 +1100 (AEDT) From: James Morris To: Paul Moore cc: netdev@vger.kernel.org, Dan Carpenter , linux-security-module@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist() In-Reply-To: <160530304068.15651.18355773009751195447.stgit@sifl> Message-ID: References: <160530304068.15651.18355773009751195447.stgit@sifl> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 13 Nov 2020, Paul Moore wrote: > Static checking revealed that a previous fix to > netlbl_unlabel_staticlist() leaves a stack variable uninitialized, > this patches fixes that. > > Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()") > Reported-by: Dan Carpenter > Signed-off-by: Paul Moore Reviewed-by: James Morris > --- > net/netlabel/netlabel_unlabeled.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netlabel_unlabeled.c > index fc55c9116da0..ccb491642811 100644 > --- a/net/netlabel/netlabel_unlabeled.c > +++ b/net/netlabel/netlabel_unlabeled.c > @@ -1167,7 +1167,7 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb, > u32 skip_bkt = cb->args[0]; > u32 skip_chain = cb->args[1]; > u32 skip_addr4 = cb->args[2]; > - u32 iter_bkt, iter_chain, iter_addr4 = 0, iter_addr6 = 0; > + u32 iter_bkt, iter_chain = 0, iter_addr4 = 0, iter_addr6 = 0; > struct netlbl_unlhsh_iface *iface; > struct list_head *iter_list; > struct netlbl_af4list *addr4; > -- James Morris