From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757036AbZGCBKP (ORCPT ); Thu, 2 Jul 2009 21:10:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752455AbZGCBKD (ORCPT ); Thu, 2 Jul 2009 21:10:03 -0400 Received: from sovereign.computergmbh.de ([85.214.69.204]:33152 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754878AbZGCBKB (ORCPT ); Thu, 2 Jul 2009 21:10:01 -0400 Date: Fri, 3 Jul 2009 03:10:03 +0200 (CEST) From: Jan Engelhardt To: tridge@samba.org cc: Theodore Tso , Alan Cox , Rusty Russell , Pavel Machek , OGAWA Hirofumi , john.lanza@linux.com, Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, Dave Kleikamp , corbet@lwn.net, jcm@jonmasters.org Subject: Re: CONFIG_VFAT_FS_DUALNAMES regression In-Reply-To: <19021.20449.732095.210252@samba.org> Message-ID: References: <19013.8005.541836.436991@samba.org> <20090630063102.GB1351@ucw.cz> <200907012019.53932.rusty@rustcorp.com.au> <20090701122558.3a7c80d3@lxorguk.ukuu.org.uk> <20090701140503.GA21185@mit.edu> <19021.17576.808138.476600@samba.org> <19021.20449.732095.210252@samba.org> User-Agent: Alpine 2.00 (LSU 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 2009-07-03 02:25, tridge@samba.org wrote: > > > (All with DUALNAMES=n) > > # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=lower > > # cp /mnt/dcim/100_fuji/dscf{4160,3004}.jpg > > # umount /mnt > > # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=win95 > > # cp /mnt/dcim/100_fuji/dscf{4160,3005}.jpg > > # umount /mnt > > # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=winnt > > # cp /mnt/dcim/100_fuji/dscf{4160,3006}.jpg > > # umount /mnt > > # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=mixed > > # cp /mnt/dcim/100_fuji/dscf{4160,3007}.jpg > > # umount /mnt > > > > Result? The camera only displays 3006. > > > > The dualnames patch's filling filenames with random illegal > > chars does seems to have a really foul side-effect after > >actually, you've just proved the patch works as intended on your >device! > >Only the shortname=winnt would create a 8.3 name when you use the >filename dscfNNNN.jpg. The mount(8) manpage becomes pretty ambiguous with the dualnames patch. By default, "store a long name when the short name is not all upper case" would apply - and is invoked because I am a lazy typist who wrote "cp $this dscf3000" instead of "cp $this DSCF3000". Now since dualnames=n is in effect, no long name would need to be written because it still fits into 8.3 — subsequently, one would assume an 8.3 is generated for all shortname= cases. >That is why my first patch in May forced > > shortname_flags = VFAT_SFN_CREATE_WINNT; Making WINNT the default would cause many a `ls` output to just scream at me in uppercaps because there are programs that create long names with all-uppers. shortname really needs to be split into "shortname that is applied during creation" and "shortname that is applied upon readdir". From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Engelhardt Subject: Re: CONFIG_VFAT_FS_DUALNAMES regression Date: Fri, 3 Jul 2009 03:10:03 +0200 (CEST) Message-ID: References: <19013.8005.541836.436991@samba.org> <20090630063102.GB1351@ucw.cz> <200907012019.53932.rusty@rustcorp.com.au> <20090701122558.3a7c80d3@lxorguk.ukuu.org.uk> <20090701140503.GA21185@mit.edu> <19021.17576.808138.476600@samba.org> <19021.20449.732095.210252@samba.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Theodore Tso , Alan Cox , Rusty Russell , Pavel Machek , OGAWA Hirofumi , john.lanza@linux.com, Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, Dave Kleikamp , corbet@lwn.net, jcm@jonmasters.org To: tridge@samba.org Return-path: Received: from sovereign.computergmbh.de ([85.214.69.204]:33152 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754878AbZGCBKB (ORCPT ); Thu, 2 Jul 2009 21:10:01 -0400 In-Reply-To: <19021.20449.732095.210252@samba.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Friday 2009-07-03 02:25, tridge@samba.org wrote: > > > (All with DUALNAMES=3Dn) > > # mount /dev/sdc1 /mnt -o iocharset=3Dutf8,shortnames=3Dlower > > # cp /mnt/dcim/100_fuji/dscf{4160,3004}.jpg > > # umount /mnt > > # mount /dev/sdc1 /mnt -o iocharset=3Dutf8,shortnames=3Dwin95 > > # cp /mnt/dcim/100_fuji/dscf{4160,3005}.jpg > > # umount /mnt > > # mount /dev/sdc1 /mnt -o iocharset=3Dutf8,shortnames=3Dwinnt > > # cp /mnt/dcim/100_fuji/dscf{4160,3006}.jpg > > # umount /mnt > > # mount /dev/sdc1 /mnt -o iocharset=3Dutf8,shortnames=3Dmixed > > # cp /mnt/dcim/100_fuji/dscf{4160,3007}.jpg > > # umount /mnt > >=20 > > Result? The camera only displays 3006. > >=20 > > The dualnames patch's filling filenames with random illegal > > chars does seems to have a really foul side-effect after=20 > >actually, you've just proved the patch works as intended on your >device! > >Only the shortname=3Dwinnt would create a 8.3 name when you use the >filename dscfNNNN.jpg. The mount(8) manpage becomes pretty ambiguous with the dualnames patch. By default, "store a long name when the short name is not all upper case" would apply - and is invoked because I am a lazy typist who wrote "cp $this dscf3000" instead of "cp $this DSCF3000". Now since dualnames=3Dn is in effect, no long name would need to be written because it still fits into 8.3=C2=A0=E2=80=94 subsequently, one would a= ssume an 8.3 is generated for all shortname=3D cases. >That is why my first patch in May forced=20 > > shortname_flags =3D VFAT_SFN_CREATE_WINNT; Making WINNT the default would cause many a `ls` output to just scream at me in uppercaps because there are programs that create long names with all-uppers. shortname really needs to be split into "shortname that is applied during creation" and "shortname that is applied upon readdir". -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html