* [PATCH] Revert "proc: clear_refs: do not clear reserved pages"
@ 2012-04-12 17:00 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2012-04-12 17:00 UTC (permalink / raw)
To: hughd; +Cc: linux-kernel, linux-mm, Will Deacon, Nicolas Pitre
This reverts commit 85e72aa5384b1a614563ad63257ded0e91d1a620, which was
a quick fix suitable for -stable until ARM had been moved over to the
gate_vma mechanism:
https://lkml.org/lkml/2012/1/14/55
With commit f9d4861f ("ARM: 7294/1: vectors: use gate_vma for vectors user
mapping"), ARM does now use the gate_vma, so the PageReserved check can
be removed from the proc code.
Cc: Nicolas Pitre <nico@linaro.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
fs/proc/task_mmu.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 2b9a760..2d60492 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -597,9 +597,6 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr,
if (!page)
continue;
- if (PageReserved(page))
- continue;
-
/* Clear accessed and referenced bits. */
ptep_test_and_clear_young(vma, addr, pte);
ClearPageReferenced(page);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] Revert "proc: clear_refs: do not clear reserved pages"
@ 2012-04-12 17:00 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2012-04-12 17:00 UTC (permalink / raw)
To: hughd; +Cc: linux-kernel, linux-mm, Will Deacon, Nicolas Pitre
This reverts commit 85e72aa5384b1a614563ad63257ded0e91d1a620, which was
a quick fix suitable for -stable until ARM had been moved over to the
gate_vma mechanism:
https://lkml.org/lkml/2012/1/14/55
With commit f9d4861f ("ARM: 7294/1: vectors: use gate_vma for vectors user
mapping"), ARM does now use the gate_vma, so the PageReserved check can
be removed from the proc code.
Cc: Nicolas Pitre <nico@linaro.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
fs/proc/task_mmu.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 2b9a760..2d60492 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -597,9 +597,6 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr,
if (!page)
continue;
- if (PageReserved(page))
- continue;
-
/* Clear accessed and referenced bits. */
ptep_test_and_clear_young(vma, addr, pte);
ClearPageReferenced(page);
--
1.7.4.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Revert "proc: clear_refs: do not clear reserved pages"
2012-04-12 17:00 ` Will Deacon
@ 2012-04-12 17:51 ` Hugh Dickins
-1 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2012-04-12 17:51 UTC (permalink / raw)
To: Will Deacon; +Cc: linux-kernel, linux-mm, Nicolas Pitre
On Thu, 12 Apr 2012, Will Deacon wrote:
> This reverts commit 85e72aa5384b1a614563ad63257ded0e91d1a620, which was
> a quick fix suitable for -stable until ARM had been moved over to the
> gate_vma mechanism:
>
> https://lkml.org/lkml/2012/1/14/55
>
> With commit f9d4861f ("ARM: 7294/1: vectors: use gate_vma for vectors user
> mapping"), ARM does now use the gate_vma, so the PageReserved check can
> be removed from the proc code.
>
> Cc: Nicolas Pitre <nico@linaro.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Oh, great, I'm glad that worked out: thanks a lot for looking after it,
Will, and now cleaning up afterwards.
Acked-by: Hugh Dickins <hughd@google.com>
> ---
> fs/proc/task_mmu.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 2b9a760..2d60492 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -597,9 +597,6 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr,
> if (!page)
> continue;
>
> - if (PageReserved(page))
> - continue;
> -
> /* Clear accessed and referenced bits. */
> ptep_test_and_clear_young(vma, addr, pte);
> ClearPageReferenced(page);
> --
> 1.7.4.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Revert "proc: clear_refs: do not clear reserved pages"
@ 2012-04-12 17:51 ` Hugh Dickins
0 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2012-04-12 17:51 UTC (permalink / raw)
To: Will Deacon; +Cc: linux-kernel, linux-mm, Nicolas Pitre
On Thu, 12 Apr 2012, Will Deacon wrote:
> This reverts commit 85e72aa5384b1a614563ad63257ded0e91d1a620, which was
> a quick fix suitable for -stable until ARM had been moved over to the
> gate_vma mechanism:
>
> https://lkml.org/lkml/2012/1/14/55
>
> With commit f9d4861f ("ARM: 7294/1: vectors: use gate_vma for vectors user
> mapping"), ARM does now use the gate_vma, so the PageReserved check can
> be removed from the proc code.
>
> Cc: Nicolas Pitre <nico@linaro.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Oh, great, I'm glad that worked out: thanks a lot for looking after it,
Will, and now cleaning up afterwards.
Acked-by: Hugh Dickins <hughd@google.com>
> ---
> fs/proc/task_mmu.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 2b9a760..2d60492 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -597,9 +597,6 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr,
> if (!page)
> continue;
>
> - if (PageReserved(page))
> - continue;
> -
> /* Clear accessed and referenced bits. */
> ptep_test_and_clear_young(vma, addr, pte);
> ClearPageReferenced(page);
> --
> 1.7.4.1
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Revert "proc: clear_refs: do not clear reserved pages"
2012-04-12 17:51 ` Hugh Dickins
@ 2012-04-13 9:22 ` Will Deacon
-1 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2012-04-13 9:22 UTC (permalink / raw)
To: Hugh Dickins; +Cc: linux-kernel, linux-mm, Nicolas Pitre, akpm
On Thu, Apr 12, 2012 at 06:51:10PM +0100, Hugh Dickins wrote:
> On Thu, 12 Apr 2012, Will Deacon wrote:
>
> > This reverts commit 85e72aa5384b1a614563ad63257ded0e91d1a620, which was
> > a quick fix suitable for -stable until ARM had been moved over to the
> > gate_vma mechanism:
> >
> > https://lkml.org/lkml/2012/1/14/55
> >
> > With commit f9d4861f ("ARM: 7294/1: vectors: use gate_vma for vectors user
> > mapping"), ARM does now use the gate_vma, so the PageReserved check can
> > be removed from the proc code.
> >
> > Cc: Nicolas Pitre <nico@linaro.org>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
>
> Oh, great, I'm glad that worked out: thanks a lot for looking after it,
> Will, and now cleaning up afterwards.
>
> Acked-by: Hugh Dickins <hughd@google.com>
Thanks, Hugh. I guess it's easiest if Andrew picks this one up as he took
the original patch.
Will
> > ---
> > fs/proc/task_mmu.c | 3 ---
> > 1 files changed, 0 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> > index 2b9a760..2d60492 100644
> > --- a/fs/proc/task_mmu.c
> > +++ b/fs/proc/task_mmu.c
> > @@ -597,9 +597,6 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr,
> > if (!page)
> > continue;
> >
> > - if (PageReserved(page))
> > - continue;
> > -
> > /* Clear accessed and referenced bits. */
> > ptep_test_and_clear_young(vma, addr, pte);
> > ClearPageReferenced(page);
> > --
> > 1.7.4.1
> >
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Revert "proc: clear_refs: do not clear reserved pages"
@ 2012-04-13 9:22 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2012-04-13 9:22 UTC (permalink / raw)
To: Hugh Dickins; +Cc: linux-kernel, linux-mm, Nicolas Pitre, akpm
On Thu, Apr 12, 2012 at 06:51:10PM +0100, Hugh Dickins wrote:
> On Thu, 12 Apr 2012, Will Deacon wrote:
>
> > This reverts commit 85e72aa5384b1a614563ad63257ded0e91d1a620, which was
> > a quick fix suitable for -stable until ARM had been moved over to the
> > gate_vma mechanism:
> >
> > https://lkml.org/lkml/2012/1/14/55
> >
> > With commit f9d4861f ("ARM: 7294/1: vectors: use gate_vma for vectors user
> > mapping"), ARM does now use the gate_vma, so the PageReserved check can
> > be removed from the proc code.
> >
> > Cc: Nicolas Pitre <nico@linaro.org>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
>
> Oh, great, I'm glad that worked out: thanks a lot for looking after it,
> Will, and now cleaning up afterwards.
>
> Acked-by: Hugh Dickins <hughd@google.com>
Thanks, Hugh. I guess it's easiest if Andrew picks this one up as he took
the original patch.
Will
> > ---
> > fs/proc/task_mmu.c | 3 ---
> > 1 files changed, 0 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> > index 2b9a760..2d60492 100644
> > --- a/fs/proc/task_mmu.c
> > +++ b/fs/proc/task_mmu.c
> > @@ -597,9 +597,6 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr,
> > if (!page)
> > continue;
> >
> > - if (PageReserved(page))
> > - continue;
> > -
> > /* Clear accessed and referenced bits. */
> > ptep_test_and_clear_young(vma, addr, pte);
> > ClearPageReferenced(page);
> > --
> > 1.7.4.1
> >
> >
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-13 9:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-12 17:00 [PATCH] Revert "proc: clear_refs: do not clear reserved pages" Will Deacon
2012-04-12 17:00 ` Will Deacon
2012-04-12 17:51 ` Hugh Dickins
2012-04-12 17:51 ` Hugh Dickins
2012-04-13 9:22 ` Will Deacon
2012-04-13 9:22 ` Will Deacon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.