From: Hugh Dickins <hughd@google.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE
Date: Wed, 11 Jul 2012 11:55:34 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.00.1207111149580.1797@eggly.anvils> (raw)
In-Reply-To: <jtj574$tb7$2@dough.gmane.org>
On Wed, 11 Jul 2012, Cong Wang wrote:
> On Mon, 09 Jul 2012 at 22:41 GMT, Hugh Dickins <hughd@google.com> wrote:
> > Revert 4fb5ef089b28 ("tmpfs: support SEEK_DATA and SEEK_HOLE").
> > I believe it's correct, and it's been nice to have from rc1 to rc6;
> > but as the original commit said:
> >
> > I don't know who actually uses SEEK_DATA or SEEK_HOLE, and whether it
> > would be of any use to them on tmpfs. This code adds 92 lines and 752
> > bytes on x86_64 - is that bloat or worthwhile?
>
>
> I don't think 752 bytes matter much, especially for x86_64.
>
> >
> > Nobody asked for it, so I conclude that it's bloat: let's revert tmpfs
> > to the dumb generic support for v3.5. We can always reinstate it later
> > if useful, and anyone needing it in a hurry can just get it out of git.
> >
>
> If you don't have burden to maintain it, I'd prefer to leave as it is,
> I don't think 752-bytes is the reason we revert it.
Thank you, your vote has been counted ;)
and I'll be glad if yours stimulates some agreement or disagreement.
But your vote would count for a lot more if you know of some app which
would really benefit from this functionality in tmpfs: I've heard of none.
Hugh
WARNING: multiple messages have this Message-ID (diff)
From: Hugh Dickins <hughd@google.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE
Date: Wed, 11 Jul 2012 11:55:34 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.00.1207111149580.1797@eggly.anvils> (raw)
In-Reply-To: <jtj574$tb7$2@dough.gmane.org>
On Wed, 11 Jul 2012, Cong Wang wrote:
> On Mon, 09 Jul 2012 at 22:41 GMT, Hugh Dickins <hughd@google.com> wrote:
> > Revert 4fb5ef089b28 ("tmpfs: support SEEK_DATA and SEEK_HOLE").
> > I believe it's correct, and it's been nice to have from rc1 to rc6;
> > but as the original commit said:
> >
> > I don't know who actually uses SEEK_DATA or SEEK_HOLE, and whether it
> > would be of any use to them on tmpfs. This code adds 92 lines and 752
> > bytes on x86_64 - is that bloat or worthwhile?
>
>
> I don't think 752 bytes matter much, especially for x86_64.
>
> >
> > Nobody asked for it, so I conclude that it's bloat: let's revert tmpfs
> > to the dumb generic support for v3.5. We can always reinstate it later
> > if useful, and anyone needing it in a hurry can just get it out of git.
> >
>
> If you don't have burden to maintain it, I'd prefer to leave as it is,
> I don't think 752-bytes is the reason we revert it.
Thank you, your vote has been counted ;)
and I'll be glad if yours stimulates some agreement or disagreement.
But your vote would count for a lot more if you know of some app which
would really benefit from this functionality in tmpfs: I've heard of none.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-11 18:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 22:35 [PATCH 0/3] shmem/tmpfs: three late patches Hugh Dickins
2012-07-09 22:35 ` Hugh Dickins
2012-07-09 22:41 ` [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE Hugh Dickins
2012-07-09 22:41 ` Hugh Dickins
2012-07-11 6:07 ` Cong Wang
2012-07-11 6:07 ` Cong Wang
2012-07-11 18:55 ` Hugh Dickins [this message]
2012-07-11 18:55 ` Hugh Dickins
2012-07-11 23:01 ` Dave Chinner
2012-07-11 23:01 ` Dave Chinner
2012-07-12 2:50 ` Hugh Dickins
2012-07-12 2:50 ` Hugh Dickins
2012-07-12 3:21 ` Jeff Liu
2012-07-12 3:21 ` Jeff Liu
2012-07-16 9:28 ` Hugh Dickins
2012-07-16 9:28 ` Hugh Dickins
2012-07-17 6:15 ` Jeff Liu
2012-07-17 6:15 ` Jeff Liu
2012-07-31 14:30 ` Jim Meyering
2012-07-31 14:42 ` Jim Meyering
2012-08-08 2:08 ` Hugh Dickins
2012-08-14 17:03 ` Paul Eggert
2012-07-09 22:44 ` [PATCH 2/3] shmem: fix negative rss in memcg memory.stat Hugh Dickins
2012-07-09 22:44 ` Hugh Dickins
2012-07-10 12:41 ` Johannes Weiner
2012-07-10 12:41 ` Johannes Weiner
2012-07-11 18:15 ` Hugh Dickins
2012-07-11 18:15 ` Hugh Dickins
2012-07-09 22:46 ` [PATCH 3/3] shmem: cleanup shmem_add_to_page_cache Hugh Dickins
2012-07-09 22:46 ` Hugh Dickins
2012-07-10 13:01 ` Johannes Weiner
2012-07-10 13:01 ` Johannes Weiner
2012-07-09 23:39 ` [PATCH 0/3] shmem/tmpfs: three late patches Andrew Morton
2012-07-09 23:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1207111149580.1797@eggly.anvils \
--to=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.