From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1DDDC433E2 for ; Sat, 4 Jul 2020 06:04:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91CD3208D5 for ; Sat, 4 Jul 2020 06:04:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dIqRlaEr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726999AbgGDGEK (ORCPT ); Sat, 4 Jul 2020 02:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725822AbgGDGEJ (ORCPT ); Sat, 4 Jul 2020 02:04:09 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D2E0C061794 for ; Fri, 3 Jul 2020 23:04:09 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id k18so30546967qke.4 for ; Fri, 03 Jul 2020 23:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=3uTkGXCAk+3Dr7vFnMZldoI9/Xu0K+I5So+JvZVt7wE=; b=dIqRlaErH4Y7zKvejrBLSR/B+YkZXI5vdPMrudh/dYE310ga4jdpGQFobhwmyy2gWM biGPOnmnrK4NU3P3qtLrSG/oC/k/SMccPJvFdJyMte0Uv1Qr2uzWMdbHyRkJF1O04pEt hSRY9GSO2DlZJ9Is3ADoPrDahyDpB44lHyVFuEFh/YMzWK8Cwhc03m8eequlkv9Eiu+s 5vEPGLdJJlndvxLPbozrzfnvorPNEnUrbrBwj0Ai1iLk2noJPm7qJmI+XYtOr7b4CCzD 7RJdG9DdP2zPU5KOaSfMouwEP0iEG5Pl+aFgdZ7Fkq1zt6fi4SJ4Jf5qqUtveMzv/lqd j6sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=3uTkGXCAk+3Dr7vFnMZldoI9/Xu0K+I5So+JvZVt7wE=; b=F+DF++iwCuYJb63Amjm7GEFN0ciOoOipjjx7NTFfQysRZHS/dPF8s+2DSu+UdTaUUk fzOsrBwYEtceuVHcVH8s5Cludk48uA4ozcvgGpVfKCZpTwiCvMHK8C29qfsW9oVSr2xz Hz1Ir5D9+vkOF04JL6MSHiJp9BsVPkxc88sMzRlclUJ5MfF/kADC4mLV52LaN9ztbWaB 8LCGujHwvhOQPOIKbRxWFxkslvO+CvwsMibKguYXw1wClnkPpyVvBKl9yMOuhmdmKV+l v/ReznftLyxVAj3zbrSVPiY1zF6PRHmCSB/X0W2qbYBktqsR8PIWGHZzlD1IWtFtONWG ODWw== X-Gm-Message-State: AOAM5307D2bzY9cubxL80eVzXCd9hmGW58U/87xrPKI5qvc12E58utrZ TAd8sMONzTkCX9Zk2G/nsp0A+w== X-Google-Smtp-Source: ABdhPJwgA4+MO/5bqb1Xtep0chOWAEMChUr7hxcnAlsU6M0jd3LkZi8JBGv+rmzWYfC2MHQ2h+HPOw== X-Received: by 2002:a05:620a:2002:: with SMTP id c2mr18790432qka.35.1593842647186; Fri, 03 Jul 2020 23:04:07 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id t138sm12151124qka.15.2020.07.03.23.04.05 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Fri, 03 Jul 2020 23:04:06 -0700 (PDT) Date: Fri, 3 Jul 2020 23:03:52 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Chengguang Xu cc: akpm@linux-foundation.org, dxu@dxuuu.xyz, chris@chrisdown.name, adilger@dilger.ca, gregkh@linuxfoundation.org, tj@kernel.org, viro@zeniv.linux.org.uk, hughd@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2] vfs/xattr: mm/shmem: kernfs: release simple xattr entry in a right way In-Reply-To: <20200704051608.15043-1-cgxu519@mykernel.net> Message-ID: References: <20200704051608.15043-1-cgxu519@mykernel.net> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, 4 Jul 2020, Chengguang Xu wrote: > After commit fdc85222d58e ("kernfs: kvmalloc xattr value > instead of kmalloc"), simple xattr entry is allocated with > kvmalloc() instead of kmalloc(), so we should release it > with kvfree() instead of kfree(). > > Cc: stable@vger.kernel.org # v5.7 > Cc: Daniel Xu > Cc: Chris Down > Cc: Andreas Dilger > Cc: Greg Kroah-Hartman > Cc: Tejun Heo > Cc: Al Viro > Cc: Hugh Dickins > Fixes: fdc85222d58e ("kernfs: kvmalloc xattr value instead of kmalloc") > Signed-off-by: Chengguang Xu Good catch, thank you: Acked-by: Hugh Dickins > --- > v1->v2: > - Fix freeing issue in simple_xattrs_free(). > - Change patch subject. > > include/linux/xattr.h | 3 ++- > mm/shmem.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/xattr.h b/include/linux/xattr.h > index 47eaa34f8761..c5afaf8ca7a2 100644 > --- a/include/linux/xattr.h > +++ b/include/linux/xattr.h > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > > struct inode; > @@ -94,7 +95,7 @@ static inline void simple_xattrs_free(struct simple_xattrs *xattrs) > > list_for_each_entry_safe(xattr, node, &xattrs->head, list) { > kfree(xattr->name); > - kfree(xattr); > + kvfree(xattr); > } > } > > diff --git a/mm/shmem.c b/mm/shmem.c > index a0dbe62f8042..b2abca3f7f33 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3178,7 +3178,7 @@ static int shmem_initxattrs(struct inode *inode, > new_xattr->name = kmalloc(XATTR_SECURITY_PREFIX_LEN + len, > GFP_KERNEL); > if (!new_xattr->name) { > - kfree(new_xattr); > + kvfree(new_xattr); > return -ENOMEM; > } > > -- > 2.20.1 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14270C433E1 for ; Sat, 4 Jul 2020 06:04:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CCF51208D5 for ; Sat, 4 Jul 2020 06:04:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dIqRlaEr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCF51208D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B1228D0054; Sat, 4 Jul 2020 02:04:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 339D38D0001; Sat, 4 Jul 2020 02:04:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B43B8D0054; Sat, 4 Jul 2020 02:04:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id F044A8D0001 for ; Sat, 4 Jul 2020 02:04:08 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A213A2A87 for ; Sat, 4 Jul 2020 06:04:08 +0000 (UTC) X-FDA: 76999352976.20.shelf10_5c039fd26e98 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 7AE08180C07AF for ; Sat, 4 Jul 2020 06:04:08 +0000 (UTC) X-HE-Tag: shelf10_5c039fd26e98 X-Filterd-Recvd-Size: 5216 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Sat, 4 Jul 2020 06:04:08 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id b185so19958083qkg.1 for ; Fri, 03 Jul 2020 23:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=3uTkGXCAk+3Dr7vFnMZldoI9/Xu0K+I5So+JvZVt7wE=; b=dIqRlaErH4Y7zKvejrBLSR/B+YkZXI5vdPMrudh/dYE310ga4jdpGQFobhwmyy2gWM biGPOnmnrK4NU3P3qtLrSG/oC/k/SMccPJvFdJyMte0Uv1Qr2uzWMdbHyRkJF1O04pEt hSRY9GSO2DlZJ9Is3ADoPrDahyDpB44lHyVFuEFh/YMzWK8Cwhc03m8eequlkv9Eiu+s 5vEPGLdJJlndvxLPbozrzfnvorPNEnUrbrBwj0Ai1iLk2noJPm7qJmI+XYtOr7b4CCzD 7RJdG9DdP2zPU5KOaSfMouwEP0iEG5Pl+aFgdZ7Fkq1zt6fi4SJ4Jf5qqUtveMzv/lqd j6sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=3uTkGXCAk+3Dr7vFnMZldoI9/Xu0K+I5So+JvZVt7wE=; b=XS2VxKl2RWxCkDXPXQaMvkU0iCVdEDuHv95K8ngjis5vN6ImWn1L+cX7yRerGuDJJM t2HJoJE4WqLnCyjr8sbSTEutAuhvrY8VLMHtYmmNsbOeUtfOxSAkX70Mv6haSDcpKL9T CewuqWs9eDxZYbOYZiLzXBOP4Ne8tYGOS/WxX99F94YPcDXBDRt5SIC/uF89TuEiO2yL /D0qfNyNtMolRevNboydggqElTgUV8Zf8SO9/7AP8057xbnGiW9OWtf393gpPmGJwDNP TZThAF7aiLgOw/w0aH1T31gurCEENi6v6bLUzn5D8RFWRNXJ9yUSFunqHAo0ubN+MsID J0wQ== X-Gm-Message-State: AOAM531FF6e2yWbYEtuICDAHByCXeIABZ6Sk7A4o/zqGQfhkFh6O7RRZ GG6RltExVd8xAJOkkBwg0s6upg== X-Google-Smtp-Source: ABdhPJwgA4+MO/5bqb1Xtep0chOWAEMChUr7hxcnAlsU6M0jd3LkZi8JBGv+rmzWYfC2MHQ2h+HPOw== X-Received: by 2002:a05:620a:2002:: with SMTP id c2mr18790432qka.35.1593842647186; Fri, 03 Jul 2020 23:04:07 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id t138sm12151124qka.15.2020.07.03.23.04.05 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Fri, 03 Jul 2020 23:04:06 -0700 (PDT) Date: Fri, 3 Jul 2020 23:03:52 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Chengguang Xu cc: akpm@linux-foundation.org, dxu@dxuuu.xyz, chris@chrisdown.name, adilger@dilger.ca, gregkh@linuxfoundation.org, tj@kernel.org, viro@zeniv.linux.org.uk, hughd@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2] vfs/xattr: mm/shmem: kernfs: release simple xattr entry in a right way In-Reply-To: <20200704051608.15043-1-cgxu519@mykernel.net> Message-ID: References: <20200704051608.15043-1-cgxu519@mykernel.net> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Rspamd-Queue-Id: 7AE08180C07AF X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 4 Jul 2020, Chengguang Xu wrote: > After commit fdc85222d58e ("kernfs: kvmalloc xattr value > instead of kmalloc"), simple xattr entry is allocated with > kvmalloc() instead of kmalloc(), so we should release it > with kvfree() instead of kfree(). > > Cc: stable@vger.kernel.org # v5.7 > Cc: Daniel Xu > Cc: Chris Down > Cc: Andreas Dilger > Cc: Greg Kroah-Hartman > Cc: Tejun Heo > Cc: Al Viro > Cc: Hugh Dickins > Fixes: fdc85222d58e ("kernfs: kvmalloc xattr value instead of kmalloc") > Signed-off-by: Chengguang Xu Good catch, thank you: Acked-by: Hugh Dickins > --- > v1->v2: > - Fix freeing issue in simple_xattrs_free(). > - Change patch subject. > > include/linux/xattr.h | 3 ++- > mm/shmem.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/xattr.h b/include/linux/xattr.h > index 47eaa34f8761..c5afaf8ca7a2 100644 > --- a/include/linux/xattr.h > +++ b/include/linux/xattr.h > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > > struct inode; > @@ -94,7 +95,7 @@ static inline void simple_xattrs_free(struct simple_xattrs *xattrs) > > list_for_each_entry_safe(xattr, node, &xattrs->head, list) { > kfree(xattr->name); > - kfree(xattr); > + kvfree(xattr); > } > } > > diff --git a/mm/shmem.c b/mm/shmem.c > index a0dbe62f8042..b2abca3f7f33 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3178,7 +3178,7 @@ static int shmem_initxattrs(struct inode *inode, > new_xattr->name = kmalloc(XATTR_SECURITY_PREFIX_LEN + len, > GFP_KERNEL); > if (!new_xattr->name) { > - kfree(new_xattr); > + kvfree(new_xattr); > return -ENOMEM; > } > > -- > 2.20.1 > > > >