From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3443C4363D for ; Tue, 22 Sep 2020 05:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8367D23A84 for ; Tue, 22 Sep 2020 05:53:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u+iUdxzi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729061AbgIVFxO (ORCPT ); Tue, 22 Sep 2020 01:53:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726488AbgIVFxO (ORCPT ); Tue, 22 Sep 2020 01:53:14 -0400 Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCF1FC061755 for ; Mon, 21 Sep 2020 22:53:13 -0700 (PDT) Received: by mail-oi1-x244.google.com with SMTP id m7so19840477oie.0 for ; Mon, 21 Sep 2020 22:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=rj2KbrP8wDZHh7cva4yvY3TOcqZLJGweHnZrrr56Tas=; b=u+iUdxziFYUXXIs1aAqLKK5bC0JUncRoDRqo+fL11mZ37Ha6MX72UFkY+p4FBfLyxh zc00OHlQ+bY0vgqZB3XzRj+CyCwhquUofnrXhKsX1S9T4TGV313nL6TGQUrf9iB+4y0L qKilbf2LjFsSE+GBXwLaCPPWfaPIz+XwsVZW+erBJJJCxCyW0orCiGUR+rVyLV9p6ngN ruJWdxUGqQqpjFrm3baZ2BUfkIFeFHvnOlilwP0WSuWAvU/ObFzb1qIUAza1heNknuAp m/eSdALJmQq9lY6eqfsyysc0OvHuFaKfoqDoa1UnNwMlplj+jY2SFo43oDxYG3zQvblU 7P5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=rj2KbrP8wDZHh7cva4yvY3TOcqZLJGweHnZrrr56Tas=; b=nWPEY4WHvNBNo7+9hKwYhYd/ht/tSRUzjyie4cSdBOt1HXyDpWFvgS3vLuvpBzx00F MN9ONC6jzHBjsUtnaIZaKg/0HGZvmJucScXh61xiDguM8zrNAt+i84fBSkeiajx1WbXa 8oD1Bj6aavycqyViAikcYy3JzKTHaMYtBtqWgz7jCAEZ4RZ39p8rFIIBsxzsgMMephCl SK1ntNjB677MLXKoByRzwKiki/eZEzOIF+qKk9jqKJ5QscncsXIEzxjv1LQINcgdFWUN Ft/Zxb9U0e3bsSmZHVQIgheQ+E1AdI4BDXU92jnkMULJVKU2JcuVkVa/XXrQY5QN82/5 +jfg== X-Gm-Message-State: AOAM532UJ9FDmDnFXEGf48uj7BQdj2JXYcB8W4/0oLx5bMIbNIfpZ92j XMWodb5PmZH7mbLqcjN1JAIGbg== X-Google-Smtp-Source: ABdhPJwZijAs4pF+sGPJJ3xNkD1kodRHEYO50xvVByHQ87LR9vg0dhPsrsUYCRvTKbSIyxva3wEJMw== X-Received: by 2002:aca:55c5:: with SMTP id j188mr1749314oib.138.1600753992827; Mon, 21 Sep 2020 22:53:12 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id f50sm6777567otf.47.2020.09.21.22.53.10 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 21 Sep 2020 22:53:11 -0700 (PDT) Date: Mon, 21 Sep 2020 22:53:09 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Alex Shi cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com Subject: Re: [PATCH v18 24/32] mm/pgdat: remove pgdat lru_lock In-Reply-To: <1598273705-69124-25-git-send-email-alex.shi@linux.alibaba.com> Message-ID: References: <1598273705-69124-1-git-send-email-alex.shi@linux.alibaba.com> <1598273705-69124-25-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Aug 2020, Alex Shi wrote: > Now pgdat.lru_lock was replaced by lruvec lock. It's not used anymore. > > Signed-off-by: Alex Shi > Reviewed-by: Alexander Duyck I don't take pleasure in spoiling your celebrations and ceremonies, but I strongly agree with AlexD that this should simply be merged into the big one, 20/32. That can be ceremony enough. > Cc: Andrew Morton > Cc: Konstantin Khlebnikov > Cc: Hugh Dickins > Cc: Johannes Weiner > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: cgroups@vger.kernel.org > --- > include/linux/mmzone.h | 1 - > mm/page_alloc.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index f0596e634863..0ed520954843 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -758,7 +758,6 @@ struct deferred_split { > > /* Write-intensive fields used by page reclaim */ > ZONE_PADDING(_pad1_) > - spinlock_t lru_lock; > > #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > /* > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index fab5e97dc9ca..775120fcc869 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6733,7 +6733,6 @@ static void __meminit pgdat_init_internals(struct pglist_data *pgdat) > init_waitqueue_head(&pgdat->pfmemalloc_wait); > > pgdat_page_ext_init(pgdat); > - spin_lock_init(&pgdat->lru_lock); > lruvec_init(&pgdat->__lruvec); > } > > -- > 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hugh Dickins Subject: Re: [PATCH v18 24/32] mm/pgdat: remove pgdat lru_lock Date: Mon, 21 Sep 2020 22:53:09 -0700 (PDT) Message-ID: References: <1598273705-69124-1-git-send-email-alex.shi@linux.alibaba.com> <1598273705-69124-25-git-send-email-alex.shi@linux.alibaba.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=rj2KbrP8wDZHh7cva4yvY3TOcqZLJGweHnZrrr56Tas=; b=u+iUdxziFYUXXIs1aAqLKK5bC0JUncRoDRqo+fL11mZ37Ha6MX72UFkY+p4FBfLyxh zc00OHlQ+bY0vgqZB3XzRj+CyCwhquUofnrXhKsX1S9T4TGV313nL6TGQUrf9iB+4y0L qKilbf2LjFsSE+GBXwLaCPPWfaPIz+XwsVZW+erBJJJCxCyW0orCiGUR+rVyLV9p6ngN ruJWdxUGqQqpjFrm3baZ2BUfkIFeFHvnOlilwP0WSuWAvU/ObFzb1qIUAza1heNknuAp m/eSdALJmQq9lY6eqfsyysc0OvHuFaKfoqDoa1UnNwMlplj+jY2SFo43oDxYG3zQvblU 7P5Q== In-Reply-To: <1598273705-69124-25-git-send-email-alex.shi@linux.alibaba.com> List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com On Mon, 24 Aug 2020, Alex Shi wrote: > Now pgdat.lru_lock was replaced by lruvec lock. It's not used anymore. > > Signed-off-by: Alex Shi > Reviewed-by: Alexander Duyck I don't take pleasure in spoiling your celebrations and ceremonies, but I strongly agree with AlexD that this should simply be merged into the big one, 20/32. That can be ceremony enough. > Cc: Andrew Morton > Cc: Konstantin Khlebnikov > Cc: Hugh Dickins > Cc: Johannes Weiner > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: cgroups@vger.kernel.org > --- > include/linux/mmzone.h | 1 - > mm/page_alloc.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index f0596e634863..0ed520954843 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -758,7 +758,6 @@ struct deferred_split { > > /* Write-intensive fields used by page reclaim */ > ZONE_PADDING(_pad1_) > - spinlock_t lru_lock; > > #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > /* > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index fab5e97dc9ca..775120fcc869 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6733,7 +6733,6 @@ static void __meminit pgdat_init_internals(struct pglist_data *pgdat) > init_waitqueue_head(&pgdat->pfmemalloc_wait); > > pgdat_page_ext_init(pgdat); > - spin_lock_init(&pgdat->lru_lock); > lruvec_init(&pgdat->__lruvec); > } > > -- > 1.8.3.1