From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E7BC56202 for ; Wed, 25 Nov 2020 02:51:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A189B20DD4 for ; Wed, 25 Nov 2020 02:51:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YNeYz6LI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727046AbgKYCvB (ORCPT ); Tue, 24 Nov 2020 21:51:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbgKYCvB (ORCPT ); Tue, 24 Nov 2020 21:51:01 -0500 Received: from mail-oo1-xc42.google.com (mail-oo1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F68FC0613D4 for ; Tue, 24 Nov 2020 18:50:48 -0800 (PST) Received: by mail-oo1-xc42.google.com with SMTP id t10so155063oon.4 for ; Tue, 24 Nov 2020 18:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=pZ7yTwzr1UVwX/XHITOiHT7kma/jH9EnOU7ZqW6Z6RM=; b=YNeYz6LI+AghX3JPBap3pd8R8Wf7R6RrNw+OuCNiN3m2v7471fhM7exG1z8l5JdDZ/ 8+rsMtZGSKl2fFNdrgvHD4gOjGJUyJsuRrOudh6i1n3gUvyMRrXpvcyWiy9vIuQDRZEX ewvy4j+tDRAv3H1CXZeToi1EmLi4/OKLrEf4Iq70Lqd8bpsWgntjXnByE8058UnRXadh 6Fdsy/f9CENebsk93jgPNyv6ygZ1/HR941IUBWEKpDrh3buU/jGVO4ZhZM9fWWw+D6rx Yu7TW7AiuFf3KAbyEoND/GNS5mycj2rTkSnVOBa0YxKUqoFiIFwwyC3E73VvdwZnHKdw UJvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=pZ7yTwzr1UVwX/XHITOiHT7kma/jH9EnOU7ZqW6Z6RM=; b=GvKVTzpHvKFP/Scff8I2l3Al+g9P3+7wLue0xVZOifj+bXnQmt49dA49ghqkfhAYHo eRiOnBs4Y3ojOpMimst3ln/aH80nieUl115mb8Jxxv/VXcxPbxmL1S0Vl7/I0LUTm5vb xTWeY3aNEOwH2zXy5ZDuQzQEy0wIpCEaaaeuml96idpbxpgPn8B7bjxICa9X49QzJMfj wQoL86bVXxQloewVGKG4lXfvnipS0PVEyQ6d8j4whV+tzh04TtyaHFW4mY8QFfQqVDja x4vmNynMOqHs0FBN1IvoR1b0MDQgbMG71IOgBFTiHst4oiXtiCS+2Q83lgzqSdgL821L th+g== X-Gm-Message-State: AOAM5327+Vrz5BoP2WiFnmLP7YMzfQXT1p/uTX025Puk2l93W1GhWRQu PnX4l29tCSl4P3zcR5XzFuhOVA== X-Google-Smtp-Source: ABdhPJxw3Cv2mCf5NBEDJPNiP7e1tx/wj45SOuv55MJID8vu6pXCZY7IXdHyeknTPg8OEVnf9b95Pg== X-Received: by 2002:a4a:764e:: with SMTP id w14mr1208367ooe.56.1606272647591; Tue, 24 Nov 2020 18:50:47 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id l7sm522243oth.73.2020.11.24.18.50.45 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 24 Nov 2020 18:50:46 -0800 (PST) Date: Tue, 24 Nov 2020 18:50:32 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Matthew Wilcox cc: Hugh Dickins , Andrew Morton , Jan Kara , William Kucharski , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP In-Reply-To: <20201125023234.GH4327@casper.infradead.org> Message-ID: References: <20201112212641.27837-1-willy@infradead.org> <20201117153947.GL29991@casper.infradead.org> <20201117191513.GV29991@casper.infradead.org> <20201117234302.GC29991@casper.infradead.org> <20201125023234.GH4327@casper.infradead.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Nov 2020, Matthew Wilcox wrote: > On Tue, Nov 17, 2020 at 11:43:02PM +0000, Matthew Wilcox wrote: > > On Tue, Nov 17, 2020 at 07:15:13PM +0000, Matthew Wilcox wrote: > > > I find both of these functions exceptionally confusing. Does this > > > make it easier to understand? > > > > Never mind, this is buggy. I'll send something better tomorrow. > > That took a week, not a day. *sigh*. At least this is shorter. Thanks, I'll give it a try (along with the other 4, on top of the 12: maybe on -rc5, maybe on today's mmotm, I'll decide that later). Shorter you say, that's good: I was disheartened by the way it got more complicated, after your initial truncate_inode_partial_page() neatness. Any hints on what was wrong with my simple fixup to that? (But I didn't spend any more time trying to prove or disprove it.) Hugh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 514B8C56202 for ; Wed, 25 Nov 2020 02:50:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 84BED20789 for ; Wed, 25 Nov 2020 02:50:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YNeYz6LI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84BED20789 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A3B2F6B006E; Tue, 24 Nov 2020 21:50:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EDA06B0070; Tue, 24 Nov 2020 21:50:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DA6D6B0071; Tue, 24 Nov 2020 21:50:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id 776FA6B006E for ; Tue, 24 Nov 2020 21:50:49 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2F4908249980 for ; Wed, 25 Nov 2020 02:50:49 +0000 (UTC) X-FDA: 77521413018.03.view82_060272f27373 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 1206328A4E8 for ; Wed, 25 Nov 2020 02:50:49 +0000 (UTC) X-HE-Tag: view82_060272f27373 X-Filterd-Recvd-Size: 4363 Received: from mail-oo1-f68.google.com (mail-oo1-f68.google.com [209.85.161.68]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 02:50:48 +0000 (UTC) Received: by mail-oo1-f68.google.com with SMTP id r11so146754oos.12 for ; Tue, 24 Nov 2020 18:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=pZ7yTwzr1UVwX/XHITOiHT7kma/jH9EnOU7ZqW6Z6RM=; b=YNeYz6LI+AghX3JPBap3pd8R8Wf7R6RrNw+OuCNiN3m2v7471fhM7exG1z8l5JdDZ/ 8+rsMtZGSKl2fFNdrgvHD4gOjGJUyJsuRrOudh6i1n3gUvyMRrXpvcyWiy9vIuQDRZEX ewvy4j+tDRAv3H1CXZeToi1EmLi4/OKLrEf4Iq70Lqd8bpsWgntjXnByE8058UnRXadh 6Fdsy/f9CENebsk93jgPNyv6ygZ1/HR941IUBWEKpDrh3buU/jGVO4ZhZM9fWWw+D6rx Yu7TW7AiuFf3KAbyEoND/GNS5mycj2rTkSnVOBa0YxKUqoFiIFwwyC3E73VvdwZnHKdw UJvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=pZ7yTwzr1UVwX/XHITOiHT7kma/jH9EnOU7ZqW6Z6RM=; b=ZV4a4h29wX8HnrGNhUfrAgznwIIB5jxOCXsWeC34kueWqeEQ+j2rNKu50n+rWdHnxA 1xkl01q6piKj39f0zTlr/ZV6W42j7IEl+qqRSd/yAlVlYZRDFnEAUeFdzT7HV6QFChwG CJMrDxg9nKl4e+RfcQpS17z6bbHxqso0iZFUMAuTWbOJiMzHq6Jms2xhE2ImhR96PsrZ 5VT9Pf1bUawV1jKJ7rFTTqFAg5ZaU3nzQ2Y3SAw7y6RFVvULTyudYtLdLUAdky/k2jJS Y1Dyz9C+bquHU8dZqIxdQAyxMHue7stHa1h0+zVAPIn1X7rnh7vo8sdXITBpf1m2CrF9 MTJQ== X-Gm-Message-State: AOAM531M0zw8v38mqY7K/Ttha95djNWRzuGgZABeW0SyBtytIJjpdoi7 PqR5et+JAEI90pz31Z+WksNNdA== X-Google-Smtp-Source: ABdhPJxw3Cv2mCf5NBEDJPNiP7e1tx/wj45SOuv55MJID8vu6pXCZY7IXdHyeknTPg8OEVnf9b95Pg== X-Received: by 2002:a4a:764e:: with SMTP id w14mr1208367ooe.56.1606272647591; Tue, 24 Nov 2020 18:50:47 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id l7sm522243oth.73.2020.11.24.18.50.45 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 24 Nov 2020 18:50:46 -0800 (PST) Date: Tue, 24 Nov 2020 18:50:32 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Matthew Wilcox cc: Hugh Dickins , Andrew Morton , Jan Kara , William Kucharski , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP In-Reply-To: <20201125023234.GH4327@casper.infradead.org> Message-ID: References: <20201112212641.27837-1-willy@infradead.org> <20201117153947.GL29991@casper.infradead.org> <20201117191513.GV29991@casper.infradead.org> <20201117234302.GC29991@casper.infradead.org> <20201125023234.GH4327@casper.infradead.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 25 Nov 2020, Matthew Wilcox wrote: > On Tue, Nov 17, 2020 at 11:43:02PM +0000, Matthew Wilcox wrote: > > On Tue, Nov 17, 2020 at 07:15:13PM +0000, Matthew Wilcox wrote: > > > I find both of these functions exceptionally confusing. Does this > > > make it easier to understand? > > > > Never mind, this is buggy. I'll send something better tomorrow. > > That took a week, not a day. *sigh*. At least this is shorter. Thanks, I'll give it a try (along with the other 4, on top of the 12: maybe on -rc5, maybe on today's mmotm, I'll decide that later). Shorter you say, that's good: I was disheartened by the way it got more complicated, after your initial truncate_inode_partial_page() neatness. Any hints on what was wrong with my simple fixup to that? (But I didn't spend any more time trying to prove or disprove it.) Hugh