From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B40C56202 for ; Wed, 25 Nov 2020 02:56:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9033B20872 for ; Wed, 25 Nov 2020 02:56:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u3ik/jOX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbgKYC4q (ORCPT ); Tue, 24 Nov 2020 21:56:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbgKYC4q (ORCPT ); Tue, 24 Nov 2020 21:56:46 -0500 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C4BFC0613D4 for ; Tue, 24 Nov 2020 18:56:46 -0800 (PST) Received: by mail-ot1-x341.google.com with SMTP id f16so902004otl.11 for ; Tue, 24 Nov 2020 18:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=+FWpHbem/CPK/Y2WEWVDIbPrtpce00d3aqKaeRn35jw=; b=u3ik/jOXlZPtuxZsymmgfKUaDyjjoSfE2RNE/6etm2mObkDL0KcbpGpsN3W0qUdmtN xxEiEPwiifMvSuQzP0luk3QNSRu99ftZMDeEsmLWWCSKYKWzrKqYM28K9URkcbKsQXEY Z8xkRxhzfSFYmR0JpOar1wKSuCWytUXJX8dTjXkRcHVjvZf8xjGW5PY4d5I5EDfziCTe JbSyEYifGpWuB2Qlux+LoD2IfjNipZpPKE4UuGRd6KVWK8/dP4neO1QXOp1h338gfh3g o0SqbxmUI9NY0sxppH7O/cS8kTG4jbViat5ED8qweuXWlCvuZX0yyG0Tdg6OdW4v5iuD swyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=+FWpHbem/CPK/Y2WEWVDIbPrtpce00d3aqKaeRn35jw=; b=SkYttQ6FS8rhtbhB5ltXyX/86lb3Q/fAcZCtbuWegsuJ3DbenF71ZkH5z7XwYnsL5s 4vq2uWQ3dQyWNHr1WYTpSywxVE28WhC0Eus49GGAZA30t7Rd0a5SaSkUBkb2VZvos0AB uTnmE+mECCFc7SLQ7L8FfTycArpgQLhC0R8kTqSsm2zTj7GnSv/XAwwbTmWH4HnRiJj7 +4HZMzkcWyi6uSo2tBUGkLJFAG6J/3PxxzjiHLdYb7ox3uHsqsTad2upb/yK5uHEuKPT NY8S3N4Fjk6AvAxDtbK1xyEZu0nb5RcR0KRYQdPsgcoYodWwWVGtgP38n9yI5xwCaHSS FUlw== X-Gm-Message-State: AOAM53311I3RzRUpjPI16/hIK7qksfgbkKKSuNdi7J5jspjeajyWAlIt JsV0V7HKWG6MaPN0JYt/MHymXQ== X-Google-Smtp-Source: ABdhPJzxVX94z8ieBTDByVy3UTLQt9z+rZTaAlxMAHgu+ZCnxtIpuauUnDVwsmyVJDy60Q5m8gthsw== X-Received: by 2002:a9d:72dc:: with SMTP id d28mr1362880otk.110.1606273005462; Tue, 24 Nov 2020 18:56:45 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 19sm531313oth.63.2020.11.24.18.56.43 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 24 Nov 2020 18:56:44 -0800 (PST) Date: Tue, 24 Nov 2020 18:56:31 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Matthew Wilcox cc: Hugh Dickins , Andrew Morton , Jan Kara , William Kucharski , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP In-Reply-To: Message-ID: References: <20201112212641.27837-1-willy@infradead.org> <20201117153947.GL29991@casper.infradead.org> <20201117191513.GV29991@casper.infradead.org> <20201117234302.GC29991@casper.infradead.org> <20201125023234.GH4327@casper.infradead.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Nov 2020, Hugh Dickins wrote: > On Wed, 25 Nov 2020, Matthew Wilcox wrote: > > On Tue, Nov 17, 2020 at 11:43:02PM +0000, Matthew Wilcox wrote: > > > On Tue, Nov 17, 2020 at 07:15:13PM +0000, Matthew Wilcox wrote: > > > > I find both of these functions exceptionally confusing. Does this > > > > make it easier to understand? > > > > > > Never mind, this is buggy. I'll send something better tomorrow. > > > > That took a week, not a day. *sigh*. At least this is shorter. > > Thanks, I'll give it a try (along with the other 4, on top of the 12: s/12/16/ > maybe on -rc5, maybe on today's mmotm, I'll decide that later). > > Shorter you say, that's good: I was disheartened by the way it got > more complicated, after your initial truncate_inode_partial_page() > neatness. Any hints on what was wrong with my simple fixup to that? > (But I didn't spend any more time trying to prove or disprove it.) > > Hugh > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF8AFC2D0E4 for ; Wed, 25 Nov 2020 02:56:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 33EE720872 for ; Wed, 25 Nov 2020 02:56:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u3ik/jOX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33EE720872 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 575C06B006E; Tue, 24 Nov 2020 21:56:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5272F6B0070; Tue, 24 Nov 2020 21:56:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4163C6B0071; Tue, 24 Nov 2020 21:56:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 298476B006E for ; Tue, 24 Nov 2020 21:56:47 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DFF3F362C for ; Wed, 25 Nov 2020 02:56:46 +0000 (UTC) X-FDA: 77521428012.18.flesh89_4f0cf0b27373 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id C78DC100ED3D0 for ; Wed, 25 Nov 2020 02:56:46 +0000 (UTC) X-HE-Tag: flesh89_4f0cf0b27373 X-Filterd-Recvd-Size: 4516 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 02:56:46 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id h19so958623otr.1 for ; Tue, 24 Nov 2020 18:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=+FWpHbem/CPK/Y2WEWVDIbPrtpce00d3aqKaeRn35jw=; b=u3ik/jOXlZPtuxZsymmgfKUaDyjjoSfE2RNE/6etm2mObkDL0KcbpGpsN3W0qUdmtN xxEiEPwiifMvSuQzP0luk3QNSRu99ftZMDeEsmLWWCSKYKWzrKqYM28K9URkcbKsQXEY Z8xkRxhzfSFYmR0JpOar1wKSuCWytUXJX8dTjXkRcHVjvZf8xjGW5PY4d5I5EDfziCTe JbSyEYifGpWuB2Qlux+LoD2IfjNipZpPKE4UuGRd6KVWK8/dP4neO1QXOp1h338gfh3g o0SqbxmUI9NY0sxppH7O/cS8kTG4jbViat5ED8qweuXWlCvuZX0yyG0Tdg6OdW4v5iuD swyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=+FWpHbem/CPK/Y2WEWVDIbPrtpce00d3aqKaeRn35jw=; b=IGThe+vN8pBjOXzfIJafV3Z3rzs5Ho2luir//uD3wWyGEICYDn16UlqkpS8g1W1TEl Dbdb7vcs/uerawufAvnmR9bq274cIL1XkxZ4hSGlR65FQCUta99Rg2Q7/ENFByz/k5k4 sFD40/OYwjf46k+TtxT37af4UG8MVLuVxczG7/0fZpUY10GLgQV4mJVV7khk+GhVox8B E17Lyr8RVnk/GBbCn/D+MeuQ2BT0lRhpw2B3zZnCpu4QOHRXud2lcZ4d2LbbmdDrQRP3 tkYkCq+eWuS1P/rBCn2GWhSqOnwVllUaw3SH2CmigX6dnvYSldxA12xbj3jYkvWmlTu+ kbgw== X-Gm-Message-State: AOAM533WJ5uMSqAioWLVboxdpczbfwP0wR/Ig1uyDWkHOOlgLYLU/Dzc 5JiOp1lA7FzfunAWKNCQv2TSrA== X-Google-Smtp-Source: ABdhPJzxVX94z8ieBTDByVy3UTLQt9z+rZTaAlxMAHgu+ZCnxtIpuauUnDVwsmyVJDy60Q5m8gthsw== X-Received: by 2002:a9d:72dc:: with SMTP id d28mr1362880otk.110.1606273005462; Tue, 24 Nov 2020 18:56:45 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 19sm531313oth.63.2020.11.24.18.56.43 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 24 Nov 2020 18:56:44 -0800 (PST) Date: Tue, 24 Nov 2020 18:56:31 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Matthew Wilcox cc: Hugh Dickins , Andrew Morton , Jan Kara , William Kucharski , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP In-Reply-To: Message-ID: References: <20201112212641.27837-1-willy@infradead.org> <20201117153947.GL29991@casper.infradead.org> <20201117191513.GV29991@casper.infradead.org> <20201117234302.GC29991@casper.infradead.org> <20201125023234.GH4327@casper.infradead.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 24 Nov 2020, Hugh Dickins wrote: > On Wed, 25 Nov 2020, Matthew Wilcox wrote: > > On Tue, Nov 17, 2020 at 11:43:02PM +0000, Matthew Wilcox wrote: > > > On Tue, Nov 17, 2020 at 07:15:13PM +0000, Matthew Wilcox wrote: > > > > I find both of these functions exceptionally confusing. Does this > > > > make it easier to understand? > > > > > > Never mind, this is buggy. I'll send something better tomorrow. > > > > That took a week, not a day. *sigh*. At least this is shorter. > > Thanks, I'll give it a try (along with the other 4, on top of the 12: s/12/16/ > maybe on -rc5, maybe on today's mmotm, I'll decide that later). > > Shorter you say, that's good: I was disheartened by the way it got > more complicated, after your initial truncate_inode_partial_page() > neatness. Any hints on what was wrong with my simple fixup to that? > (But I didn't spend any more time trying to prove or disprove it.) > > Hugh >