From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6573BC43381 for ; Mon, 11 Jan 2021 17:21:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35D4022B30 for ; Mon, 11 Jan 2021 17:21:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389428AbhAKRVm (ORCPT ); Mon, 11 Jan 2021 12:21:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389122AbhAKRVl (ORCPT ); Mon, 11 Jan 2021 12:21:41 -0500 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B2C9C061795 for ; Mon, 11 Jan 2021 09:20:55 -0800 (PST) Received: by mail-oi1-x22c.google.com with SMTP id l207so97628oib.4 for ; Mon, 11 Jan 2021 09:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=fdV0VW8YWN7jAg9JebTxlrGwTE2iDZU0jMTnkLks5R8=; b=JptZiE/BzILMv2edPkEWpTCiZDWqqUiaoiUj6VwDJX4FtOt7SHW4BaUrdj1iadpmmH oH7UncA1jzlSQ0DNhUKBhCw2dBAE4yLK13IClTXDIsEBBQ61eAigKNvE8eR5HxFLSEt5 B6L2gAn3ARU3Mi1FbOC2dNgmASqtMIf7zMHah52QueN5wWrp1B2xQxTNERaMPAEZMnl0 qMDOaYb93yqpSItXumjhux39nifB94ZY3XjEo5OUdlWGHgFQD/v6Hq0MSTw46A130FjZ SAKU4I6jHaBNbCmR5NzsPtYvuaoEp/3e+hH2M/35D8hrDf/WQVUaiABMK12yCj0NNeJr AQ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=fdV0VW8YWN7jAg9JebTxlrGwTE2iDZU0jMTnkLks5R8=; b=bg+Db4niSjF26/kQD+2OR7f9jKtnlTQxHKiTJgwkQomWEc1Q18nsdT7cE3XaFp3lAZ jwZ4FDlslZ6mB9I+tSwXp4uCzObDWoyi/0WVw8S0eB6eNLgyVlPUSrpVmzVaowvOwkBf SK8F3WTpmjbH6/4DVcJ+haj8lQWy/ILYQFxOLFynzn73vs8hgJrsCLBeSfewn2kfsWb7 FtW5R6EIg+dvGdOO8KnD6s8udyeVvgdX9zy9DyHlOiLrH/EY5tVrQIhxqaHhukSFUmHZ CsYGCXiczAC+a3AfEN0sTqRee7Rxg+/CYnjHHvhUTisXDdoKXGIWzgWB6z6bKNFJbqSF MIRQ== X-Gm-Message-State: AOAM530SVdegAmm2pPljwjlq2AUO4aE+hrOTbdZsBiRi0YYdXMn1/fRM 8+r0bkaRIrOgO7TAv/5kU5tNjg== X-Google-Smtp-Source: ABdhPJyYjPqVhMs1IGXL3i/+aSzZl7jL8FLkb4dcnzw/G7iPRUa7mUsCtdiFrZJkxyaSW0Rso7PrIQ== X-Received: by 2002:a05:6808:2cb:: with SMTP id a11mr255356oid.93.1610385654570; Mon, 11 Jan 2021 09:20:54 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id n13sm72203otk.58.2021.01.11.09.20.53 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 11 Jan 2021 09:20:54 -0800 (PST) Date: Mon, 11 Jan 2021 09:20:37 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: "Rafael J. Wysocki" cc: Hugh Dickins , Thierry Reding , Jonathan Hunter , Saravana Kannan , Greg Kroah-Hartman , Linux Kernel Mailing List , Linux PM Subject: Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Jan 2021, Rafael J. Wysocki wrote: > On Mon, Jan 11, 2021 at 5:44 AM Hugh Dickins wrote: > > > > Hi Rafael, > > > > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation) > > fails to suspend when running 5.11-rc kernels: bisected to > > 5b6164d3465f ("driver core: Reorder devices on successful probe"), > > and reverting that fixes it. dmesg.xz attached, but go ahead and ask > > me to switch on a debug option to extract further info if that may help. > > Does the driver abort the suspend transition by returning an error or > does something else happen? Both. Thierry has pointed to the lines showing failed suspend transition; and I forgot to mention that the touchpad is unresponsive from then on (I might not have noticed the failed suspend without that). But I don't suppose that unresponsiveness is worth worrying about: things went wrong in suspend, so it's not surprising if the driver does not recover well. Thank you both for getting on to this so quickly - but don't worry about getting my touchpad working: I'm glad to see you discussing the wider issues of ordering that this has brought up. Hugh