From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E59C433E0 for ; Thu, 25 Feb 2021 23:11:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1125F64EDB for ; Thu, 25 Feb 2021 23:11:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231847AbhBYXLH (ORCPT ); Thu, 25 Feb 2021 18:11:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbhBYXLF (ORCPT ); Thu, 25 Feb 2021 18:11:05 -0500 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4764C061574 for ; Thu, 25 Feb 2021 15:10:24 -0800 (PST) Received: by mail-oi1-x22c.google.com with SMTP id o3so7842159oic.8 for ; Thu, 25 Feb 2021 15:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:user-agent:mime-version; bh=UoFZ3P+KXBpGD+fINLtjQ4hHuKvSMz6V0Loo7Q31eYE=; b=Ag5Y0cWXGQ0NQ2EVRB9JQ2g/cpIuo+DrXimIs7k+Ob3SvIX+Lp1cXH/iwuwJJwDHIx Trwx0ZusHbbCCzH/3HKeNUYIAe9G5DJABGLdo3iqzsG7dYiwdSbZZ1hlL6mX92bTJDMB X/w2z+jB6/D2fOTfAe2a0a+xuuT/3UCIGGCxWvT7EZazFvbQq7Q7T88LvADqFPGzRSak KiIG64Kqir31MK2Ky10fKDchAY9MMWMj2Wd0MvtiCJSaIwKWVbDRoQfb1Yg2IXg1Heyj SgGO1nsDVVAiT2eRVD2vnhRVlazztfqW0P/T17/o37VD5IqCdzUgzaBoLQ+C+KPxZm4A 4FnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :mime-version; bh=UoFZ3P+KXBpGD+fINLtjQ4hHuKvSMz6V0Loo7Q31eYE=; b=tZNGC8jNdrbZWGpc+pRDy6wd9sAra8tqdDUSZrmKC5OrDWLKGIampl/rGBYM/c/dTk sExowsdKrzvfkBA6eb5/WVN05BmNQ2RsE3rjUXP0k7frazzlWQcVtLX/I0/srpoBhu7s G+9cemx6WdwalyVZWkhUzQNvmkHhAIpmUSbgO0PNWr4hg/otWBA2BoSrB4r4wx+7OjGh VjHT/lwc5u9o0/sbcoPnxYh+5VJ3ktFmJAXc4iZBPgB/I6/P87oKq3Gvi+288AbTHchH gY6ASD9PknFvFOYK4f6O1+eGZi7gT/YZxaB8+OwzVLA0h1yqTU6MEr/e53QgpgHeI2aV WRgQ== X-Gm-Message-State: AOAM530OJ53l09nAO1Psia+rfE+S3V+eJbBQSFfsn4rbsStXoj6doy77 em1gq65nXzbARbpGRWaJUARvOA== X-Google-Smtp-Source: ABdhPJxC6tBTkBwA9flUNg/EUWPw8ia4+6NNqrERZrqLrN+xw2R0fuvAHWmvXokE9sqC0d1fHewvpA== X-Received: by 2002:aca:5f83:: with SMTP id t125mr113321oib.114.1614294623998; Thu, 25 Feb 2021 15:10:23 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 109sm1379612otj.8.2021.02.25.15.10.22 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Thu, 25 Feb 2021 15:10:23 -0800 (PST) Date: Thu, 25 Feb 2021 15:10:09 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] mm: restore node stat checking in /proc/sys/vm/stat_refresh Message-ID: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org v4.7 52b6f46bc163 ("mm: /proc/sys/vm/stat_refresh to force vmstat update") introduced vmstat_refresh(), with its vmstat underflow checking; then v4.8 75ef71840539 ("mm, vmstat: add infrastructure for per-node vmstats") split NR_VM_NODE_STAT_ITEMS out of NR_VM_ZONE_STAT_ITEMS without updating vmstat_refresh(): so it has been missing out much of the vmstat underflow checking ever since. Reinstate it. Thanks to Roman Gushchin for tangentially pointing this out. Signed-off-by: Hugh Dickins --- mm/vmstat.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- 5.12-rc/mm/vmstat.c 2021-02-24 12:03:55.000000000 -0800 +++ vmstat1/mm/vmstat.c 2021-02-25 11:50:36.000000000 -0800 @@ -1857,6 +1857,14 @@ int vmstat_refresh(struct ctl_table *tab } } #endif + for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++) { + val = atomic_long_read(&vm_node_stat[i]); + if (val < 0) { + pr_warn("%s: %s %ld\n", + __func__, node_stat_name(i), val); + err = -EINVAL; + } + } if (err) return err; if (write) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF974C433E0 for ; Thu, 25 Feb 2021 23:10:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 66E5864F26 for ; Thu, 25 Feb 2021 23:10:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66E5864F26 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C54086B0005; Thu, 25 Feb 2021 18:10:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BDC886B0006; Thu, 25 Feb 2021 18:10:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7DEC6B006C; Thu, 25 Feb 2021 18:10:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 939696B0005 for ; Thu, 25 Feb 2021 18:10:25 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 655D5184582B5 for ; Thu, 25 Feb 2021 23:10:25 +0000 (UTC) X-FDA: 77858336010.01.694781F Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by imf03.hostedemail.com (Postfix) with ESMTP id CD43CC0007E3 for ; Thu, 25 Feb 2021 23:10:21 +0000 (UTC) Received: by mail-oi1-f182.google.com with SMTP id d20so7835774oiw.10 for ; Thu, 25 Feb 2021 15:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:user-agent:mime-version; bh=UoFZ3P+KXBpGD+fINLtjQ4hHuKvSMz6V0Loo7Q31eYE=; b=Ag5Y0cWXGQ0NQ2EVRB9JQ2g/cpIuo+DrXimIs7k+Ob3SvIX+Lp1cXH/iwuwJJwDHIx Trwx0ZusHbbCCzH/3HKeNUYIAe9G5DJABGLdo3iqzsG7dYiwdSbZZ1hlL6mX92bTJDMB X/w2z+jB6/D2fOTfAe2a0a+xuuT/3UCIGGCxWvT7EZazFvbQq7Q7T88LvADqFPGzRSak KiIG64Kqir31MK2Ky10fKDchAY9MMWMj2Wd0MvtiCJSaIwKWVbDRoQfb1Yg2IXg1Heyj SgGO1nsDVVAiT2eRVD2vnhRVlazztfqW0P/T17/o37VD5IqCdzUgzaBoLQ+C+KPxZm4A 4FnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :mime-version; bh=UoFZ3P+KXBpGD+fINLtjQ4hHuKvSMz6V0Loo7Q31eYE=; b=B11xiSIlHP0/NPIURdDQXoA9AjiC9/1BUzPHWFB68ZsftI08gmEU5FCpjMVTr1o/CJ Bzrhdn2v20VdBlFFfWzSrm6ZnsucwgRbmn/phuA44HY/VqzlGr1jxzLsKJxYe9NZ1rq5 zqhwuNJ4+ZHxoEv+yZeNLSKMmymBUzxbmG2m+fuTkLxX95EM1fa/8NHObsHZOdjGXeHd UpbE+qZMCPms38uu7k8RoJaufD7g1NX7skI0jT9cs/CmBJPbAb+l1MAxirdR0he81sCG Fd7u7yEwSwc67l0ActrwyG0MnmD44NSQcyxLw6aw7VC/6fSDW94DDhbuie95xa4Y4tvt KPqQ== X-Gm-Message-State: AOAM532DcsB+1tsV1vnElnzc5XwHo40DE43ZMT6kvv7h4AHAYKozi8ts 0TZVY+R/OlHo4olwqzMXPBR8zw== X-Google-Smtp-Source: ABdhPJxC6tBTkBwA9flUNg/EUWPw8ia4+6NNqrERZrqLrN+xw2R0fuvAHWmvXokE9sqC0d1fHewvpA== X-Received: by 2002:aca:5f83:: with SMTP id t125mr113321oib.114.1614294623998; Thu, 25 Feb 2021 15:10:23 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 109sm1379612otj.8.2021.02.25.15.10.22 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Thu, 25 Feb 2021 15:10:23 -0800 (PST) Date: Thu, 25 Feb 2021 15:10:09 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] mm: restore node stat checking in /proc/sys/vm/stat_refresh Message-ID: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CD43CC0007E3 X-Stat-Signature: etrjb3rt3yci3bk3bk5wcmmjznxp5fq5 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mail-oi1-f182.google.com; client-ip=209.85.167.182 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614294621-420609 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: v4.7 52b6f46bc163 ("mm: /proc/sys/vm/stat_refresh to force vmstat update") introduced vmstat_refresh(), with its vmstat underflow checking; then v4.8 75ef71840539 ("mm, vmstat: add infrastructure for per-node vmstats") split NR_VM_NODE_STAT_ITEMS out of NR_VM_ZONE_STAT_ITEMS without updating vmstat_refresh(): so it has been missing out much of the vmstat underflow checking ever since. Reinstate it. Thanks to Roman Gushchin for tangentially pointing this out. Signed-off-by: Hugh Dickins --- mm/vmstat.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- 5.12-rc/mm/vmstat.c 2021-02-24 12:03:55.000000000 -0800 +++ vmstat1/mm/vmstat.c 2021-02-25 11:50:36.000000000 -0800 @@ -1857,6 +1857,14 @@ int vmstat_refresh(struct ctl_table *tab } } #endif + for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++) { + val = atomic_long_read(&vm_node_stat[i]); + if (val < 0) { + pr_warn("%s: %s %ld\n", + __func__, node_stat_name(i), val); + err = -EINVAL; + } + } if (err) return err; if (write)