From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B2C1C433DB for ; Thu, 25 Feb 2021 23:13:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6B0264EBA for ; Thu, 25 Feb 2021 23:13:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231978AbhBYXM6 (ORCPT ); Thu, 25 Feb 2021 18:12:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230040AbhBYXMx (ORCPT ); Thu, 25 Feb 2021 18:12:53 -0500 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96DEBC061574 for ; Thu, 25 Feb 2021 15:12:13 -0800 (PST) Received: by mail-ot1-x334.google.com with SMTP id f33so7375302otf.11 for ; Thu, 25 Feb 2021 15:12:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ZTnYHREJjaxknDfDoBhteeW5RbBqwnc0KAb8pOQepb4=; b=DZjrfGHZzY4vsUofUZQCjn59YAhiXPKAnJ0rls9m6Kt0kXHk2mBMCkFhXhrp+jbrxL Qwcjk51wJbhUOwPAqgrQ5RS8FW/Dcfa/sa+GGoq0nefrWiPSZRxcJPcN8M3DWrDTmuPQ laQpOGEIbbN0w4e/VITz2sWDKuZDnUGfdcKPS7NdlwWjkewZ6DPa7vpI7aYpQXX3qvWH bmljy+vS2gqnuJCBqydx8G5kbTCcDm7ZNwkImHgau1f+OPeCa77FI1zifAhaNF1QjYdG j6II8PQWIc32iQ6keYblKkFjoZuT0tAx0f77knppoZjysx3235SUF6G7vRGJKLVZMHVn 5AVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ZTnYHREJjaxknDfDoBhteeW5RbBqwnc0KAb8pOQepb4=; b=L4bKDuwvdaz86B/F9PU21PwxnXdifxflUqjdquTzBg2E6eZuc21+dC0yRqhFuE/9Er /mLqAWetM9zkmGoop3hxrvRk/hLKCJsyM6HeqwXj5HfLt287x2m6gvNzrzNtPqZ4i4Ut SowGBn1r8tFG9KnbvGglFjz9QmeE1xTTmPUUaw5Wz4iSSV33HtzK00q12zxBWi51vgLl qk7R3+Ap28u0rj5mqYfDG3bvDsvn9/WKW6k2NwpzWZa8WSYeVQet+dm62E15xQmGd5bl so3lKoOjmnSRmt/vKKqpN8bs81wMjJvwB12VCe7z8Ecok4tB5KWv3To0YhzImw/2JS/S nGjg== X-Gm-Message-State: AOAM530n3J2g7+4Sp452dMNmAceR9mj4cFLdkEc0WCkPKPNNJ3m4GMwZ y4jRLQGTBM9sSO+Nv6GXVR+/zQ== X-Google-Smtp-Source: ABdhPJxOSAWbEdHaaF6Y/UpZk58fZCxjSTbQvu6j6JDDhIg9nIjzNuKFCZKlX4QL/DexIVYGr+N1Ug== X-Received: by 2002:a9d:3bc4:: with SMTP id k62mr55700otc.318.1614294732828; Thu, 25 Feb 2021 15:12:12 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id w30sm1327730oow.48.2021.02.25.15.12.11 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Thu, 25 Feb 2021 15:12:12 -0800 (PST) Date: Thu, 25 Feb 2021 15:12:10 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] mm: no more EINVAL from /proc/sys/vm/stat_refresh In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org EINVAL was good for drawing the refresher's attention to a warning in dmesg, but became very tiresome when running test suites scripted with "set -e": an underflow from a bug in one feature would cause unrelated tests much later to fail, just because their /proc/sys/vm/stat_refresh touch failed with that error. Stop doing that. Signed-off-by: Hugh Dickins --- mm/vmstat.c | 5 ----- 1 file changed, 5 deletions(-) --- vmstat1/mm/vmstat.c 2021-02-25 11:50:36.000000000 -0800 +++ vmstat2/mm/vmstat.c 2021-02-25 11:56:18.000000000 -0800 @@ -1844,7 +1844,6 @@ int vmstat_refresh(struct ctl_table *tab if (val < 0) { pr_warn("%s: %s %ld\n", __func__, zone_stat_name(i), val); - err = -EINVAL; } } #ifdef CONFIG_NUMA @@ -1853,7 +1852,6 @@ int vmstat_refresh(struct ctl_table *tab if (val < 0) { pr_warn("%s: %s %ld\n", __func__, numa_stat_name(i), val); - err = -EINVAL; } } #endif @@ -1862,11 +1860,8 @@ int vmstat_refresh(struct ctl_table *tab if (val < 0) { pr_warn("%s: %s %ld\n", __func__, node_stat_name(i), val); - err = -EINVAL; } } - if (err) - return err; if (write) *ppos += *lenp; else From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3E62C433E0 for ; Thu, 25 Feb 2021 23:12:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 145E764F28 for ; Thu, 25 Feb 2021 23:12:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 145E764F28 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8080A6B0005; Thu, 25 Feb 2021 18:12:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B8916B0006; Thu, 25 Feb 2021 18:12:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A86F6B006C; Thu, 25 Feb 2021 18:12:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 54EB86B0005 for ; Thu, 25 Feb 2021 18:12:14 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 196DA824556B for ; Thu, 25 Feb 2021 23:12:14 +0000 (UTC) X-FDA: 77858340588.25.E2EB94C Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by imf24.hostedemail.com (Postfix) with ESMTP id D6BDDA00060D for ; Thu, 25 Feb 2021 23:12:07 +0000 (UTC) Received: by mail-ot1-f47.google.com with SMTP id b8so7392309oti.7 for ; Thu, 25 Feb 2021 15:12:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ZTnYHREJjaxknDfDoBhteeW5RbBqwnc0KAb8pOQepb4=; b=DZjrfGHZzY4vsUofUZQCjn59YAhiXPKAnJ0rls9m6Kt0kXHk2mBMCkFhXhrp+jbrxL Qwcjk51wJbhUOwPAqgrQ5RS8FW/Dcfa/sa+GGoq0nefrWiPSZRxcJPcN8M3DWrDTmuPQ laQpOGEIbbN0w4e/VITz2sWDKuZDnUGfdcKPS7NdlwWjkewZ6DPa7vpI7aYpQXX3qvWH bmljy+vS2gqnuJCBqydx8G5kbTCcDm7ZNwkImHgau1f+OPeCa77FI1zifAhaNF1QjYdG j6II8PQWIc32iQ6keYblKkFjoZuT0tAx0f77knppoZjysx3235SUF6G7vRGJKLVZMHVn 5AVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ZTnYHREJjaxknDfDoBhteeW5RbBqwnc0KAb8pOQepb4=; b=XJeXByt9Js+ZuzZrio/xOg87AhQ9qdwB+R/ifmFCu1i2Hkbryx5sEgzRIcBMNkfKVx rQWjgTaPzQOFmnhMSI1sBXf/M0GxgpnMkpJwcXdBwcnJm4EBaobkVrOmjn182co0CuUB gKs5K0A9OcHfE8gAm1J9i6B6+50KWlnfLqSIRaT1RRhlNbG7KqRRfoGJcoAUJXa/nwEo C4ndxbCqsXo7grWmDMTvfLgd72SY/lOI0pfu7yXdcsNX2/Guvk7Pi3pgnXwXkQKxXFvC 0iBPj9UMW2pMSy48OHco7xI9k9Q9n6JkiyYeGpAskW9RNZNqcWjm9amzwtGeZLV8+qkp er3A== X-Gm-Message-State: AOAM530IHW+wMnI0R5baXwqAD+wFX34cd7UE443dDFlPyALoNwZY3uIX hE8diAHbV/KxovQV3AGPTJzpyA== X-Google-Smtp-Source: ABdhPJxOSAWbEdHaaF6Y/UpZk58fZCxjSTbQvu6j6JDDhIg9nIjzNuKFCZKlX4QL/DexIVYGr+N1Ug== X-Received: by 2002:a9d:3bc4:: with SMTP id k62mr55700otc.318.1614294732828; Thu, 25 Feb 2021 15:12:12 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id w30sm1327730oow.48.2021.02.25.15.12.11 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Thu, 25 Feb 2021 15:12:12 -0800 (PST) Date: Thu, 25 Feb 2021 15:12:10 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] mm: no more EINVAL from /proc/sys/vm/stat_refresh In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Stat-Signature: 8u8ke5f78ej896k4pezsbw5oukhnifdb X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D6BDDA00060D Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-ot1-f47.google.com; client-ip=209.85.210.47 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614294727-255295 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: EINVAL was good for drawing the refresher's attention to a warning in dmesg, but became very tiresome when running test suites scripted with "set -e": an underflow from a bug in one feature would cause unrelated tests much later to fail, just because their /proc/sys/vm/stat_refresh touch failed with that error. Stop doing that. Signed-off-by: Hugh Dickins --- mm/vmstat.c | 5 ----- 1 file changed, 5 deletions(-) --- vmstat1/mm/vmstat.c 2021-02-25 11:50:36.000000000 -0800 +++ vmstat2/mm/vmstat.c 2021-02-25 11:56:18.000000000 -0800 @@ -1844,7 +1844,6 @@ int vmstat_refresh(struct ctl_table *tab if (val < 0) { pr_warn("%s: %s %ld\n", __func__, zone_stat_name(i), val); - err = -EINVAL; } } #ifdef CONFIG_NUMA @@ -1853,7 +1852,6 @@ int vmstat_refresh(struct ctl_table *tab if (val < 0) { pr_warn("%s: %s %ld\n", __func__, numa_stat_name(i), val); - err = -EINVAL; } } #endif @@ -1862,11 +1860,8 @@ int vmstat_refresh(struct ctl_table *tab if (val < 0) { pr_warn("%s: %s %ld\n", __func__, node_stat_name(i), val); - err = -EINVAL; } } - if (err) - return err; if (write) *ppos += *lenp; else