From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9375FC433DB for ; Thu, 25 Feb 2021 23:16:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4566464F28 for ; Thu, 25 Feb 2021 23:16:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231629AbhBYXQc (ORCPT ); Thu, 25 Feb 2021 18:16:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229966AbhBYXQZ (ORCPT ); Thu, 25 Feb 2021 18:16:25 -0500 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8746C061574 for ; Thu, 25 Feb 2021 15:15:45 -0800 (PST) Received: by mail-ot1-x335.google.com with SMTP id b16so7457782otq.1 for ; Thu, 25 Feb 2021 15:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=Smj9hGl2RbGm2CySkaquhF9hKXGORoT8wFtF23aPw80=; b=PQGapdtWdHUGvCi4b/U/fKSxKfUa3+e/PkCB9xyTGoprNmMWOt+EFulQdTJXOhC2kE tnXT5OjUevpUtXJ61zrNNs57toOIMqekxK2ymiIX1dQZl2xewyyxY0tsbA3lwcbkxVJs 0T0hPe+/vHoLnwpD4Ogji36u0TEX3qc7+W1CW4M9vqusdlz/AYjR1Hs15qvHJRwi2o5c OsOsV1s7uC+H2ribn2aMqGB/liPnNCoYChsODRXycMZAUuFrkgdmOkARiMEKQAkSJhnE D9bpWDcMqJFMY7P19IGXgjEwk6pfAoLWFZ++i/VYxfaG/3wfG3HivaMo6D+JNsPngvuK cRCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=Smj9hGl2RbGm2CySkaquhF9hKXGORoT8wFtF23aPw80=; b=nOfaJmmy/NOc1hruW1dAX63tykn6miSgOJZw7L5Cryp6F1mH/WTPOUnldCVaZUVtnc B9tzGGMB74zMVlP2Iu/LnJOTm9yALrdZwvUzUFz3IoUHaG1EdXyHu1y3/4LAju0aZtQj eCpGJ6gMyUyrc7urc6ZJ9TXcm+w/IbUn5hFbeI5eUejpbjTrY18F5lneK/CGQTSw7OiZ tp//gMjYlMzPVidSAhnsTHMUwKubrlVrzE1+0wYux+UDmq560yrp3yWAHtZ+x8VtNTys qCRnG3R+feS5Zw7eqxUk3W6cIk6RpAncpuCU+OnVjtuschz+wnEW9cplHQVKcj43O0jx hjgw== X-Gm-Message-State: AOAM5316Tj3qIh1uuV96i9UBHoKysqpQ2XVEvmbmiy3mdqVxaZ+HDqEF VX8JA+Fd7QZb5UuFH0rl2Lyt2w== X-Google-Smtp-Source: ABdhPJwbH5jvPK2gCLC3PeoMa4S06XMPNqRsA3R2ADfVT5/7tiGM4VGjxoFR2Y5LuJe996G+Qavpjw== X-Received: by 2002:a9d:1429:: with SMTP id h38mr59302oth.135.1614294944875; Thu, 25 Feb 2021 15:15:44 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id j100sm1404302otj.66.2021.02.25.15.15.43 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Thu, 25 Feb 2021 15:15:44 -0800 (PST) Date: Thu, 25 Feb 2021 15:15:42 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] mm: /proc//sys/vm/stat_refresh stop checking monotonic numa stats In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All of the VM NUMA stats are event counts, incremented never decremented: it is not very useful for vmstat_refresh() to check them throughout their first aeon, then warn on them throughout their next. Signed-off-by: Hugh Dickins --- mm/vmstat.c | 9 --------- 1 file changed, 9 deletions(-) --- vmstat3/mm/vmstat.c 2021-02-25 12:42:15.000000000 -0800 +++ vmstat4/mm/vmstat.c 2021-02-25 12:44:20.000000000 -0800 @@ -1854,15 +1854,6 @@ int vmstat_refresh(struct ctl_table *tab __func__, zone_stat_name(i), val); } } -#ifdef CONFIG_NUMA - for (i = 0; i < NR_VM_NUMA_STAT_ITEMS; i++) { - val = atomic_long_read(&vm_numa_stat[i]); - if (val < 0) { - pr_warn("%s: %s %ld\n", - __func__, numa_stat_name(i), val); - } - } -#endif for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++) { /* * Skip checking stats known to go negative occasionally. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E1BDC433DB for ; Thu, 25 Feb 2021 23:15:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 241F964F29 for ; Thu, 25 Feb 2021 23:15:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 241F964F29 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 937A46B0005; Thu, 25 Feb 2021 18:15:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E8E96B0006; Thu, 25 Feb 2021 18:15:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FE496B006C; Thu, 25 Feb 2021 18:15:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 682E86B0005 for ; Thu, 25 Feb 2021 18:15:46 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 36E52824556B for ; Thu, 25 Feb 2021 23:15:46 +0000 (UTC) X-FDA: 77858349492.22.1479C68 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf22.hostedemail.com (Postfix) with ESMTP id 47B73C0007D0 for ; Thu, 25 Feb 2021 23:15:42 +0000 (UTC) Received: by mail-ot1-f42.google.com with SMTP id 105so7428730otd.3 for ; Thu, 25 Feb 2021 15:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=Smj9hGl2RbGm2CySkaquhF9hKXGORoT8wFtF23aPw80=; b=PQGapdtWdHUGvCi4b/U/fKSxKfUa3+e/PkCB9xyTGoprNmMWOt+EFulQdTJXOhC2kE tnXT5OjUevpUtXJ61zrNNs57toOIMqekxK2ymiIX1dQZl2xewyyxY0tsbA3lwcbkxVJs 0T0hPe+/vHoLnwpD4Ogji36u0TEX3qc7+W1CW4M9vqusdlz/AYjR1Hs15qvHJRwi2o5c OsOsV1s7uC+H2ribn2aMqGB/liPnNCoYChsODRXycMZAUuFrkgdmOkARiMEKQAkSJhnE D9bpWDcMqJFMY7P19IGXgjEwk6pfAoLWFZ++i/VYxfaG/3wfG3HivaMo6D+JNsPngvuK cRCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=Smj9hGl2RbGm2CySkaquhF9hKXGORoT8wFtF23aPw80=; b=DvWhCf9+3FqFI7iQicbl9LZHAAQR6OKwI4RC29ATxFMftleBLwXrEKMe+1oBzB0NLd pj1t/Cet8rOJ2sstk+f/ezUbBw78WeF5nPBwqPdy7LqAvmiEUO+Yl9/x0B0fGF4FWuse +XwZnzO+0NgCF4qXKW7jX74B314B9KlHgPY7DyrvDyFro7Am5DYU2XGORxexDNuphCjL /amv/oyHNG3dNDFfpfeWNZmg88Ikd5ouYp4rvfOFNWibTJ9bYt+/xOUisy3eMDwhvxio ptaguO2z6NQvpWZ2/ZkSGaMhUgqClfYAqRUapSSEqrCBthRvRGdnjFAla2GRSbX/jUuk XPmQ== X-Gm-Message-State: AOAM5306ZZTWq9AAMSAb3cX56Gpo6EzhtagxCFH1g2C6glcZVXkMIkgY +A4l5hICmTdJdvgBn2OECVvR/Q== X-Google-Smtp-Source: ABdhPJwbH5jvPK2gCLC3PeoMa4S06XMPNqRsA3R2ADfVT5/7tiGM4VGjxoFR2Y5LuJe996G+Qavpjw== X-Received: by 2002:a9d:1429:: with SMTP id h38mr59302oth.135.1614294944875; Thu, 25 Feb 2021 15:15:44 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id j100sm1404302otj.66.2021.02.25.15.15.43 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Thu, 25 Feb 2021 15:15:44 -0800 (PST) Date: Thu, 25 Feb 2021 15:15:42 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] mm: /proc//sys/vm/stat_refresh stop checking monotonic numa stats In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Stat-Signature: 4k7uazsfki6k7jybtgr36g3awnh8zbrf X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 47B73C0007D0 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail-ot1-f42.google.com; client-ip=209.85.210.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614294942-621454 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All of the VM NUMA stats are event counts, incremented never decremented: it is not very useful for vmstat_refresh() to check them throughout their first aeon, then warn on them throughout their next. Signed-off-by: Hugh Dickins --- mm/vmstat.c | 9 --------- 1 file changed, 9 deletions(-) --- vmstat3/mm/vmstat.c 2021-02-25 12:42:15.000000000 -0800 +++ vmstat4/mm/vmstat.c 2021-02-25 12:44:20.000000000 -0800 @@ -1854,15 +1854,6 @@ int vmstat_refresh(struct ctl_table *tab __func__, zone_stat_name(i), val); } } -#ifdef CONFIG_NUMA - for (i = 0; i < NR_VM_NUMA_STAT_ITEMS; i++) { - val = atomic_long_read(&vm_numa_stat[i]); - if (val < 0) { - pr_warn("%s: %s %ld\n", - __func__, numa_stat_name(i), val); - } - } -#endif for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++) { /* * Skip checking stats known to go negative occasionally.