From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92314C47080 for ; Wed, 2 Jun 2021 02:13:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 758C160200 for ; Wed, 2 Jun 2021 02:13:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbhFBCPf (ORCPT ); Tue, 1 Jun 2021 22:15:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbhFBCPe (ORCPT ); Tue, 1 Jun 2021 22:15:34 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AF82C061574 for ; Tue, 1 Jun 2021 19:13:51 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id lx17-20020a17090b4b11b029015f3b32b8dbso2569054pjb.0 for ; Tue, 01 Jun 2021 19:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=tylmfxViZrbJw4R/4KjitwSP24dh3nFyN6PzzQ79jTg=; b=sgYSZAPMz9IqIjiiB3RP3qGplNq/yr8qhTK+3dLBRmqey2HlR4w4Lg8xuk2bfojtsd X3wQIwNoIwP/KCAfZhITag3gEVK87noKWRM1Ylp2oBpVM/2Ip8Wc55sVBVNddEKHWMez FmCi4dq8FHdmdUfkfSzmr8EUvC8DNAi6dE/l5gJewCf6OqnhKPti5XrjYHPEzqWFhWfO 6HxE8cFn3jmZRxtO9ldbwe7AHYWP9OOierv2TXDAYj+9EBEo/ytAVfnrEzTwCoNbKu3q lDefk63pLoDrNNlg1sHD3r9CL3ZVXWWjubjeKMiFcvAB8HbgRjwOXaexzuEy1FYGo1BU HM+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=tylmfxViZrbJw4R/4KjitwSP24dh3nFyN6PzzQ79jTg=; b=UdLjey/9ampTgjM6BEwWL/3JU1/T3ESxs5bkOa36eo0q1KSZO5HkbndaSwWyxmmBgD Vgf9HuS8pgBsmaBcJGjslX0v2ysoPi/ws3FYQ13MfxLV7PTlQJ6UR7Xz9CBT4pqtWGz2 gsPqN6yn7uhpWur5fuIh542UpaOXEfY/WClYweMQAXSCFeIU5GTivY1TvvV0wDw1DSEH 9oE9OJkdvp/J3MgjtZUppzrOQNBH4MGX94cgsBzltlBQ5vVs2PEK06GWTvp5Bjjm5oS7 HI14WgvokPj7YX8WRr0DfCs7/pmNXfloRfhEA6+BIwgkpQcnLgif9nIfmBRVERZPUevi +lRQ== X-Gm-Message-State: AOAM532EqxMkBoebfKrEf0HGq1WTO+/pixPgIcV3G8QeZkQ8yFPe3dGy 4PO87m3ptPDejTjZAE8UYd8ADw== X-Google-Smtp-Source: ABdhPJwCHDApIipx3AzpCRD+1Hzhc6B29/zuXtHxVBQXRQXFA7F3teqXbRyId+xnD2tHXEXQELOlFQ== X-Received: by 2002:a17:902:7684:b029:f4:b82b:b893 with SMTP id m4-20020a1709027684b02900f4b82bb893mr28203975pll.67.1622600030095; Tue, 01 Jun 2021 19:13:50 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id a15sm14093213pfc.29.2021.06.01.19.13.48 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 01 Jun 2021 19:13:49 -0700 (PDT) Date: Tue, 1 Jun 2021 19:13:24 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Linus Torvalds cc: Ming Lin , Hugh Dickins , Simon Ser , Linux-MM , Linux Kernel Mailing List Subject: Re: [PATCH 2/2] mm: adds NOSIGBUS extension for out-of-band shmem read In-Reply-To: Message-ID: References: <1622589753-9206-1-git-send-email-mlin@kernel.org> <1622589753-9206-3-git-send-email-mlin@kernel.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Jun 2021, Linus Torvalds wrote: > This series passes my "looks fine, is simple and straightforward" test. I'm sorry, but it also passes my "hack that we do not want in shmem.c" test. I'll say more in response to the preceding mail. Hugh > > One nit: > > On Tue, Jun 1, 2021 at 1:22 PM Ming Lin wrote: > > > > + error = vm_insert_page(vma, (unsigned long)vmf->address, > > + ZERO_PAGE(0)); > > On architectures where this matters - bad virtual caches - it would be > better to use ZERO_PAGE(vmf->address). > > It doesn't make a difference on any sane architecture, but it's the > RightThing(tm) to do. > > Linus > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2086C4708F for ; Wed, 2 Jun 2021 02:13:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7670B6139A for ; Wed, 2 Jun 2021 02:13:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7670B6139A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BD1BB6B006C; Tue, 1 Jun 2021 22:13:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B81886B006E; Tue, 1 Jun 2021 22:13:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A233A6B0070; Tue, 1 Jun 2021 22:13:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id 6DF8C6B006C for ; Tue, 1 Jun 2021 22:13:52 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E80D58249980 for ; Wed, 2 Jun 2021 02:13:51 +0000 (UTC) X-FDA: 78207163062.13.7ECE540 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf15.hostedemail.com (Postfix) with ESMTP id 51BD3A000245 for ; Wed, 2 Jun 2021 02:13:44 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id o17-20020a17090a9f91b029015cef5b3c50so2535813pjp.4 for ; Tue, 01 Jun 2021 19:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=tylmfxViZrbJw4R/4KjitwSP24dh3nFyN6PzzQ79jTg=; b=sgYSZAPMz9IqIjiiB3RP3qGplNq/yr8qhTK+3dLBRmqey2HlR4w4Lg8xuk2bfojtsd X3wQIwNoIwP/KCAfZhITag3gEVK87noKWRM1Ylp2oBpVM/2Ip8Wc55sVBVNddEKHWMez FmCi4dq8FHdmdUfkfSzmr8EUvC8DNAi6dE/l5gJewCf6OqnhKPti5XrjYHPEzqWFhWfO 6HxE8cFn3jmZRxtO9ldbwe7AHYWP9OOierv2TXDAYj+9EBEo/ytAVfnrEzTwCoNbKu3q lDefk63pLoDrNNlg1sHD3r9CL3ZVXWWjubjeKMiFcvAB8HbgRjwOXaexzuEy1FYGo1BU HM+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=tylmfxViZrbJw4R/4KjitwSP24dh3nFyN6PzzQ79jTg=; b=kcd+YFSrXXkeEFccv1z60kgIdUQ4f8a54mzmfJtJx+1LUkSSCy7amYtCTikM82A80X tuPzSeurNNdWsmCoIudac9nvHrOg7sVF77B4JMFlMpX4vVEkrsK1lXpuuem2PCsS2BYR /Bu2vwd0f6JWFtpyaoIuChnwVZApTWFyF5i5Ws/JXn97+skHg8GT6Esrf5oZElYnq8d8 j4qQDA7cikq1lTAzjktx3etztQHHIdMZU98RM5tkJDcjO4M6/JBtknCdTnaFMI/C3Bhl C1mNEh4ptUIiWOW+Ekr/4nLT8hbHA/nWNniacHgeUzTg/VWqoCGtLI+96YXniddqbr98 IjWg== X-Gm-Message-State: AOAM532RvE7Cq2yxwmuufV4eXlrPIqUJc7lRvdhz2vx+D5vmPJ9stHzU pruUR2SWcnnpjMqUp2cnTrUEKg== X-Google-Smtp-Source: ABdhPJwCHDApIipx3AzpCRD+1Hzhc6B29/zuXtHxVBQXRQXFA7F3teqXbRyId+xnD2tHXEXQELOlFQ== X-Received: by 2002:a17:902:7684:b029:f4:b82b:b893 with SMTP id m4-20020a1709027684b02900f4b82bb893mr28203975pll.67.1622600030095; Tue, 01 Jun 2021 19:13:50 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id a15sm14093213pfc.29.2021.06.01.19.13.48 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 01 Jun 2021 19:13:49 -0700 (PDT) Date: Tue, 1 Jun 2021 19:13:24 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Linus Torvalds cc: Ming Lin , Hugh Dickins , Simon Ser , Linux-MM , Linux Kernel Mailing List Subject: Re: [PATCH 2/2] mm: adds NOSIGBUS extension for out-of-band shmem read In-Reply-To: Message-ID: References: <1622589753-9206-1-git-send-email-mlin@kernel.org> <1622589753-9206-3-git-send-email-mlin@kernel.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=sgYSZAPM; spf=pass (imf15.hostedemail.com: domain of hughd@google.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 51BD3A000245 X-Stat-Signature: wcrnydjk6n867ji8aoks99uzkb4urph8 X-HE-Tag: 1622600024-51979 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 1 Jun 2021, Linus Torvalds wrote: > This series passes my "looks fine, is simple and straightforward" test. I'm sorry, but it also passes my "hack that we do not want in shmem.c" test. I'll say more in response to the preceding mail. Hugh > > One nit: > > On Tue, Jun 1, 2021 at 1:22 PM Ming Lin wrote: > > > > + error = vm_insert_page(vma, (unsigned long)vmf->address, > > + ZERO_PAGE(0)); > > On architectures where this matters - bad virtual caches - it would be > better to use ZERO_PAGE(vmf->address). > > It doesn't make a difference on any sane architecture, but it's the > RightThing(tm) to do. > > Linus >