From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 503D9C4743D for ; Fri, 4 Jun 2021 22:56:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 262CF610A0 for ; Fri, 4 Jun 2021 22:56:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231634AbhFDW6k (ORCPT ); Fri, 4 Jun 2021 18:58:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbhFDW6h (ORCPT ); Fri, 4 Jun 2021 18:58:37 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0B6CC061766 for ; Fri, 4 Jun 2021 15:56:34 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id 36-20020a9d0ba70000b02902e0a0a8fe36so10624601oth.8 for ; Fri, 04 Jun 2021 15:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=FnDgNE0dNPabtyI2dYZ3+dwe3uiezt6oBtZnVyRVbsQ=; b=MQrZjxjqB5TDz728+SZ0yR/naRwzsabVP2EXRIkN2Zs7e16978UTsfwBApajfC+xPp n5ul3MCgEuJFtFU7HYB3akUFtvJRvJbgS1WKWG60trstmkkhRZDfkiQQJgN1KeXQqWrn atgYQO04bvYwHKAoL7fsi2eYlk+ztYQvag7/2glGbYKipekToTVethwSMqi068uBL/6+ 45cYLIuvZGvEcLSXu+LbzWy4nyrQWGX1POSoCjeHfnNZIkeVvKBBvWMhPtMOb68lfzUg 8SLiIdVazXxzOWRpfBxSbDKzLHaA03qffpQwVdfwPzCqCdoIcZQtpWdZ9ZcXJKzvDSv5 NDmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=FnDgNE0dNPabtyI2dYZ3+dwe3uiezt6oBtZnVyRVbsQ=; b=MFSebPAJdcD5Phrn8QwevT+2DXnD8vqXgKeiNecJXKIIZiMc3v6WrD4l+RKzl79aZF qdxEMrB8hLOnznv0k6+WrRr9MYlplT0px4Ns3d/Tp5csG9HyITHLRJUSs4aaDekfkeMu MBV99rP8A6kGendYonfjV2MUZy/zu2mOmZ+C1SRz5GaylHXgWH5lDyPpJHX2taAnz/iG /f2ZwLowCRE9YP2gDiGtRAddhI04V4TzDzRJuvn1L2ENXWl8GSKQ2g4kt10xDZ6qPr2Y /S+gmKnEgB+FqqAfHctP7s3id5Rppl8C/qiSoMVk9okPmTsFfn/rZVAfSQseVQBHTQt3 sNwA== X-Gm-Message-State: AOAM533uXT3opDiOk2Ef0dpc2O6fE0VXKB0bjbQcZuNnrnn6pnabLD5F RIMU/gjOjq/b2ZzCf2JpFL5GTg== X-Google-Smtp-Source: ABdhPJzMEzghsOQ2vwyvqjWVbjIXAPm0Cm9XFlmIQcMrzFInGYUjbU5pZxzeDf48tVMz8LWAIFMxOA== X-Received: by 2002:a05:6830:400b:: with SMTP id h11mr5623567ots.106.1622847394005; Fri, 04 Jun 2021 15:56:34 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id f21sm741088oou.24.2021.06.04.15.56.32 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Fri, 04 Jun 2021 15:56:33 -0700 (PDT) Date: Fri, 4 Jun 2021 15:56:31 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: "Kirill A. Shutemov" cc: Hugh Dickins , Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Naoya Horiguchi , Alistair Popple , Ralph Campbell , Zi Yan , Miaohe Lin , Minchan Kim , Jue Wang , Peter Xu , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] mm/thp: fix page_vma_mapped_walk() if huge page mapped by ptes In-Reply-To: <20210604162402.iclcdd3ywynkoamy@box.shutemov.name> Message-ID: References: <20210604162402.iclcdd3ywynkoamy@box.shutemov.name> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Jun 2021, Kirill A. Shutemov wrote: > On Tue, Jun 01, 2021 at 02:13:21PM -0700, Hugh Dickins wrote: > > > > Merged various other minor fixes and cleanups into page_vma_mapped_walk() > > as I worked on it: which I find much easier to enumerate here than to > > prise apart into separate commits. > > But it makes it harder to review... > > I tried to review it and superficially it looks good, but it has to be > split into bunch of patches. I had hoped to avoid that. Okay, I'll try bisecting it into a preliminary cleanup patch then the bugfix patch, and see if that looks reviewable; divide it up further if not. But my idea of what's reviewable may differ. Hugh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F75C47082 for ; Sat, 5 Jun 2021 05:34:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7B92B613EA for ; Sat, 5 Jun 2021 05:34:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B92B613EA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D50EE6B0036; Sat, 5 Jun 2021 01:34:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D14196B006C; Sat, 5 Jun 2021 01:34:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA1E56B006E; Sat, 5 Jun 2021 01:34:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id 8B24A6B0036 for ; Sat, 5 Jun 2021 01:34:44 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2065A365A for ; Sat, 5 Jun 2021 05:34:44 +0000 (UTC) X-FDA: 78218555688.06.E434B7B Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf04.hostedemail.com (Postfix) with ESMTP id 509D999F for ; Sat, 5 Jun 2021 05:34:41 +0000 (UTC) Received: by mail-yb1-f177.google.com with SMTP id s107so16729194ybi.3 for ; Fri, 04 Jun 2021 22:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=FnDgNE0dNPabtyI2dYZ3+dwe3uiezt6oBtZnVyRVbsQ=; b=MQrZjxjqB5TDz728+SZ0yR/naRwzsabVP2EXRIkN2Zs7e16978UTsfwBApajfC+xPp n5ul3MCgEuJFtFU7HYB3akUFtvJRvJbgS1WKWG60trstmkkhRZDfkiQQJgN1KeXQqWrn atgYQO04bvYwHKAoL7fsi2eYlk+ztYQvag7/2glGbYKipekToTVethwSMqi068uBL/6+ 45cYLIuvZGvEcLSXu+LbzWy4nyrQWGX1POSoCjeHfnNZIkeVvKBBvWMhPtMOb68lfzUg 8SLiIdVazXxzOWRpfBxSbDKzLHaA03qffpQwVdfwPzCqCdoIcZQtpWdZ9ZcXJKzvDSv5 NDmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=FnDgNE0dNPabtyI2dYZ3+dwe3uiezt6oBtZnVyRVbsQ=; b=nI5ubR83qfguiIEHFjeWZHuuKpPJ+JBZcyWArcIysKKhQjBzy75MDSrDmoCZW7P3qw vuD2dIxRDNWOKNrvfR9bltRnJ3XMcTsdHOuuZ44iPsQlkEFsKPMkEww0D4Q/ZTnefOGT CuFEtUVGFZyUa9r5WgfjpW3646/zazocIYx5V3KLynnfP4gt5vX6OQ7RLK64OY8VmHZx M87E3Sj1LZruyphlkZwdjN09U6i0QTZaGXe2vrdHclFC92s/U+eRcoOGSKkRIbK/6Rme Rp4fzWO0a4SLKCvSreEgX9DLsD4c9z03Bb5M9l6XYgMxAtXTcZrYuyKiZuCRJHwYfgNi m/3Q== X-Gm-Message-State: AOAM530x+oVopZM9uKatdQkoBzLB/RV23enArfPOaiuSx/B0rfhktzY1 XIgOHMmXJ5Shi3XRO6xrogaR9vQuPK/O6A== X-Google-Smtp-Source: ABdhPJzMEzghsOQ2vwyvqjWVbjIXAPm0Cm9XFlmIQcMrzFInGYUjbU5pZxzeDf48tVMz8LWAIFMxOA== X-Received: by 2002:a05:6830:400b:: with SMTP id h11mr5623567ots.106.1622847394005; Fri, 04 Jun 2021 15:56:34 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id f21sm741088oou.24.2021.06.04.15.56.32 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Fri, 04 Jun 2021 15:56:33 -0700 (PDT) Date: Fri, 4 Jun 2021 15:56:31 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: "Kirill A. Shutemov" cc: Hugh Dickins , Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Naoya Horiguchi , Alistair Popple , Ralph Campbell , Zi Yan , Miaohe Lin , Minchan Kim , Jue Wang , Peter Xu , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] mm/thp: fix page_vma_mapped_walk() if huge page mapped by ptes In-Reply-To: <20210604162402.iclcdd3ywynkoamy@box.shutemov.name> Message-ID: References: <20210604162402.iclcdd3ywynkoamy@box.shutemov.name> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 509D999F Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=MQrZjxjq; spf=pass (imf04.hostedemail.com: domain of hughd@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 67cn7qmdzkzktujghzngscf7qquicek1 X-HE-Tag: 1622871281-405799 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 4 Jun 2021, Kirill A. Shutemov wrote: > On Tue, Jun 01, 2021 at 02:13:21PM -0700, Hugh Dickins wrote: > > > > Merged various other minor fixes and cleanups into page_vma_mapped_walk() > > as I worked on it: which I find much easier to enumerate here than to > > prise apart into separate commits. > > But it makes it harder to review... > > I tried to review it and superficially it looks good, but it has to be > split into bunch of patches. I had hoped to avoid that. Okay, I'll try bisecting it into a preliminary cleanup patch then the bugfix patch, and see if that looks reviewable; divide it up further if not. But my idea of what's reviewable may differ. Hugh