From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Subject: Re: [PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED control Date: Mon, 19 Dec 2016 11:09:59 +0100 (CET) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-sound-owner@vger.kernel.org To: Dennis Wassenberg Cc: linux-input@vger.kernel.org, linux-sound@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , lukas@wunner.de, Benjamin Tissoires , Andrew Duggan , perex@perex.cz, vinod.koul@intel.com, hui.wang@canonical.com, rafael.j.wysocki@intel.com List-Id: linux-input@vger.kernel.org On Fri, 9 Dec 2016, Dennis Wassenberg wrote: > +#if IS_ENABLED(CONFIG_THINKPAD_ACPI) > + if (led_set_func_tpacpi) > + led_set_func_tpacpi(TPACPI_LED_MUTE, !enabled); > +#endif > +#if IS_ENABLED(CONFIG_HID_LENOVO) > + if (led_set_func_hid_lenovo) > + led_set_func_hid_lenovo(HID_LENOVO_LED_MUTE, !enabled); Where does led_set_func_hid_lenovo() come from? I don't see it in Linus' tree as of today. Is that something else than tpacpi_led_set()? Thanks, -- Jiri Kosina SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Date: Mon, 19 Dec 2016 10:09:59 +0000 Subject: Re: [PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED control Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dennis Wassenberg Cc: linux-input@vger.kernel.org, linux-sound@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , lukas@wunner.de, Benjamin Tissoires , Andrew Duggan , perex@perex.cz, vinod.koul@intel.com, hui.wang@canonical.com, rafael.j.wysocki@intel.com On Fri, 9 Dec 2016, Dennis Wassenberg wrote: > +#if IS_ENABLED(CONFIG_THINKPAD_ACPI) > + if (led_set_func_tpacpi) > + led_set_func_tpacpi(TPACPI_LED_MUTE, !enabled); > +#endif > +#if IS_ENABLED(CONFIG_HID_LENOVO) > + if (led_set_func_hid_lenovo) > + led_set_func_hid_lenovo(HID_LENOVO_LED_MUTE, !enabled); Where does led_set_func_hid_lenovo() come from? I don't see it in Linus' tree as of today. Is that something else than tpacpi_led_set()? Thanks, -- Jiri Kosina SUSE Labs