From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Subject: Re: [PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED control Date: Mon, 19 Dec 2016 11:53:11 +0100 (CET) Message-ID: References: <43171dc4-95e4-4a2b-eebc-0795988eb6f2@secunet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: Received: from mx2.suse.de ([195.135.220.15]:49607 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754995AbcLSKxP (ORCPT ); Mon, 19 Dec 2016 05:53:15 -0500 In-Reply-To: <43171dc4-95e4-4a2b-eebc-0795988eb6f2@secunet.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dennis Wassenberg Cc: linux-input@vger.kernel.org, linux-sound@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , lukas@wunner.de, Benjamin Tissoires , Andrew Duggan , perex@perex.cz, vinod.koul@intel.com, hui.wang@canonical.com, rafael.j.wysocki@intel.com On Mon, 19 Dec 2016, Dennis Wassenberg wrote: > "led_set_func_hid_lenovo" is set to "hid_lenovo_led_set" > > +#if IS_ENABLED(CONFIG_HID_LENOVO) > +static int hda_fixup_thinkpad_hid_prepare(struct hda_codec *codec) > +{ > + struct hda_gen_spec *spec = codec->spec; > + int ret = 0; > + > + if (!is_thinkpad(codec)) > + return -ENODEV; > + if (!led_set_func_hid_lenovo) > + led_set_func_hid_lenovo = symbol_request(hid_lenovo_led_set); > > "hid_lenovo_led_set" is introduced in "[PATCH v2 2/2] hda: > thinkpad_helper: Add support for hid-lenovo LED control". This means > that "[PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED > control" can only work with applied "[PATCH 1/4] hid-lenovo: Add support > for X1 Tablet cover special keys" and "[PATCH v2 2/2] hda: > thinkpad_helper: Add support for hid-lenovo LED control". Ah, okay, I wasn't aware of the other patchset. These two probably should be merged together. Is the other 2-patch set merged in any tree already? Where has it been submitted to? -- Jiri Kosina SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Date: Mon, 19 Dec 2016 10:53:11 +0000 Subject: Re: [PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED control Message-Id: List-Id: References: <43171dc4-95e4-4a2b-eebc-0795988eb6f2@secunet.com> In-Reply-To: <43171dc4-95e4-4a2b-eebc-0795988eb6f2@secunet.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dennis Wassenberg Cc: linux-input@vger.kernel.org, linux-sound@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , lukas@wunner.de, Benjamin Tissoires , Andrew Duggan , perex@perex.cz, vinod.koul@intel.com, hui.wang@canonical.com, rafael.j.wysocki@intel.com On Mon, 19 Dec 2016, Dennis Wassenberg wrote: > "led_set_func_hid_lenovo" is set to "hid_lenovo_led_set" > > +#if IS_ENABLED(CONFIG_HID_LENOVO) > +static int hda_fixup_thinkpad_hid_prepare(struct hda_codec *codec) > +{ > + struct hda_gen_spec *spec = codec->spec; > + int ret = 0; > + > + if (!is_thinkpad(codec)) > + return -ENODEV; > + if (!led_set_func_hid_lenovo) > + led_set_func_hid_lenovo = symbol_request(hid_lenovo_led_set); > > "hid_lenovo_led_set" is introduced in "[PATCH v2 2/2] hda: > thinkpad_helper: Add support for hid-lenovo LED control". This means > that "[PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED > control" can only work with applied "[PATCH 1/4] hid-lenovo: Add support > for X1 Tablet cover special keys" and "[PATCH v2 2/2] hda: > thinkpad_helper: Add support for hid-lenovo LED control". Ah, okay, I wasn't aware of the other patchset. These two probably should be merged together. Is the other 2-patch set merged in any tree already? Where has it been submitted to? -- Jiri Kosina SUSE Labs