From: Jiri Kosina <jikos@kernel.org>
To: Even Xu <even.xu@intel.com>
Cc: benjamin.tissoires@redhat.com,
srinivas.pandruvada@linux.intel.com, arnd@arndb.de,
gregkh@linuxfoundation.org, andriy.shevchenko@intel.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver
Date: Tue, 3 Jan 2017 10:54:00 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1701031050510.28985@cbobk.fhfr.pm> (raw)
In-Reply-To: <1482456149-4841-7-git-send-email-even.xu@intel.com>
On Fri, 23 Dec 2016, Even Xu wrote:
[ ... snip ... ]
> +static ssize_t ishtp_cl_write(struct file *file, const char __user *ubuf,
> + size_t length, loff_t *offset)
> +{
> + struct ishtp_cl_miscdev *ishtp_cl_misc = file->private_data;
> + struct ishtp_cl *cl;
> + void *write_buf;
> + struct ishtp_device *dev;
> + int ret;
> +
> + /* Non-blocking semantics are not supported */
> + if (file->f_flags & O_NONBLOCK) {
> + ret = -EINVAL;
> + goto out_unlock;
When taking the error path here you'd try to unlock
ishtp_cl_misc->cl_mutex before actually acquiring it.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2017-01-03 9:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 1:22 [PATCH 1/7] hid: intel-ish-hid: ishtp: add helper function for driver data get/set Even Xu
2016-12-23 1:22 ` [PATCH 2/7] hid: intel-ish-hid: use helper function for private driver data set/get Even Xu
2016-12-23 1:22 ` [PATCH 3/7] hid: intel-ish-hid: ishtp: add helper functions for client buffer operation Even Xu
2016-12-23 1:22 ` [PATCH 4/7] hid: intel-ish-hid: use helper function to access client buffer Even Xu
2016-12-23 1:22 ` [PATCH 5/7] hid: intel-ish-hid: ishtp: add helper function for client search Even Xu
2016-12-23 1:22 ` [PATCH 6/7] hid: intel-ish-hid: use helper function to search client id Even Xu
2016-12-23 1:22 ` [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver Even Xu
2017-01-03 9:54 ` Jiri Kosina [this message]
2017-01-04 6:55 ` Xu, Even
2017-01-04 6:55 ` Xu, Even
2017-01-04 9:36 ` Jiri Kosina
2017-01-04 9:36 ` Jiri Kosina
2017-01-04 12:59 ` gregkh
2017-01-04 12:59 ` gregkh
2017-01-04 13:03 ` Greg KH
2017-01-04 17:11 ` Srinivas Pandruvada
2017-01-04 17:18 ` Greg KH
2017-01-04 18:41 ` Srinivas Pandruvada
2017-01-04 19:40 ` Greg KH
2017-01-05 5:38 ` Xu, Even
2017-01-04 13:09 ` Greg KH
2017-01-04 13:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1701031050510.28985@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=benjamin.tissoires@redhat.com \
--cc=even.xu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.