All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Oscar Campos <oscar.campos@member.fsf.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] HID: Corsair Scimitar Pro RGB gaming mouse driver and support for other Corsair devices
Date: Mon, 6 Mar 2017 13:55:21 +0100 (CET)	[thread overview]
Message-ID: <alpine.LSU.2.20.1703061353090.31814@cbobk.fhfr.pm> (raw)
In-Reply-To: <20170210182234.GA18830@ManjaroStation>

On Fri, 10 Feb 2017, Oscar Campos wrote:

> Since I have a Corsair Scimitar PRO RGB that does not works on Linux, I
> tried to find a solution doing some research but was not able to find any.
[ ... snip ... ]
> 
> I created the new mouse driver instead of add code to the already existent
> `hid-corsair.c` as it seem quite common to split mouse and keyboard driver
> support.

Hi Oscar,

thanks a lot for the patch.

Keeping the support in hid-corsair would be prefered. I think the only 
driver where we have the major kbd/mouse split is Holtek, which if I 
remember correctly was my fault not having catched this during review; it 
should probably eventually be unified.

Otherwsie, we don't really distinguish the device type (the HID land is 
much wider than mice and keyboards anyway), but in most cases by the 
vendor.

Could you please resubmit the patch so that it's actually adding changes 
to hid-corsair? Thanks!

-- 
Jiri Kosina
SUSE Labs

  reply	other threads:[~2017-03-06 12:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10 18:22 [PATCH 0/2] HID: Corsair Scimitar Pro RGB gaming mouse driver and support for other Corsair devices Oscar Campos
2017-03-06 12:55 ` Jiri Kosina [this message]
2017-03-06 21:09   ` Oscar Campos
2017-03-21 13:46     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.20.1703061353090.31814@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oscar.campos@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.