All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matjaz Hegedic <matjaz.hegedic@gmail.com>
Subject: Re: [PATCH] HID: asus: Add missing Fn key maps on ASUS E200H
Date: Thu, 30 Mar 2017 11:19:21 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LSU.2.20.1703301117560.31814@cbobk.fhfr.pm> (raw)
In-Reply-To: <20170327084104.18105-1-tiwai@suse.de>

On Mon, 27 Mar 2017, Takashi Iwai wrote:

> The mapping of a few Fn combo keys seems missing since they are vendor
> specific usage page (0xff31).  Add the mapping manually for sleep
> (Fn-F1), rfkill (Fn-F2), brightness down (Fn-F5), brightness up
> (Fn-F6), display toggle (Fn-F7), and touchpad toggle (Fn-F9).
> For the display toggle and the touchpad toggle, KEY_SCREENLOCK and
> KEY_F21 are assigned as convention.
> 
> The monitor switch (Fn-F8), and audio volume down / up /mute (Fn-F10,
> F11, F12) work as is without the extra mapping, thus left as is.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

I think is has already been covered by Matjaz's (adding to CC) patches in 
hid.git#for-4.12/asus. Could you please check whether it covers everything 
your patch did?

Thanks,

-- 
Jiri Kosina
SUSE Labs

  reply	other threads:[~2017-03-30  9:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27  8:41 [PATCH] HID: asus: Add missing Fn key maps on ASUS E200H Takashi Iwai
2017-03-30  9:19 ` Jiri Kosina [this message]
2017-03-30  9:42   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.20.1703301117560.31814@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matjaz.hegedic@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.