From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C48EC10F0E for ; Fri, 12 Apr 2019 13:37:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63F612186A for ; Fri, 12 Apr 2019 13:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbfDLNhl (ORCPT ); Fri, 12 Apr 2019 09:37:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:46336 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726772AbfDLNhk (ORCPT ); Fri, 12 Apr 2019 09:37:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9CE86AD51; Fri, 12 Apr 2019 13:37:38 +0000 (UTC) Date: Fri, 12 Apr 2019 15:37:37 +0200 (CEST) From: Miroslav Benes To: shuah cc: jpoimboe@redhat.com, jikos@kernel.org, pmladek@suse.com, joe.lawrence@redhat.com, live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: livepatch use TEST_PROGS for test shell scripts In-Reply-To: <8967c9aa-7eb1-7e6d-a371-f29a2be24c84@kernel.org> Message-ID: References: <20190412011823.26884-1-shuah@kernel.org> <8967c9aa-7eb1-7e6d-a371-f29a2be24c84@kernel.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Apr 2019, shuah wrote: > On 4/12/19 1:03 AM, Miroslav Benes wrote: > > On Thu, 11 Apr 2019, Shuah Khan wrote: > > > >> TEST_PROGS variable is for test shell scripts and common clean target > >> in lib.mk doesn't touch them. TEST_GEN_PROGS are removed by it. > >> > >> Fix it to use TEST_PROGS for test shell scripts and TEST_PROGS_EXTENDED > >> for common functions.sh. > >> > >> Signed-off-by: Shuah Khan > >> --- > >> tools/testing/selftests/livepatch/Makefile | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/tools/testing/selftests/livepatch/Makefile > >> b/tools/testing/selftests/livepatch/Makefile > >> index af4aee79bebb..fd405402c3ff 100644 > >> --- a/tools/testing/selftests/livepatch/Makefile > >> +++ b/tools/testing/selftests/livepatch/Makefile > >> @@ -1,6 +1,7 @@ > >> # SPDX-License-Identifier: GPL-2.0 > >> > >> -TEST_GEN_PROGS := \ > >> +TEST_PROGS_EXTENDED := functions.sh > >> +TEST_PROGS := \ > >> test-livepatch.sh \ > >> test-callbacks.sh \ > >> test-shadow-vars.sh > > > > Hi Shuah, > > > > thanks for the patch. We have already something similar queued in our git > > tree. See > > https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git/commit/?h=for-5.1/upstream-fixes&id=abfe3c4560684864f66641438fee3075de098e89 > > > > It is missing TEST_PROGS_EXTENDED though. Should we add it? > > > > Please do. What that does is when selftests are installed, functions.h > gets installed as well so the the test can run from installed location. > > Did I miss reviewing the original? I maintain the framework and try to > catch these if patch gets sent to me. Unfortunately you did and it was our fault. You were not CCed, no one noticed and we were a bit trigger happy. Sorry about that. It should not have happened. Would this work for you? -->8-- >From c158f5595286dba46f096cc7cc4bcef5ad8b6c16 Mon Sep 17 00:00:00 2001 From: Miroslav Benes Date: Fri, 12 Apr 2019 15:31:42 +0200 Subject: [PATCH] selftests/livepatch: Add functions.sh to TEST_PROGS_EXTENDED Add functions.sh to TEST_PROGS_EXTENDED so that it is installed along with the rest of the selftests and they can be run. Originally-by: Shuah Khan Signed-off-by: Miroslav Benes --- tools/testing/selftests/livepatch/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/livepatch/Makefile b/tools/testing/selftests/livepatch/Makefile index 114f43e2081a..fd405402c3ff 100644 --- a/tools/testing/selftests/livepatch/Makefile +++ b/tools/testing/selftests/livepatch/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 +TEST_PROGS_EXTENDED := functions.sh TEST_PROGS := \ test-livepatch.sh \ test-callbacks.sh \ -- 2.21.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: mbenes at suse.cz (Miroslav Benes) Date: Fri, 12 Apr 2019 15:37:37 +0200 (CEST) Subject: [PATCH] selftests: livepatch use TEST_PROGS for test shell scripts In-Reply-To: <8967c9aa-7eb1-7e6d-a371-f29a2be24c84@kernel.org> References: <20190412011823.26884-1-shuah@kernel.org> <8967c9aa-7eb1-7e6d-a371-f29a2be24c84@kernel.org> Message-ID: On Fri, 12 Apr 2019, shuah wrote: > On 4/12/19 1:03 AM, Miroslav Benes wrote: > > On Thu, 11 Apr 2019, Shuah Khan wrote: > > > >> TEST_PROGS variable is for test shell scripts and common clean target > >> in lib.mk doesn't touch them. TEST_GEN_PROGS are removed by it. > >> > >> Fix it to use TEST_PROGS for test shell scripts and TEST_PROGS_EXTENDED > >> for common functions.sh. > >> > >> Signed-off-by: Shuah Khan > >> --- > >> tools/testing/selftests/livepatch/Makefile | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/tools/testing/selftests/livepatch/Makefile > >> b/tools/testing/selftests/livepatch/Makefile > >> index af4aee79bebb..fd405402c3ff 100644 > >> --- a/tools/testing/selftests/livepatch/Makefile > >> +++ b/tools/testing/selftests/livepatch/Makefile > >> @@ -1,6 +1,7 @@ > >> # SPDX-License-Identifier: GPL-2.0 > >> > >> -TEST_GEN_PROGS := \ > >> +TEST_PROGS_EXTENDED := functions.sh > >> +TEST_PROGS := \ > >> test-livepatch.sh \ > >> test-callbacks.sh \ > >> test-shadow-vars.sh > > > > Hi Shuah, > > > > thanks for the patch. We have already something similar queued in our git > > tree. See > > https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git/commit/?h=for-5.1/upstream-fixes&id=abfe3c4560684864f66641438fee3075de098e89 > > > > It is missing TEST_PROGS_EXTENDED though. Should we add it? > > > > Please do. What that does is when selftests are installed, functions.h > gets installed as well so the the test can run from installed location. > > Did I miss reviewing the original? I maintain the framework and try to > catch these if patch gets sent to me. Unfortunately you did and it was our fault. You were not CCed, no one noticed and we were a bit trigger happy. Sorry about that. It should not have happened. Would this work for you? -->8-- >>From c158f5595286dba46f096cc7cc4bcef5ad8b6c16 Mon Sep 17 00:00:00 2001 From: Miroslav Benes Date: Fri, 12 Apr 2019 15:31:42 +0200 Subject: [PATCH] selftests/livepatch: Add functions.sh to TEST_PROGS_EXTENDED Add functions.sh to TEST_PROGS_EXTENDED so that it is installed along with the rest of the selftests and they can be run. Originally-by: Shuah Khan Signed-off-by: Miroslav Benes --- tools/testing/selftests/livepatch/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/livepatch/Makefile b/tools/testing/selftests/livepatch/Makefile index 114f43e2081a..fd405402c3ff 100644 --- a/tools/testing/selftests/livepatch/Makefile +++ b/tools/testing/selftests/livepatch/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 +TEST_PROGS_EXTENDED := functions.sh TEST_PROGS := \ test-livepatch.sh \ test-callbacks.sh \ -- 2.21.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: mbenes@suse.cz (Miroslav Benes) Date: Fri, 12 Apr 2019 15:37:37 +0200 (CEST) Subject: [PATCH] selftests: livepatch use TEST_PROGS for test shell scripts In-Reply-To: <8967c9aa-7eb1-7e6d-a371-f29a2be24c84@kernel.org> References: <20190412011823.26884-1-shuah@kernel.org> <8967c9aa-7eb1-7e6d-a371-f29a2be24c84@kernel.org> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20190412133737.hmHycE-dMTDlAsXck74Qi8YkzLUcvJF28-QgLwKOVbY@z> On Fri, 12 Apr 2019, shuah wrote: > On 4/12/19 1:03 AM, Miroslav Benes wrote: > > On Thu, 11 Apr 2019, Shuah Khan wrote: > > > >> TEST_PROGS variable is for test shell scripts and common clean target > >> in lib.mk doesn't touch them. TEST_GEN_PROGS are removed by it. > >> > >> Fix it to use TEST_PROGS for test shell scripts and TEST_PROGS_EXTENDED > >> for common functions.sh. > >> > >> Signed-off-by: Shuah Khan > >> --- > >> tools/testing/selftests/livepatch/Makefile | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/tools/testing/selftests/livepatch/Makefile > >> b/tools/testing/selftests/livepatch/Makefile > >> index af4aee79bebb..fd405402c3ff 100644 > >> --- a/tools/testing/selftests/livepatch/Makefile > >> +++ b/tools/testing/selftests/livepatch/Makefile > >> @@ -1,6 +1,7 @@ > >> # SPDX-License-Identifier: GPL-2.0 > >> > >> -TEST_GEN_PROGS := \ > >> +TEST_PROGS_EXTENDED := functions.sh > >> +TEST_PROGS := \ > >> test-livepatch.sh \ > >> test-callbacks.sh \ > >> test-shadow-vars.sh > > > > Hi Shuah, > > > > thanks for the patch. We have already something similar queued in our git > > tree. See > > https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git/commit/?h=for-5.1/upstream-fixes&id=abfe3c4560684864f66641438fee3075de098e89 > > > > It is missing TEST_PROGS_EXTENDED though. Should we add it? > > > > Please do. What that does is when selftests are installed, functions.h > gets installed as well so the the test can run from installed location. > > Did I miss reviewing the original? I maintain the framework and try to > catch these if patch gets sent to me. Unfortunately you did and it was our fault. You were not CCed, no one noticed and we were a bit trigger happy. Sorry about that. It should not have happened. Would this work for you? -->8-- >>From c158f5595286dba46f096cc7cc4bcef5ad8b6c16 Mon Sep 17 00:00:00 2001 From: Miroslav Benes Date: Fri, 12 Apr 2019 15:31:42 +0200 Subject: [PATCH] selftests/livepatch: Add functions.sh to TEST_PROGS_EXTENDED Add functions.sh to TEST_PROGS_EXTENDED so that it is installed along with the rest of the selftests and they can be run. Originally-by: Shuah Khan Signed-off-by: Miroslav Benes --- tools/testing/selftests/livepatch/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/livepatch/Makefile b/tools/testing/selftests/livepatch/Makefile index 114f43e2081a..fd405402c3ff 100644 --- a/tools/testing/selftests/livepatch/Makefile +++ b/tools/testing/selftests/livepatch/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 +TEST_PROGS_EXTENDED := functions.sh TEST_PROGS := \ test-livepatch.sh \ test-callbacks.sh \ -- 2.21.0