From: Miroslav Benes <mbenes@suse.cz>
To: Petr Mladek <pmladek@suse.com>
Cc: jikos@kernel.org, jpoimboe@redhat.com, joe.lawrence@redhat.com,
nstange@suse.de, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 3/3] livepatch: Clean up klp_update_object_relocations() return paths
Date: Thu, 3 Oct 2019 11:08:47 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.21.1910031100150.9011@pobox.suse.cz> (raw)
In-Reply-To: <20191002134623.b6mwrvenrywgwdce@pathway.suse.cz>
On Wed, 2 Oct 2019, Petr Mladek wrote:
> On Thu 2019-09-05 14:45:14, Miroslav Benes wrote:
> > Signed-off-by: Miroslav Benes <mbenes@suse.cz>
>
> This might depend on personal preferences.
True.
> What was the motivation
> for this patch, please? Did it just follow some common
> style in this source file?
We had it like this once, so it is only going back to the original code.
And yes, I think it is better.
Commit b56b36ee6751 ("livepatch: Cleanup module page permission changes")
changed it due to the error handling. Commit 255e732c61db ("livepatch: use
arch_klp_init_object_loaded() to finish arch-specific tasks") removed the
reason for the change but did not cleanup the rest.
> To make it clear. I have no real preference. I just want to avoid
> some back and forth changes of the code depending on who touches
> it at the moment.
I have no real preference either. I noticed something I did not like while
touching the code and that's it.
> I would prefer to either remove this patch or explain the motivation
> in the commit message. Beside that
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
Ok, thanks.
Miroslav
next prev parent reply other threads:[~2019-10-03 9:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 12:45 [RFC PATCH v2 0/3] livepatch: Clear relocation targets on a module removal Miroslav Benes
2019-09-05 12:45 ` [RFC PATCH v2 1/3] " Miroslav Benes
2019-10-02 13:22 ` Petr Mladek
2019-10-03 8:55 ` Miroslav Benes
2019-10-02 18:18 ` Josh Poimboeuf
2019-10-03 9:17 ` Miroslav Benes
2019-09-05 12:45 ` [RFC PATCH v2 2/3] livepatch: Unify functions for writing and clearing object relocations Miroslav Benes
2019-10-02 13:35 ` Petr Mladek
2019-09-05 12:45 ` [RFC PATCH v2 3/3] livepatch: Clean up klp_update_object_relocations() return paths Miroslav Benes
2019-10-02 13:46 ` Petr Mladek
2019-10-03 9:08 ` Miroslav Benes [this message]
2019-10-01 12:30 ` [RFC PATCH v2 0/3] livepatch: Clear relocation targets on a module removal Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.1910031100150.9011@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=nstange@suse.de \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.