From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4237FC43331 for ; Wed, 25 Mar 2020 12:19:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21E2D20775 for ; Wed, 25 Mar 2020 12:19:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727490AbgCYMTU (ORCPT ); Wed, 25 Mar 2020 08:19:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:55804 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727137AbgCYMTS (ORCPT ); Wed, 25 Mar 2020 08:19:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D9101AC91; Wed, 25 Mar 2020 12:19:16 +0000 (UTC) Date: Wed, 25 Mar 2020 13:19:16 +0100 (CET) From: Miroslav Benes To: Peter Zijlstra cc: tglx@linutronix.de, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, x86@kernel.org, mhiramat@kernel.org, brgerst@gmail.com Subject: Re: [PATCH v3 16/26] objtool: Optimize find_rela_by_dest_range() In-Reply-To: <20200324160924.861321325@infradead.org> Message-ID: References: <20200324153113.098167666@infradead.org> <20200324160924.861321325@infradead.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Mar 2020, Peter Zijlstra wrote: > Perf shows there is significant time in find_rela_by_dest(); this is > because we have to iterate the address space per byte, looking for > relocation entries. > > Optimize this by reducing the address space granularity. > > This reduces objtool on vmlinux.o runtime from 4.8 to 4.4 seconds. > > Signed-off-by: Peter Zijlstra (Intel) > Acked-by: Josh Poimboeuf Reviewed-by: Miroslav Benes M