From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54504C4727E for ; Mon, 5 Oct 2020 07:10:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F4742065D for ; Mon, 5 Oct 2020 07:10:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725916AbgJEHKK (ORCPT ); Mon, 5 Oct 2020 03:10:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:48016 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgJEHKJ (ORCPT ); Mon, 5 Oct 2020 03:10:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 600D5AA55; Mon, 5 Oct 2020 07:10:08 +0000 (UTC) Date: Mon, 5 Oct 2020 09:10:07 +0200 (CEST) From: Miroslav Benes To: Josh Poimboeuf cc: Peter Zijlstra , Sami Tolvanen , Masahiro Yamada , Will Deacon , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, jthierry@redhat.com Subject: Re: [PATCH v4 04/29] objtool: Add a pass for generating __mcount_loc In-Reply-To: <20201002141303.hyl72to37wudoi66@treble> Message-ID: References: <20200929214631.3516445-1-samitolvanen@google.com> <20200929214631.3516445-5-samitolvanen@google.com> <20201001133612.GQ2628@hirez.programming.kicks-ass.net> <20201002141303.hyl72to37wudoi66@treble> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Oct 2020, Josh Poimboeuf wrote: > On Thu, Oct 01, 2020 at 03:36:12PM +0200, Peter Zijlstra wrote: > > On Thu, Oct 01, 2020 at 03:17:07PM +0200, Miroslav Benes wrote: > > > > > I also wonder about making 'mcount' command separate from 'check'. Similar > > > to what is 'orc' now. But that could be done later. > > > > I'm not convinced more commands make sense. That only begets us the > > problem of having to run multiple commands. > > Agreed, it gets hairy when we need to combine things. I think "orc" as > a separate subcommand was a mistake. > > We should change to something like > > objtool run [--check] [--orc] [--mcount] > objtool dump [--orc] [--mcount] Yes, that makes sense. Miroslav From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2038DC4363A for ; Mon, 5 Oct 2020 07:12:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB59E20756 for ; Mon, 5 Oct 2020 07:12:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EQlFkOiC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB59E20756 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6ip1aoLpaGxElaEPApaNIVlJl+P0WGsuwVI/X1kC7b0=; b=EQlFkOiC/31cFgVc3W5Tb0S+z bUoFD5a6AR00ipfVH+gKUr/PXhDahAHASq5Qj34gihU60oW5pcAhVmV53Y7vAyMdZoeBdoT3hcyiF FfOfZ46q6bxILAg2ZDfBwfkRaWQoTg+b01f+vDhLtKMb3YFH6SNz/luvX3Va20CMcsKzgP6gAyPox aq6AQV4PaPPp2FsRXdPbyt9QIkhWfUkNOkkxQ2le8PH1y9tGshVf53fKWZkv+TrneNFnbq+Psd15K nmhVfweGTnvy05SIBLsWowAeC7ouKXumNKSwhK0n22IpQYWzqOZtIW7QtF0aUzJeZtIUghq0IhYvz QF2DdhfjA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPKdb-0006Lh-7b; Mon, 05 Oct 2020 07:10:23 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPKdX-0006Jm-BB for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 07:10:20 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 600D5AA55; Mon, 5 Oct 2020 07:10:08 +0000 (UTC) Date: Mon, 5 Oct 2020 09:10:07 +0200 (CEST) From: Miroslav Benes To: Josh Poimboeuf Subject: Re: [PATCH v4 04/29] objtool: Add a pass for generating __mcount_loc In-Reply-To: <20201002141303.hyl72to37wudoi66@treble> Message-ID: References: <20200929214631.3516445-1-samitolvanen@google.com> <20200929214631.3516445-5-samitolvanen@google.com> <20201001133612.GQ2628@hirez.programming.kicks-ass.net> <20201002141303.hyl72to37wudoi66@treble> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_031019_500394_3864D2D8 X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, Kees Cook , "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, Sami Tolvanen , linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org, jthierry@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2 Oct 2020, Josh Poimboeuf wrote: > On Thu, Oct 01, 2020 at 03:36:12PM +0200, Peter Zijlstra wrote: > > On Thu, Oct 01, 2020 at 03:17:07PM +0200, Miroslav Benes wrote: > > > > > I also wonder about making 'mcount' command separate from 'check'. Similar > > > to what is 'orc' now. But that could be done later. > > > > I'm not convinced more commands make sense. That only begets us the > > problem of having to run multiple commands. > > Agreed, it gets hairy when we need to combine things. I think "orc" as > a separate subcommand was a mistake. > > We should change to something like > > objtool run [--check] [--orc] [--mcount] > objtool dump [--orc] [--mcount] Yes, that makes sense. Miroslav _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE58C4727D for ; Mon, 5 Oct 2020 07:10:30 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id A11492065D for ; Mon, 5 Oct 2020 07:10:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A11492065D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-20090-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 15531 invoked by uid 550); 5 Oct 2020 07:10:20 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 15508 invoked from network); 5 Oct 2020 07:10:19 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Date: Mon, 5 Oct 2020 09:10:07 +0200 (CEST) From: Miroslav Benes To: Josh Poimboeuf cc: Peter Zijlstra , Sami Tolvanen , Masahiro Yamada , Will Deacon , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, jthierry@redhat.com Subject: Re: [PATCH v4 04/29] objtool: Add a pass for generating __mcount_loc In-Reply-To: <20201002141303.hyl72to37wudoi66@treble> Message-ID: References: <20200929214631.3516445-1-samitolvanen@google.com> <20200929214631.3516445-5-samitolvanen@google.com> <20201001133612.GQ2628@hirez.programming.kicks-ass.net> <20201002141303.hyl72to37wudoi66@treble> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 2 Oct 2020, Josh Poimboeuf wrote: > On Thu, Oct 01, 2020 at 03:36:12PM +0200, Peter Zijlstra wrote: > > On Thu, Oct 01, 2020 at 03:17:07PM +0200, Miroslav Benes wrote: > > > > > I also wonder about making 'mcount' command separate from 'check'. Similar > > > to what is 'orc' now. But that could be done later. > > > > I'm not convinced more commands make sense. That only begets us the > > problem of having to run multiple commands. > > Agreed, it gets hairy when we need to combine things. I think "orc" as > a separate subcommand was a mistake. > > We should change to something like > > objtool run [--check] [--orc] [--mcount] > objtool dump [--orc] [--mcount] Yes, that makes sense. Miroslav