From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C23C8C433E6 for ; Tue, 2 Feb 2021 18:00:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80BF664ECE for ; Tue, 2 Feb 2021 18:00:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238136AbhBBSAR (ORCPT ); Tue, 2 Feb 2021 13:00:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:43122 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233952AbhBBOIf (ORCPT ); Tue, 2 Feb 2021 09:08:35 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 50039B0C6; Tue, 2 Feb 2021 14:07:52 +0000 (UTC) Date: Tue, 2 Feb 2021 15:07:51 +0100 (CET) From: Miroslav Benes To: Christoph Hellwig cc: Frederic Barrat , Andrew Donnellan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jessica Yu , Josh Poimboeuf , Jiri Kosina , Petr Mladek , Joe Lawrence , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, live-patching@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH 10/13] module: pass struct find_symbol_args to find_symbol In-Reply-To: <20210202121334.1361503-11-hch@lst.de> Message-ID: References: <20210202121334.1361503-1-hch@lst.de> <20210202121334.1361503-11-hch@lst.de> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > void *__symbol_get(const char *symbol) > { > - struct module *owner; > - const struct kernel_symbol *sym; > + struct find_symbol_arg fsa = { > + .name = symbol, > + .gplok = true, > + .warn = true, > + }; > > preempt_disable(); > - sym = find_symbol(symbol, &owner, NULL, NULL, true, true); > - if (sym && strong_try_module_get(owner)) > - sym = NULL; > + if (!find_symbol(&fsa) || !strong_try_module_get(fsa.owner)) { I think this should be in fact if (!find_symbol(&fsa) || strong_try_module_get(fsa.owner)) { to get the logic right (note the missing !). We want to return NULL if strong_try_module_get() does not succeed for a found symbol. > + preempt_enable(); > + return NULL; > + } > preempt_enable(); > - > - return sym ? (void *)kernel_symbol_value(sym) : NULL; > + return (void *)kernel_symbol_value(fsa.sym); > } > EXPORT_SYMBOL_GPL(__symbol_get); Miroslav From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D19EC433DB for ; Wed, 3 Feb 2021 02:11:52 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90CFD64F4A for ; Wed, 3 Feb 2021 02:11:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90CFD64F4A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DVlYK2SjhzDwhk for ; Wed, 3 Feb 2021 13:11:49 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.220.15; helo=mx2.suse.de; envelope-from=mbenes@suse.cz; receiver=) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DVRV345DrzDqvh for ; Wed, 3 Feb 2021 01:07:55 +1100 (AEDT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 50039B0C6; Tue, 2 Feb 2021 14:07:52 +0000 (UTC) Date: Tue, 2 Feb 2021 15:07:51 +0100 (CET) From: Miroslav Benes To: Christoph Hellwig Subject: Re: [PATCH 10/13] module: pass struct find_symbol_args to find_symbol In-Reply-To: <20210202121334.1361503-11-hch@lst.de> Message-ID: References: <20210202121334.1361503-1-hch@lst.de> <20210202121334.1361503-11-hch@lst.de> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , Jiri Kosina , Andrew Donnellan , linux-kbuild@vger.kernel.org, David Airlie , Masahiro Yamada , Josh Poimboeuf , Maarten Lankhorst , linux-kernel@vger.kernel.org, Maxime Ripard , live-patching@vger.kernel.org, Michal Marek , Joe Lawrence , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Jessica Yu , Frederic Barrat , Daniel Vetter , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" > void *__symbol_get(const char *symbol) > { > - struct module *owner; > - const struct kernel_symbol *sym; > + struct find_symbol_arg fsa = { > + .name = symbol, > + .gplok = true, > + .warn = true, > + }; > > preempt_disable(); > - sym = find_symbol(symbol, &owner, NULL, NULL, true, true); > - if (sym && strong_try_module_get(owner)) > - sym = NULL; > + if (!find_symbol(&fsa) || !strong_try_module_get(fsa.owner)) { I think this should be in fact if (!find_symbol(&fsa) || strong_try_module_get(fsa.owner)) { to get the logic right (note the missing !). We want to return NULL if strong_try_module_get() does not succeed for a found symbol. > + preempt_enable(); > + return NULL; > + } > preempt_enable(); > - > - return sym ? (void *)kernel_symbol_value(sym) : NULL; > + return (void *)kernel_symbol_value(fsa.sym); > } > EXPORT_SYMBOL_GPL(__symbol_get); Miroslav From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28562C433E6 for ; Wed, 3 Feb 2021 08:13:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C134C64F50 for ; Wed, 3 Feb 2021 08:13:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C134C64F50 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE5F66E9D8; Wed, 3 Feb 2021 08:13:08 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE0736E1B5 for ; Tue, 2 Feb 2021 14:07:53 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 50039B0C6; Tue, 2 Feb 2021 14:07:52 +0000 (UTC) Date: Tue, 2 Feb 2021 15:07:51 +0100 (CET) From: Miroslav Benes To: Christoph Hellwig Subject: Re: [PATCH 10/13] module: pass struct find_symbol_args to find_symbol In-Reply-To: <20210202121334.1361503-11-hch@lst.de> Message-ID: References: <20210202121334.1361503-1-hch@lst.de> <20210202121334.1361503-11-hch@lst.de> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 03 Feb 2021 08:13:07 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , Jiri Kosina , Andrew Donnellan , linux-kbuild@vger.kernel.org, David Airlie , Masahiro Yamada , Josh Poimboeuf , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Michal Marek , Joe Lawrence , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Jessica Yu , Frederic Barrat , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > void *__symbol_get(const char *symbol) > { > - struct module *owner; > - const struct kernel_symbol *sym; > + struct find_symbol_arg fsa = { > + .name = symbol, > + .gplok = true, > + .warn = true, > + }; > > preempt_disable(); > - sym = find_symbol(symbol, &owner, NULL, NULL, true, true); > - if (sym && strong_try_module_get(owner)) > - sym = NULL; > + if (!find_symbol(&fsa) || !strong_try_module_get(fsa.owner)) { I think this should be in fact if (!find_symbol(&fsa) || strong_try_module_get(fsa.owner)) { to get the logic right (note the missing !). We want to return NULL if strong_try_module_get() does not succeed for a found symbol. > + preempt_enable(); > + return NULL; > + } > preempt_enable(); > - > - return sym ? (void *)kernel_symbol_value(sym) : NULL; > + return (void *)kernel_symbol_value(fsa.sym); > } > EXPORT_SYMBOL_GPL(__symbol_get); Miroslav _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel