From: Miroslav Benes <mbenes@suse.cz>
To: Jon Mediero <jmdr@disroot.org>
Cc: Jessica Yu <jeyu@kernel.org>, Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: correctly exit module_kallsyms_on_each_symbol when fn() != 0
Date: Thu, 20 May 2021 16:39:43 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.21.2105201639330.1498@pobox.suse.cz> (raw)
In-Reply-To: <20210520122326.18563-1-jmdr@disroot.org>
On Thu, 20 May 2021, Jon Mediero wrote:
> Commit 013c1667cf78 ("kallsyms: refactor
> {,module_}kallsyms_on_each_symbol") replaced the return inside the
> nested loop with a break, changing the semantics of the function: the
> break only exits the innermost loop, so the code continues iterating the
> symbols of the next module instead of exiting.
>
> Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
> Signed-off-by: Jon Mediero <jmdr@disroot.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
M
next prev parent reply other threads:[~2021-05-20 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210520122326.18563-1-jmdr@disroot.org>
2021-05-20 14:23 ` [PATCH] module: correctly exit module_kallsyms_on_each_symbol when fn() != 0 Petr Mladek
2021-05-20 14:39 ` Miroslav Benes [this message]
2021-05-26 12:58 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2105201639330.1498@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=jeyu@kernel.org \
--cc=jmdr@disroot.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.