From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA0FC433EF for ; Mon, 1 Nov 2021 14:51:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 035C260F24 for ; Mon, 1 Nov 2021 14:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232050AbhKAOxf (ORCPT ); Mon, 1 Nov 2021 10:53:35 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:56310 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbhKAOxe (ORCPT ); Mon, 1 Nov 2021 10:53:34 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 3667E212C4; Mon, 1 Nov 2021 14:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635778259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S57HysUOBDmaPPkxy9xFNLNnV0qtuzg356ms8vO+zDs=; b=nLv/ytfioPKJ2E5inNqVfktlCIOh/RPq/TlUvEwD1rgVLFbnikQWvgIYm0r/+YenHEb510 +FNTcadrc/mOf1cy8uwCKQFzWvFzNJzejuqTos3otALVjlqAO/6KIk7tU5rWWsiWl115uS 1Bxs+rsKmQbL/dmXmw8WUxxmkKl2z7U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635778259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S57HysUOBDmaPPkxy9xFNLNnV0qtuzg356ms8vO+zDs=; b=iyf/3iVAxxHKP+6EEdNXf4jPP4/47uaCQuTqXGFTdNiJUg/ClccGZ5pHL+GGYn0EppdCQC bsi3/nLwLHHiOmCg== Received: from pobox.suse.cz (pobox.suse.cz [10.100.2.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 8FBF4A3B83; Mon, 1 Nov 2021 14:50:58 +0000 (UTC) Date: Mon, 1 Nov 2021 15:50:58 +0100 (CET) From: Miroslav Benes To: Christophe Leroy cc: Josh Poimboeuf , Jiri Kosina , Petr Mladek , Joe Lawrence , Steven Rostedt , Ingo Molnar , "Naveen N . Rao" , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, live-patching@vger.kernel.org Subject: Re: [PATCH v1 0/5] Implement livepatch on PPC32 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, 28 Oct 2021, Christophe Leroy wrote: > This series implements livepatch on PPC32. > > This is largely copied from what's done on PPC64. > > Christophe Leroy (5): > livepatch: Fix build failure on 32 bits processors > powerpc/ftrace: No need to read LR from stack in _mcount() > powerpc/ftrace: Add module_trampoline_target() for PPC32 > powerpc/ftrace: Activate HAVE_DYNAMIC_FTRACE_WITH_REGS on PPC32 > powerpc/ftrace: Add support for livepatch to PPC32 > > arch/powerpc/Kconfig | 2 +- > arch/powerpc/include/asm/livepatch.h | 4 +- > arch/powerpc/kernel/module_32.c | 33 +++++ > arch/powerpc/kernel/trace/ftrace.c | 53 +++----- > arch/powerpc/kernel/trace/ftrace_32.S | 187 ++++++++++++++++++++++++-- > kernel/livepatch/core.c | 4 +- > 6 files changed, 230 insertions(+), 53 deletions(-) thanks for the patch set! I wondered whether the reliability of stack traces also applies to PPC32. This was obviously resolved by accdd093f260 ("powerpc: Activate HAVE_RELIABLE_STACKTRACE for all"). Did the patch set pass the selftests in tools/testing/selftests/livepatch/ ? Regards Miroslav From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD02C433F5 for ; Mon, 1 Nov 2021 14:51:50 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A38586112D for ; Mon, 1 Nov 2021 14:51:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A38586112D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hjbb64dNZz2yfm for ; Tue, 2 Nov 2021 01:51:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa header.b=nLv/ytfi; dkim=fail reason="signature verification failed" header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=iyf/3iVA; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.220.28; helo=smtp-out1.suse.de; envelope-from=mbenes@suse.cz; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa header.b=nLv/ytfi; dkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=iyf/3iVA; dkim-atps=neutral Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HjbZJ3Mpxz2xXW for ; Tue, 2 Nov 2021 01:51:03 +1100 (AEDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 3667E212C4; Mon, 1 Nov 2021 14:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635778259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S57HysUOBDmaPPkxy9xFNLNnV0qtuzg356ms8vO+zDs=; b=nLv/ytfioPKJ2E5inNqVfktlCIOh/RPq/TlUvEwD1rgVLFbnikQWvgIYm0r/+YenHEb510 +FNTcadrc/mOf1cy8uwCKQFzWvFzNJzejuqTos3otALVjlqAO/6KIk7tU5rWWsiWl115uS 1Bxs+rsKmQbL/dmXmw8WUxxmkKl2z7U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635778259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S57HysUOBDmaPPkxy9xFNLNnV0qtuzg356ms8vO+zDs=; b=iyf/3iVAxxHKP+6EEdNXf4jPP4/47uaCQuTqXGFTdNiJUg/ClccGZ5pHL+GGYn0EppdCQC bsi3/nLwLHHiOmCg== Received: from pobox.suse.cz (pobox.suse.cz [10.100.2.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 8FBF4A3B83; Mon, 1 Nov 2021 14:50:58 +0000 (UTC) Date: Mon, 1 Nov 2021 15:50:58 +0100 (CET) From: Miroslav Benes To: Christophe Leroy Subject: Re: [PATCH v1 0/5] Implement livepatch on PPC32 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , Joe Lawrence , Jiri Kosina , linux-kernel@vger.kernel.org, Steven Rostedt , Ingo Molnar , Josh Poimboeuf , live-patching@vger.kernel.org, "Naveen N . Rao" , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi, On Thu, 28 Oct 2021, Christophe Leroy wrote: > This series implements livepatch on PPC32. > > This is largely copied from what's done on PPC64. > > Christophe Leroy (5): > livepatch: Fix build failure on 32 bits processors > powerpc/ftrace: No need to read LR from stack in _mcount() > powerpc/ftrace: Add module_trampoline_target() for PPC32 > powerpc/ftrace: Activate HAVE_DYNAMIC_FTRACE_WITH_REGS on PPC32 > powerpc/ftrace: Add support for livepatch to PPC32 > > arch/powerpc/Kconfig | 2 +- > arch/powerpc/include/asm/livepatch.h | 4 +- > arch/powerpc/kernel/module_32.c | 33 +++++ > arch/powerpc/kernel/trace/ftrace.c | 53 +++----- > arch/powerpc/kernel/trace/ftrace_32.S | 187 ++++++++++++++++++++++++-- > kernel/livepatch/core.c | 4 +- > 6 files changed, 230 insertions(+), 53 deletions(-) thanks for the patch set! I wondered whether the reliability of stack traces also applies to PPC32. This was obviously resolved by accdd093f260 ("powerpc: Activate HAVE_RELIABLE_STACKTRACE for all"). Did the patch set pass the selftests in tools/testing/selftests/livepatch/ ? Regards Miroslav