All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chad Dupuis <chad.dupuis@qlogic.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
	saurav.kashyap@qlogic.com, linux-scsi@vger.kernel.org,
	linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH 3/5] bnx2fc: Print netdev device name when FCoE is successfully initialized.
Date: Fri, 1 Apr 2016 10:08:22 -0400	[thread overview]
Message-ID: <alpine.OSX.2.00.1604011007130.795@administrators-macbook-pro.local> (raw)
In-Reply-To: <7007693da84d5e6613ba8c1ed321780b@suse.de>


On Fri, 1 Apr 2016, Johannes Thumshirn wrote:

> On 2016-04-01 15:10, Chad Dupuis wrote:
>> Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com>
>> ---
>>  drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
>> b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
>> index d95eee6..60423cf 100644
>> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
>> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
>> @@ -2044,6 +2044,8 @@ static void bnx2fc_ulp_init(struct cnic_dev *dev)
>>  		return;
>>  	}
>> 
>> +	pr_err(PFX "FCoE initialized for %s.\n", dev->netdev->name);
>> +
>>  	/* Add HBA to the adapter list */
>>  	mutex_lock(&bnx2fc_dev_lock);
>>  	list_add_tail(&hba->list, &adapter_list);
>
> I don't think KERN_ERR is the appropriate log level for this, can you change 
> it to pr_info()?
>

Yes, I'll change it to a pr_info in a V2 set.

  reply	other threads:[~2016-04-01 14:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 13:10 [PATCH 0/5] bnx2fc: Update driver to 2.10.3 Chad Dupuis
2016-04-01 13:10 ` [PATCH 1/5] bnx2fc: Add driver tunables Chad Dupuis
2016-04-01 13:56   ` Johannes Thumshirn
2016-04-01 14:06     ` Chad Dupuis
2016-04-01 18:57       ` James Bottomley
2016-04-04 14:23         ` Chad Dupuis
2016-04-04  7:01       ` Johannes Thumshirn
2016-04-01 13:10 ` [PATCH 2/5] bnx2fc: Print when we send a fip keep alive Chad Dupuis
2016-04-01 13:57   ` Johannes Thumshirn
2016-04-01 13:10 ` [PATCH 3/5] bnx2fc: Print netdev device name when FCoE is successfully initialized Chad Dupuis
2016-04-01 13:58   ` Johannes Thumshirn
2016-04-01 14:08     ` Chad Dupuis [this message]
2016-04-01 13:10 ` [PATCH 4/5] bnx2fc: Check sc_cmd device and host pointer before returning the command to the mid-layer Chad Dupuis
2016-04-01 14:02   ` Johannes Thumshirn
2016-04-01 13:10 ` [PATCH 5/5] bnx2fc: Update version number to 2.10.3 Chad Dupuis
2016-04-01 14:02   ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.OSX.2.00.1604011007130.795@administrators-macbook-pro.local \
    --to=chad.dupuis@qlogic.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-scsi-owner@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=saurav.kashyap@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.