Matthieu,

On Mon, 7 Oct 2019, Matthieu Baerts wrote:

> On 07/10/2019 17:23, Florian Westphal wrote:
>> Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
>>> On 07/10/2019 17:00, Florian Westphal wrote:
>>>> Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
>>>>>> ... this turns 'tcp: clean ext on tx recycle' into a one-line change.
>>>>> 
>>>>> Good idea! Just applied this diff and added your signed-off to the 
>>>>> patch.
>>>> 
>>>> Thanks!
>>> 
>>> Just in case you want to check, here is the diff between my two branches:
>> 
>> [..]
>> 
>>> If there is no objection, I am going to re-create the TopGit tree with 
>>> this
>>> new branch then!
>> 
>> Looks good, go ahead.
>
> TopGit tree re-created, export branch has been recreated, tests are still OK.
>


I have one more change to suggest. In "tcp: Expose tcp struct and routine 
for MPTCP", we don't need to expose tcp_v4_init_sock() - that was probably 
associated with the pre-ULP code.

That reduces the patch to only exporting tcp_request_sock_ipv4_ops, which 
I would suggest squashing with "tcp: Export low-level TCP functions" and 
then updating the commit message:

"""
tcp: Export TCP functions and ops struct

MPTCP will make use of tcp_send_mss() and tcp_push() when sending
data to specific TCP subflows.

tcp_request_sock_ipv4_ops will be referenced during TCP subflow creation.

"""



--
Mat Martineau
Intel