From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7ACCC433B4 for ; Tue, 4 May 2021 16:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9449861177 for ; Tue, 4 May 2021 16:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231713AbhEDQsQ (ORCPT ); Tue, 4 May 2021 12:48:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231651AbhEDQsQ (ORCPT ); Tue, 4 May 2021 12:48:16 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 529D3C061574 for ; Tue, 4 May 2021 09:47:19 -0700 (PDT) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 05E99580; Tue, 4 May 2021 18:47:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1620146836; bh=HZBWdIAE24TsMi3WzAwcMDQHYFa615RbODQWsNEc5s0=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=puRnk0fCvMmznm9US3izZY3ZMoXSh9E0sttHxTe5IWKiZAb/O7YY7CyQddaJoZbTs /pLJJ4OmNS054LDHrzdKekuTZ/8mveGpNuG/T/Ck3iNN1Yta7xzCTvOB00BUuebdgx vB8UjakzEkCT1Vq8ar4qL86oPvMncHn34mzQXORQ= Reply-To: kieran.bingham+renesas@ideasonboard.com Subject: Re: [PATCH] arm64: dts: renesas: eagle: Add x1 clock To: Geert Uytterhoeven , Magnus Damm , Laurent Pinchart Cc: linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Valentine Barshak References: <75a66bae21937da1c69e8024ce61b35aad4ac9b8.1620119570.git.geert+renesas@glider.be> From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Tue, 4 May 2021 17:47:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <75a66bae21937da1c69e8024ce61b35aad4ac9b8.1620119570.git.geert+renesas@glider.be> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert, Valentine, On 04/05/2021 10:14, Geert Uytterhoeven wrote: > From: Valentine Barshak > > This adds X1 clock which supplies a frequency of 148.5 MHz. > This clock is connected to the external dot clock input signal. > > Signed-off-by: Valentine Barshak > [geert: Verified schematics] > Signed-off-by: Geert Uytterhoeven > --- > Untested due to lack of hardware Tested on my Eagle-V3M with running the DU tests: Testing composition on CRTC 46: SUCCESS Testing connector HDMI-A-1: SUCCESS Testing plane formats: SUCCESS Testing legacy mode set on connector HDMI-A-1: SUCCESS Testing modes on connector HDMI-A-1: SUCCESS Testing atomic mode set on connector HDMI-A-1: SUCCESS Testing page flip on connector HDMI-A-1: SUCCESS Testing plane positioning boundaries: SUCCESS and verifying that the output visible was as expected. Tested-by: Kieran Bingham Reviewed-by: Kieran Bingham > --- > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > index 874a7fc2730b00db..5c84681703edad2e 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > @@ -73,6 +73,12 @@ memory@48000000 { > /* first 128MB is reserved for secure area. */ > reg = <0x0 0x48000000 0x0 0x38000000>; > }; > + > + x1_clk: x1-clock { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <148500000>; > + }; > }; > > &avb { > @@ -104,6 +110,8 @@ channel0 { > }; > > &du { > + clocks = <&cpg CPG_MOD 724>, <&x1_clk>; > + clock-names = "du.0", "dclkin.0"; > status = "okay"; > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18609C433B4 for ; Tue, 4 May 2021 16:49:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D46D613BC for ; Tue, 4 May 2021 16:49:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D46D613BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=blsLvhpFJCDSoOQWtMg7LuTWZvPx+m/kQ85ekxZCtdg=; b=GOqFHQdR4Y4rPAWH6k+O+kRl8 pc2ctFtiAC7XLuMe9J0W4IMTAM2eeWvO+XOytinjd6Xe0vUv6ILVWFf8pwn3mGcu0XgDFWRB/s/An ExJd8/yQJEErjwh5DaI/tM3Kek4ALxzVqyZ974L1hmzzUFSfyUZpW3Rkn9exNwtXcEf3rTT+giHqO o1821tzJpxRw+T6yhPd5N/BHey5O+QZM1Rhx06NP4kvHsTHM+HrBpSpVUEVO8bdNXDUdn6WBpTP83 +6Ung9IC7MQGlnKeWQJPaVhEvEZ5s9+ISgtRKJCJEz1iCiHbniqoVPjtHqzGS0IC7hcLQr/9iWUtM k4CHLQNWQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldyCs-00GaEa-0v; Tue, 04 May 2021 16:47:34 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldyCp-00GaE7-Aq for linux-arm-kernel@desiato.infradead.org; Tue, 04 May 2021 16:47:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Reply-To:Sender:Content-ID:Content-Description; bh=vbOGK+TZoC05tMGI9V8Pa6BFLEpbMMwM70i8LlCUS+E=; b=a3yCE3cZbjlrOQpKCVHOA/JLYG NdxCBBmkiWxlPCReZNPsNn/R3qpkiBcD/Adpwfbcti5WT39IKB6WIT14p+PFFKVd5TwJJ0P5yF3zA GICt5dG1EPanWe/aRxnksKFc7podC0i6gdSu4+bG3CnvAboTICQnUQLpnMe9IyDEOvciOhyogedEV 6KVTbXzJdJDjNKka2l/c0fST2G86CzqbWXqxBk7JcqXp1bG4noedNfQGv9LpmHu/HCR2siLoimfC7 mSCUMYgb1WWB/B1/2LV0sLdLhoo0kLuVe2tI99PJHFtu75PudM6bcTLJB8FV2DDQaCwmDY8frhhXz Ydc3wvkw==; Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldyCm-0047EI-Fj for linux-arm-kernel@lists.infradead.org; Tue, 04 May 2021 16:47:29 +0000 Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 05E99580; Tue, 4 May 2021 18:47:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1620146836; bh=HZBWdIAE24TsMi3WzAwcMDQHYFa615RbODQWsNEc5s0=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=puRnk0fCvMmznm9US3izZY3ZMoXSh9E0sttHxTe5IWKiZAb/O7YY7CyQddaJoZbTs /pLJJ4OmNS054LDHrzdKekuTZ/8mveGpNuG/T/Ck3iNN1Yta7xzCTvOB00BUuebdgx vB8UjakzEkCT1Vq8ar4qL86oPvMncHn34mzQXORQ= Subject: Re: [PATCH] arm64: dts: renesas: eagle: Add x1 clock To: Geert Uytterhoeven , Magnus Damm , Laurent Pinchart Cc: linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Valentine Barshak References: <75a66bae21937da1c69e8024ce61b35aad4ac9b8.1620119570.git.geert+renesas@glider.be> From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Tue, 4 May 2021 17:47:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <75a66bae21937da1c69e8024ce61b35aad4ac9b8.1620119570.git.geert+renesas@glider.be> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210504_094728_731912_46EB26AE X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: kieran.bingham+renesas@ideasonboard.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, Valentine, On 04/05/2021 10:14, Geert Uytterhoeven wrote: > From: Valentine Barshak > > This adds X1 clock which supplies a frequency of 148.5 MHz. > This clock is connected to the external dot clock input signal. > > Signed-off-by: Valentine Barshak > [geert: Verified schematics] > Signed-off-by: Geert Uytterhoeven > --- > Untested due to lack of hardware Tested on my Eagle-V3M with running the DU tests: Testing composition on CRTC 46: SUCCESS Testing connector HDMI-A-1: SUCCESS Testing plane formats: SUCCESS Testing legacy mode set on connector HDMI-A-1: SUCCESS Testing modes on connector HDMI-A-1: SUCCESS Testing atomic mode set on connector HDMI-A-1: SUCCESS Testing page flip on connector HDMI-A-1: SUCCESS Testing plane positioning boundaries: SUCCESS and verifying that the output visible was as expected. Tested-by: Kieran Bingham Reviewed-by: Kieran Bingham > --- > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > index 874a7fc2730b00db..5c84681703edad2e 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > @@ -73,6 +73,12 @@ memory@48000000 { > /* first 128MB is reserved for secure area. */ > reg = <0x0 0x48000000 0x0 0x38000000>; > }; > + > + x1_clk: x1-clock { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <148500000>; > + }; > }; > > &avb { > @@ -104,6 +110,8 @@ channel0 { > }; > > &du { > + clocks = <&cpg CPG_MOD 724>, <&x1_clk>; > + clock-names = "du.0", "dclkin.0"; > status = "okay"; > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel