From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6B3C28EA; Fri, 24 Mar 2023 08:31:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 069FAC433D2; Fri, 24 Mar 2023 08:31:36 +0000 (UTC) Message-ID: Date: Fri, 24 Mar 2023 09:31:35 +0100 Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 2/8] media: videobuf2: Make bufs array dynamic allocated To: Benjamin Gaignard , Dan Carpenter , oe-kbuild@lists.linux.dev, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, ming.qian@nxp.com, shijie.qin@nxp.com, eagle.zhou@nxp.com, bin.liu@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, yunfei.dong@mediatek.com, stanimir.k.varbanov@gmail.com, quic_vgarodia@quicinc.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, daniel.almeida@collabora.com, laurent.pinchart@ideasonboard.com Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, kernel@collabora.com References: <4e2cb832-de83-4ba6-bd8a-119a19038cfe@kili.mountain> Content-Language: en-US From: Hans Verkuil In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 24/03/2023 09:11, Benjamin Gaignard wrote: > > Le 24/03/2023 à 06:01, Dan Carpenter a écrit : >> Hi Benjamin, >> >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url:    https://github.com/intel-lab-lkp/linux/commits/Benjamin-Gaignard/media-videobuf2-Access-vb2_queue-bufs-array-through-helper-functions/20230321-183154 >> base:   git://linuxtv.org/media_tree.git master >> patch link:    https://lore.kernel.org/r/20230321102855.346732-3-benjamin.gaignard%40collabora.com >> patch subject: [PATCH v2 2/8] media: videobuf2: Make bufs array dynamic allocated >> config: arm64-randconfig-m041-20230319 (https://download.01.org/0day-ci/archive/20230324/202303240148.lKRnUqW9-lkp@intel.com/config) >> compiler: aarch64-linux-gcc (GCC) 12.1.0 >> >> If you fix the issue, kindly add following tag where applicable >> | Reported-by: kernel test robot >> | Reported-by: Dan Carpenter >> | Link: https://lore.kernel.org/r/202303240148.lKRnUqW9-lkp@intel.com/ >> >> smatch warnings: >> include/media/videobuf2-core.h:1272 vb2_queue_add_buffer() warn: sleeping in atomic context >> drivers/media/common/videobuf2/videobuf2-core.c:2456 vb2_core_queue_init() warn: Please consider using kcalloc instead of kmalloc_array >> >> vim +1272 include/media/videobuf2-core.h >> >> 625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1263  static inline bool vb2_queue_add_buffer(struct vb2_queue *q, struct vb2_buffer *vb) >> 625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1264  { >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1265      bool ret = false; >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1266 >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1267      spin_lock(&q->bufs_lock); >>                                                          ^^^^^^^^^^^^^^^^^^^^^^^ >> Holding a spin lock. >> >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1268 >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1269      if (vb->index >= q->max_num_bufs) { >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1270          struct vb2_buffer **tmp; >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1271 >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21 @1272          tmp = krealloc_array(q->bufs, q->max_num_bufs * 2, sizeof(*q->bufs), GFP_KERNEL); >>                                                                                                                                       ^^^^^^^^^^ >> Sleeping allocation.  GFP_ATOMIC?  Or is there a way to move the >> allocation outside the lock? > > I will add GFP_ATOMIC flag in next version. No need. Instead, don't use realloc here, just allocate a new array, copy over all the data from the old, and then switch q->bufs with the spinlock held. Then you can free the old one. It's only when you update q->bufs that you need the lock. Regards, Hans > > Thanks for your help, > Benjamin > >> >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1273          if (!tmp) >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1274              goto realloc_failed; >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1275 >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1276          q->max_num_bufs *= 2; >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1277          q->bufs = tmp; >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1278      } >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1279 >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1280      if (vb->index < q->max_num_bufs) { >> 625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1281          q->bufs[vb->index] = vb; >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1282          ret = true; >> 625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1283      } >> 625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1284 >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1285  realloc_failed: >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1286      spin_unlock(&q->bufs_lock); >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1287 >> 487d3f14d12ecf Benjamin Gaignard 2023-03-21  1288      return ret; >> 625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1289  } >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3572C6FD1C for ; Fri, 24 Mar 2023 08:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=udjmsFyqmSLmXsFbcQtgRD8uIWExdOPFL4JS+Jf/O8w=; b=Dsc3MlPKNK5X3x S9vvjyxuqSK1ISORczHon1ewkumRNPrvn5wIeGXeUjS8Js7yKnktNPIjmZDnBvJGiBzqnKXIj7gOT FqESsQfvXsEHffXwv6KWXSzYPJOO25knHKIZF2/IEcKgI6CB1OgePhcYPq8XOQTo9F12HMW0i6oRa PkCfuGcFTqQKkKllmmsp2HdO0LzoyWkbjXFi0/mD42wnofSRh3qRzV6Z7pnm48dNjhA7BH50nxHZa vl7g39mgoZw8VoyNmnsFKPdW757xx1iWipGJ2BZJguc54AN5acEghCrOb/bW9zsCWOM3KPwd63NBD yOFrTPQdQnZT6wDUqwoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfcpx-003smP-2d; Fri, 24 Mar 2023 08:31:49 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfcps-003sjl-0G; Fri, 24 Mar 2023 08:31:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E9D462990; Fri, 24 Mar 2023 08:31:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 069FAC433D2; Fri, 24 Mar 2023 08:31:36 +0000 (UTC) Message-ID: Date: Fri, 24 Mar 2023 09:31:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 2/8] media: videobuf2: Make bufs array dynamic allocated To: Benjamin Gaignard , Dan Carpenter , oe-kbuild@lists.linux.dev, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, ming.qian@nxp.com, shijie.qin@nxp.com, eagle.zhou@nxp.com, bin.liu@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, yunfei.dong@mediatek.com, stanimir.k.varbanov@gmail.com, quic_vgarodia@quicinc.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, daniel.almeida@collabora.com, laurent.pinchart@ideasonboard.com Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, kernel@collabora.com References: <4e2cb832-de83-4ba6-bd8a-119a19038cfe@kili.mountain> Content-Language: en-US From: Hans Verkuil In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_013144_217073_AAF7FC0F X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMjQvMDMvMjAyMyAwOToxMSwgQmVuamFtaW4gR2FpZ25hcmQgd3JvdGU6Cj4gCj4gTGUgMjQv MDMvMjAyMyDDoCAwNjowMSwgRGFuIENhcnBlbnRlciBhIMOpY3JpdMKgOgo+PiBIaSBCZW5qYW1p biwKPj4KPj4gaHR0cHM6Ly9naXQtc2NtLmNvbS9kb2NzL2dpdC1mb3JtYXQtcGF0Y2gjX2Jhc2Vf dHJlZV9pbmZvcm1hdGlvbl0KPj4KPj4gdXJsOsKgwqDCoCBodHRwczovL2dpdGh1Yi5jb20vaW50 ZWwtbGFiLWxrcC9saW51eC9jb21taXRzL0JlbmphbWluLUdhaWduYXJkL21lZGlhLXZpZGVvYnVm Mi1BY2Nlc3MtdmIyX3F1ZXVlLWJ1ZnMtYXJyYXktdGhyb3VnaC1oZWxwZXItZnVuY3Rpb25zLzIw MjMwMzIxLTE4MzE1NAo+PiBiYXNlOsKgwqAgZ2l0Oi8vbGludXh0di5vcmcvbWVkaWFfdHJlZS5n aXQgbWFzdGVyCj4+IHBhdGNoIGxpbms6wqDCoMKgIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3Iv MjAyMzAzMjExMDI4NTUuMzQ2NzMyLTMtYmVuamFtaW4uZ2FpZ25hcmQlNDBjb2xsYWJvcmEuY29t Cj4+IHBhdGNoIHN1YmplY3Q6IFtQQVRDSCB2MiAyLzhdIG1lZGlhOiB2aWRlb2J1ZjI6IE1ha2Ug YnVmcyBhcnJheSBkeW5hbWljIGFsbG9jYXRlZAo+PiBjb25maWc6IGFybTY0LXJhbmRjb25maWct bTA0MS0yMDIzMDMxOSAoaHR0cHM6Ly9kb3dubG9hZC4wMS5vcmcvMGRheS1jaS9hcmNoaXZlLzIw MjMwMzI0LzIwMjMwMzI0MDE0OC5sS1JuVXFXOS1sa3BAaW50ZWwuY29tL2NvbmZpZykKPj4gY29t cGlsZXI6IGFhcmNoNjQtbGludXgtZ2NjIChHQ0MpIDEyLjEuMAo+Pgo+PiBJZiB5b3UgZml4IHRo ZSBpc3N1ZSwga2luZGx5IGFkZCBmb2xsb3dpbmcgdGFnIHdoZXJlIGFwcGxpY2FibGUKPj4gfCBS ZXBvcnRlZC1ieToga2VybmVsIHRlc3Qgcm9ib3QgPGxrcEBpbnRlbC5jb20+Cj4+IHwgUmVwb3J0 ZWQtYnk6IERhbiBDYXJwZW50ZXIgPGVycm9yMjdAZ21haWwuY29tPgo+PiB8IExpbms6IGh0dHBz Oi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMzAzMjQwMTQ4LmxLUm5VcVc5LWxrcEBpbnRlbC5jb20v Cj4+Cj4+IHNtYXRjaCB3YXJuaW5nczoKPj4gaW5jbHVkZS9tZWRpYS92aWRlb2J1ZjItY29yZS5o OjEyNzIgdmIyX3F1ZXVlX2FkZF9idWZmZXIoKSB3YXJuOiBzbGVlcGluZyBpbiBhdG9taWMgY29u dGV4dAo+PiBkcml2ZXJzL21lZGlhL2NvbW1vbi92aWRlb2J1ZjIvdmlkZW9idWYyLWNvcmUuYzoy NDU2IHZiMl9jb3JlX3F1ZXVlX2luaXQoKSB3YXJuOiBQbGVhc2UgY29uc2lkZXIgdXNpbmcga2Nh bGxvYyBpbnN0ZWFkIG9mIGttYWxsb2NfYXJyYXkKPj4KPj4gdmltICsxMjcyIGluY2x1ZGUvbWVk aWEvdmlkZW9idWYyLWNvcmUuaAo+Pgo+PiA2MjVkNDZjMWMxZmU4ZSBCZW5qYW1pbiBHYWlnbmFy ZCAyMDIzLTAzLTIxwqAgMTI2M8KgIHN0YXRpYyBpbmxpbmUgYm9vbCB2YjJfcXVldWVfYWRkX2J1 ZmZlcihzdHJ1Y3QgdmIyX3F1ZXVlICpxLCBzdHJ1Y3QgdmIyX2J1ZmZlciAqdmIpCj4+IDYyNWQ0 NmMxYzFmZThlIEJlbmphbWluIEdhaWduYXJkIDIwMjMtMDMtMjHCoCAxMjY0wqAgewo+PiA0ODdk M2YxNGQxMmVjZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI2NcKgwqDCoMKgwqAg Ym9vbCByZXQgPSBmYWxzZTsKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAy My0wMy0yMcKgIDEyNjYKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0w My0yMcKgIDEyNjfCoMKgwqDCoMKgIHNwaW5fbG9jaygmcS0+YnVmc19sb2NrKTsKPj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBeXl5eXl5e Xl5eXl5eXl5eXl5eXl5eXgo+PiBIb2xkaW5nIGEgc3BpbiBsb2NrLgo+Pgo+PiA0ODdkM2YxNGQx MmVjZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI2OAo+PiA0ODdkM2YxNGQxMmVj ZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI2OcKgwqDCoMKgwqAgaWYgKHZiLT5p bmRleCA+PSBxLT5tYXhfbnVtX2J1ZnMpIHsKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2Fp Z25hcmQgMjAyMy0wMy0yMcKgIDEyNzDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHZiMl9idWZm ZXIgKip0bXA7Cj4+IDQ4N2QzZjE0ZDEyZWNmIEJlbmphbWluIEdhaWduYXJkIDIwMjMtMDMtMjHC oCAxMjcxCj4+IDQ4N2QzZjE0ZDEyZWNmIEJlbmphbWluIEdhaWduYXJkIDIwMjMtMDMtMjEgQDEy NzLCoMKgwqDCoMKgwqDCoMKgwqAgdG1wID0ga3JlYWxsb2NfYXJyYXkocS0+YnVmcywgcS0+bWF4 X251bV9idWZzICogMiwgc2l6ZW9mKCpxLT5idWZzKSwgR0ZQX0tFUk5FTCk7Cj4+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF5eXl5eXl5eXl4KPj4gU2xlZXBpbmcgYWxs b2NhdGlvbi7CoCBHRlBfQVRPTUlDP8KgIE9yIGlzIHRoZXJlIGEgd2F5IHRvIG1vdmUgdGhlCj4+ IGFsbG9jYXRpb24gb3V0c2lkZSB0aGUgbG9jaz8KPiAKPiBJIHdpbGwgYWRkIEdGUF9BVE9NSUMg ZmxhZyBpbiBuZXh0IHZlcnNpb24uCgpObyBuZWVkLiBJbnN0ZWFkLCBkb24ndCB1c2UgcmVhbGxv YyBoZXJlLCBqdXN0IGFsbG9jYXRlIGEgbmV3IGFycmF5LCBjb3B5IG92ZXIgYWxsCnRoZSBkYXRh IGZyb20gdGhlIG9sZCwgYW5kIHRoZW4gc3dpdGNoIHEtPmJ1ZnMgd2l0aCB0aGUgc3BpbmxvY2sg aGVsZC4gVGhlbiB5b3UKY2FuIGZyZWUgdGhlIG9sZCBvbmUuCgpJdCdzIG9ubHkgd2hlbiB5b3Ug dXBkYXRlIHEtPmJ1ZnMgdGhhdCB5b3UgbmVlZCB0aGUgbG9jay4KClJlZ2FyZHMsCgoJSGFucwoK PiAKPiBUaGFua3MgZm9yIHlvdXIgaGVscCwKPiBCZW5qYW1pbgo+IAo+Pgo+PiA0ODdkM2YxNGQx MmVjZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI3M8KgwqDCoMKgwqDCoMKgwqDC oCBpZiAoIXRtcCkKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0y McKgIDEyNzTCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIHJlYWxsb2NfZmFpbGVkOwo+ PiA0ODdkM2YxNGQxMmVjZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI3NQo+PiA0 ODdkM2YxNGQxMmVjZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI3NsKgwqDCoMKg wqDCoMKgwqDCoCBxLT5tYXhfbnVtX2J1ZnMgKj0gMjsKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFt aW4gR2FpZ25hcmQgMjAyMy0wMy0yMcKgIDEyNzfCoMKgwqDCoMKgwqDCoMKgwqAgcS0+YnVmcyA9 IHRtcDsKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0yMcKgIDEy NzjCoMKgwqDCoMKgIH0KPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0w My0yMcKgIDEyNzkKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0y McKgIDEyODDCoMKgwqDCoMKgIGlmICh2Yi0+aW5kZXggPCBxLT5tYXhfbnVtX2J1ZnMpIHsKPj4g NjI1ZDQ2YzFjMWZlOGUgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0yMcKgIDEyODHCoMKgwqDC oMKgwqDCoMKgwqAgcS0+YnVmc1t2Yi0+aW5kZXhdID0gdmI7Cj4+IDQ4N2QzZjE0ZDEyZWNmIEJl bmphbWluIEdhaWduYXJkIDIwMjMtMDMtMjHCoCAxMjgywqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9 IHRydWU7Cj4+IDYyNWQ0NmMxYzFmZThlIEJlbmphbWluIEdhaWduYXJkIDIwMjMtMDMtMjHCoCAx MjgzwqDCoMKgwqDCoCB9Cj4+IDYyNWQ0NmMxYzFmZThlIEJlbmphbWluIEdhaWduYXJkIDIwMjMt MDMtMjHCoCAxMjg0Cj4+IDQ4N2QzZjE0ZDEyZWNmIEJlbmphbWluIEdhaWduYXJkIDIwMjMtMDMt MjHCoCAxMjg1wqAgcmVhbGxvY19mYWlsZWQ6Cj4+IDQ4N2QzZjE0ZDEyZWNmIEJlbmphbWluIEdh aWduYXJkIDIwMjMtMDMtMjHCoCAxMjg2wqDCoMKgwqDCoCBzcGluX3VubG9jaygmcS0+YnVmc19s b2NrKTsKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0yMcKgIDEy ODcKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0yMcKgIDEyODjC oMKgwqDCoMKgIHJldHVybiByZXQ7Cj4+IDYyNWQ0NmMxYzFmZThlIEJlbmphbWluIEdhaWduYXJk IDIwMjMtMDMtMjHCoCAxMjg5wqAgfQo+PgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2Nr Y2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C84CC6FD1C for ; Fri, 24 Mar 2023 08:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vn65Heqno97rwaf+AEQgbGQsmEjZV/tjGvSuR1jlACk=; b=wNZ4RSR141rqxy q7w12q58xrmsoPAwaa8Agy5PAi0YVfZzfDeEC1jt0TaCIRdvpC75hmMSu6LR7HeT9tUzSvkjLhjVk wNyCQTK0jZVfQH2s2lh5wzBShlvO/2mlgs1pLpUcP17S3XyqRNnkPEUZHXAk4/qVKfRBiwupCaXL4 v4c7VCHmGuDN4+tAUz3KXv6HN420WbfRJgVmhrhQn+Rp5L5I03DLl0FkODcuwMqSC0snbl6+MdEYQ xNqk9uUVfHL4iKQA/STMZNqaQ/J2BEzYcT0h8/Ym0dsB60hEH0jYj2gHhR3LXfw+Q9ETs6eDJHAXs gtg2HSMAKd1xnlawnvLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfcpw-003slR-0T; Fri, 24 Mar 2023 08:31:48 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfcps-003sjl-0G; Fri, 24 Mar 2023 08:31:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E9D462990; Fri, 24 Mar 2023 08:31:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 069FAC433D2; Fri, 24 Mar 2023 08:31:36 +0000 (UTC) Message-ID: Date: Fri, 24 Mar 2023 09:31:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 2/8] media: videobuf2: Make bufs array dynamic allocated To: Benjamin Gaignard , Dan Carpenter , oe-kbuild@lists.linux.dev, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, ming.qian@nxp.com, shijie.qin@nxp.com, eagle.zhou@nxp.com, bin.liu@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, yunfei.dong@mediatek.com, stanimir.k.varbanov@gmail.com, quic_vgarodia@quicinc.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, daniel.almeida@collabora.com, laurent.pinchart@ideasonboard.com Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, kernel@collabora.com References: <4e2cb832-de83-4ba6-bd8a-119a19038cfe@kili.mountain> Content-Language: en-US From: Hans Verkuil In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_013144_217073_AAF7FC0F X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjQvMDMvMjAyMyAwOToxMSwgQmVuamFtaW4gR2FpZ25hcmQgd3JvdGU6Cj4gCj4gTGUgMjQv MDMvMjAyMyDDoCAwNjowMSwgRGFuIENhcnBlbnRlciBhIMOpY3JpdMKgOgo+PiBIaSBCZW5qYW1p biwKPj4KPj4gaHR0cHM6Ly9naXQtc2NtLmNvbS9kb2NzL2dpdC1mb3JtYXQtcGF0Y2gjX2Jhc2Vf dHJlZV9pbmZvcm1hdGlvbl0KPj4KPj4gdXJsOsKgwqDCoCBodHRwczovL2dpdGh1Yi5jb20vaW50 ZWwtbGFiLWxrcC9saW51eC9jb21taXRzL0JlbmphbWluLUdhaWduYXJkL21lZGlhLXZpZGVvYnVm Mi1BY2Nlc3MtdmIyX3F1ZXVlLWJ1ZnMtYXJyYXktdGhyb3VnaC1oZWxwZXItZnVuY3Rpb25zLzIw MjMwMzIxLTE4MzE1NAo+PiBiYXNlOsKgwqAgZ2l0Oi8vbGludXh0di5vcmcvbWVkaWFfdHJlZS5n aXQgbWFzdGVyCj4+IHBhdGNoIGxpbms6wqDCoMKgIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3Iv MjAyMzAzMjExMDI4NTUuMzQ2NzMyLTMtYmVuamFtaW4uZ2FpZ25hcmQlNDBjb2xsYWJvcmEuY29t Cj4+IHBhdGNoIHN1YmplY3Q6IFtQQVRDSCB2MiAyLzhdIG1lZGlhOiB2aWRlb2J1ZjI6IE1ha2Ug YnVmcyBhcnJheSBkeW5hbWljIGFsbG9jYXRlZAo+PiBjb25maWc6IGFybTY0LXJhbmRjb25maWct bTA0MS0yMDIzMDMxOSAoaHR0cHM6Ly9kb3dubG9hZC4wMS5vcmcvMGRheS1jaS9hcmNoaXZlLzIw MjMwMzI0LzIwMjMwMzI0MDE0OC5sS1JuVXFXOS1sa3BAaW50ZWwuY29tL2NvbmZpZykKPj4gY29t cGlsZXI6IGFhcmNoNjQtbGludXgtZ2NjIChHQ0MpIDEyLjEuMAo+Pgo+PiBJZiB5b3UgZml4IHRo ZSBpc3N1ZSwga2luZGx5IGFkZCBmb2xsb3dpbmcgdGFnIHdoZXJlIGFwcGxpY2FibGUKPj4gfCBS ZXBvcnRlZC1ieToga2VybmVsIHRlc3Qgcm9ib3QgPGxrcEBpbnRlbC5jb20+Cj4+IHwgUmVwb3J0 ZWQtYnk6IERhbiBDYXJwZW50ZXIgPGVycm9yMjdAZ21haWwuY29tPgo+PiB8IExpbms6IGh0dHBz Oi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMzAzMjQwMTQ4LmxLUm5VcVc5LWxrcEBpbnRlbC5jb20v Cj4+Cj4+IHNtYXRjaCB3YXJuaW5nczoKPj4gaW5jbHVkZS9tZWRpYS92aWRlb2J1ZjItY29yZS5o OjEyNzIgdmIyX3F1ZXVlX2FkZF9idWZmZXIoKSB3YXJuOiBzbGVlcGluZyBpbiBhdG9taWMgY29u dGV4dAo+PiBkcml2ZXJzL21lZGlhL2NvbW1vbi92aWRlb2J1ZjIvdmlkZW9idWYyLWNvcmUuYzoy NDU2IHZiMl9jb3JlX3F1ZXVlX2luaXQoKSB3YXJuOiBQbGVhc2UgY29uc2lkZXIgdXNpbmcga2Nh bGxvYyBpbnN0ZWFkIG9mIGttYWxsb2NfYXJyYXkKPj4KPj4gdmltICsxMjcyIGluY2x1ZGUvbWVk aWEvdmlkZW9idWYyLWNvcmUuaAo+Pgo+PiA2MjVkNDZjMWMxZmU4ZSBCZW5qYW1pbiBHYWlnbmFy ZCAyMDIzLTAzLTIxwqAgMTI2M8KgIHN0YXRpYyBpbmxpbmUgYm9vbCB2YjJfcXVldWVfYWRkX2J1 ZmZlcihzdHJ1Y3QgdmIyX3F1ZXVlICpxLCBzdHJ1Y3QgdmIyX2J1ZmZlciAqdmIpCj4+IDYyNWQ0 NmMxYzFmZThlIEJlbmphbWluIEdhaWduYXJkIDIwMjMtMDMtMjHCoCAxMjY0wqAgewo+PiA0ODdk M2YxNGQxMmVjZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI2NcKgwqDCoMKgwqAg Ym9vbCByZXQgPSBmYWxzZTsKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAy My0wMy0yMcKgIDEyNjYKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0w My0yMcKgIDEyNjfCoMKgwqDCoMKgIHNwaW5fbG9jaygmcS0+YnVmc19sb2NrKTsKPj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBeXl5eXl5e Xl5eXl5eXl5eXl5eXl5eXgo+PiBIb2xkaW5nIGEgc3BpbiBsb2NrLgo+Pgo+PiA0ODdkM2YxNGQx MmVjZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI2OAo+PiA0ODdkM2YxNGQxMmVj ZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI2OcKgwqDCoMKgwqAgaWYgKHZiLT5p bmRleCA+PSBxLT5tYXhfbnVtX2J1ZnMpIHsKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2Fp Z25hcmQgMjAyMy0wMy0yMcKgIDEyNzDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHZiMl9idWZm ZXIgKip0bXA7Cj4+IDQ4N2QzZjE0ZDEyZWNmIEJlbmphbWluIEdhaWduYXJkIDIwMjMtMDMtMjHC oCAxMjcxCj4+IDQ4N2QzZjE0ZDEyZWNmIEJlbmphbWluIEdhaWduYXJkIDIwMjMtMDMtMjEgQDEy NzLCoMKgwqDCoMKgwqDCoMKgwqAgdG1wID0ga3JlYWxsb2NfYXJyYXkocS0+YnVmcywgcS0+bWF4 X251bV9idWZzICogMiwgc2l6ZW9mKCpxLT5idWZzKSwgR0ZQX0tFUk5FTCk7Cj4+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF5eXl5eXl5eXl4KPj4gU2xlZXBpbmcgYWxs b2NhdGlvbi7CoCBHRlBfQVRPTUlDP8KgIE9yIGlzIHRoZXJlIGEgd2F5IHRvIG1vdmUgdGhlCj4+ IGFsbG9jYXRpb24gb3V0c2lkZSB0aGUgbG9jaz8KPiAKPiBJIHdpbGwgYWRkIEdGUF9BVE9NSUMg ZmxhZyBpbiBuZXh0IHZlcnNpb24uCgpObyBuZWVkLiBJbnN0ZWFkLCBkb24ndCB1c2UgcmVhbGxv YyBoZXJlLCBqdXN0IGFsbG9jYXRlIGEgbmV3IGFycmF5LCBjb3B5IG92ZXIgYWxsCnRoZSBkYXRh IGZyb20gdGhlIG9sZCwgYW5kIHRoZW4gc3dpdGNoIHEtPmJ1ZnMgd2l0aCB0aGUgc3BpbmxvY2sg aGVsZC4gVGhlbiB5b3UKY2FuIGZyZWUgdGhlIG9sZCBvbmUuCgpJdCdzIG9ubHkgd2hlbiB5b3Ug dXBkYXRlIHEtPmJ1ZnMgdGhhdCB5b3UgbmVlZCB0aGUgbG9jay4KClJlZ2FyZHMsCgoJSGFucwoK PiAKPiBUaGFua3MgZm9yIHlvdXIgaGVscCwKPiBCZW5qYW1pbgo+IAo+Pgo+PiA0ODdkM2YxNGQx MmVjZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI3M8KgwqDCoMKgwqDCoMKgwqDC oCBpZiAoIXRtcCkKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0y McKgIDEyNzTCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIHJlYWxsb2NfZmFpbGVkOwo+ PiA0ODdkM2YxNGQxMmVjZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI3NQo+PiA0 ODdkM2YxNGQxMmVjZiBCZW5qYW1pbiBHYWlnbmFyZCAyMDIzLTAzLTIxwqAgMTI3NsKgwqDCoMKg wqDCoMKgwqDCoCBxLT5tYXhfbnVtX2J1ZnMgKj0gMjsKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFt aW4gR2FpZ25hcmQgMjAyMy0wMy0yMcKgIDEyNzfCoMKgwqDCoMKgwqDCoMKgwqAgcS0+YnVmcyA9 IHRtcDsKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0yMcKgIDEy NzjCoMKgwqDCoMKgIH0KPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0w My0yMcKgIDEyNzkKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0y McKgIDEyODDCoMKgwqDCoMKgIGlmICh2Yi0+aW5kZXggPCBxLT5tYXhfbnVtX2J1ZnMpIHsKPj4g NjI1ZDQ2YzFjMWZlOGUgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0yMcKgIDEyODHCoMKgwqDC oMKgwqDCoMKgwqAgcS0+YnVmc1t2Yi0+aW5kZXhdID0gdmI7Cj4+IDQ4N2QzZjE0ZDEyZWNmIEJl bmphbWluIEdhaWduYXJkIDIwMjMtMDMtMjHCoCAxMjgywqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9 IHRydWU7Cj4+IDYyNWQ0NmMxYzFmZThlIEJlbmphbWluIEdhaWduYXJkIDIwMjMtMDMtMjHCoCAx MjgzwqDCoMKgwqDCoCB9Cj4+IDYyNWQ0NmMxYzFmZThlIEJlbmphbWluIEdhaWduYXJkIDIwMjMt MDMtMjHCoCAxMjg0Cj4+IDQ4N2QzZjE0ZDEyZWNmIEJlbmphbWluIEdhaWduYXJkIDIwMjMtMDMt MjHCoCAxMjg1wqAgcmVhbGxvY19mYWlsZWQ6Cj4+IDQ4N2QzZjE0ZDEyZWNmIEJlbmphbWluIEdh aWduYXJkIDIwMjMtMDMtMjHCoCAxMjg2wqDCoMKgwqDCoCBzcGluX3VubG9jaygmcS0+YnVmc19s b2NrKTsKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0yMcKgIDEy ODcKPj4gNDg3ZDNmMTRkMTJlY2YgQmVuamFtaW4gR2FpZ25hcmQgMjAyMy0wMy0yMcKgIDEyODjC oMKgwqDCoMKgIHJldHVybiByZXQ7Cj4+IDYyNWQ0NmMxYzFmZThlIEJlbmphbWluIEdhaWduYXJk IDIwMjMtMDMtMjHCoCAxMjg5wqAgfQo+PgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK