From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0E082C8E for ; Tue, 5 Oct 2021 22:06:47 +0000 (UTC) Received: by mail-wr1-f47.google.com with SMTP id o20so2345360wro.3 for ; Tue, 05 Oct 2021 15:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=fQrziVQsjoK41YRSvHFjh72HJt/r7Rv3LbcHkyKWWZ0=; b=LB2IoZRRf7cNb+hhjmYdCbFze2eIYGQmxThHHm7Aq8v2SDAzpPwovkGVlDQHit651Y CXVYMuKNP5oI0TljXLIB9FEl0TKPFFuyjGabRi/P5MIDG4HZysYzK6Cm0sU+1renYd/H N17fkEg5ulPU2w933s4E4vyIJZOzEGlPjIELs24XGO980EfEexfSahRDnHrNGJ3ScMqa IICHCP2FxH50HrTgEgZLsSJWpdQQEIz6BH5lSNfeeg896l/r2l5QvTFWYF9aHDqUnH6j /f6UAGo0JLbX+qAggAiyxABE4BZAqlwKRi2dz/3Z5LzSQEp8VRJ11SwnblWjEkGLJtgv Fd/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fQrziVQsjoK41YRSvHFjh72HJt/r7Rv3LbcHkyKWWZ0=; b=EbFievkTO/SNL7gckiSseGUqISGAXcGwZ4zI/8OXkpH4RFUQS9MKVGAqdpdTyYxSUB oU5ZRYrghYVUHHm2Cl3XEkSrl9oYjekDrszoWwAaEOeMJ5dhjcoRH2LZTi4BPlqWvD2I ih6M5bjMh/uc6g8FeDb06I8lhWx06Rjq8gP+g6xreeyz0Ed358Rl61eX9ulxm1Yw6NQG drrub0XATok7VOusqI6MFb5qEvDFMGwBje9hjWtENf38kkRMNb/0MwCFhcF7IouVkG4D 2UrN/OQuY5gk43DFZZLGh6v018+Mv7zLZimkH6LYzmQeK7jmibmEXcRI4xG2jpkYDpcW Eu/A== X-Gm-Message-State: AOAM531vT+cxiahxenP9HyXlA28j9mBaxx8JvwJKiFYsh2Vk/H1XTsKA ve9I+BmIJTyYwVCuAyVsbvU= X-Google-Smtp-Source: ABdhPJxceOuDErxrR2Wi1j8K0pgWYPDo4qGh3OHmyYYpV4G9G9/RjEx6VR1XQHFqKfLhrcJfeAIEmQ== X-Received: by 2002:adf:b355:: with SMTP id k21mr24710660wrd.380.1633471606170; Tue, 05 Oct 2021 15:06:46 -0700 (PDT) Received: from ?IPV6:2a02:8108:96c0:3b88::f816? ([2a02:8108:96c0:3b88::f816]) by smtp.gmail.com with ESMTPSA id b13sm2210208wmj.3.2021.10.05.15.06.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 15:06:45 -0700 (PDT) Message-ID: Date: Wed, 6 Oct 2021 00:06:45 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH 5/9] staging: r8188eu: remove two write-only hal components Content-Language: en-US To: Martin Kaiser , Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20211005200821.19783-1-martin@kaiser.cx> <20211005200821.19783-5-martin@kaiser.cx> From: Michael Straube In-Reply-To: <20211005200821.19783-5-martin@kaiser.cx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/5/21 22:08, Martin Kaiser wrote: > RegTxPause and RegBcnCtrlVal from struct hal_data_8188e are set but never > read. Remove them. > > Signed-off-by: Martin Kaiser > --- > drivers/staging/r8188eu/hal/usb_halinit.c | 2 -- > drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 --- > 2 files changed, 5 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c > index bd3ba6ab364f..1e6885d75bf3 100644 > --- a/drivers/staging/r8188eu/hal/usb_halinit.c > +++ b/drivers/staging/r8188eu/hal/usb_halinit.c > @@ -556,8 +556,6 @@ static void _InitBeaconParameters(struct adapter *Adapter) > /* beacause test chip does not contension before sending beacon. by tynli. 2009.11.03 */ > rtw_write16(Adapter, REG_BCNTCFG, 0x660F); > > - haldata->RegBcnCtrlVal = rtw_read8(Adapter, REG_BCN_CTRL); > - haldata->RegTxPause = rtw_read8(Adapter, REG_TXPAUSE); > haldata->RegFwHwTxQCtrl = rtw_read8(Adapter, REG_FWHW_TXQ_CTRL + 2); > haldata->RegReg542 = rtw_read8(Adapter, REG_TBTT_PROHIBIT + 2); > haldata->RegCR_1 = rtw_read8(Adapter, REG_CR + 1); > diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h > index bfe32864ded6..b374398bad24 100644 > --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h > +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h > @@ -307,9 +307,6 @@ struct hal_data_8188e { > u8 LastHMEBoxNum; > > u8 fw_ractrl; > - u8 RegTxPause; > - /* Beacon function related global variable. */ > - u32 RegBcnCtrlVal; > u8 RegFwHwTxQCtrl; > u8 RegReg542; > u8 RegCR_1; > Looks good to me. Acked-by: Michael Straube Thanks, Michael