From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423989AbcFIIMj (ORCPT ); Thu, 9 Jun 2016 04:12:39 -0400 Received: from ducie-dc1.codethink.co.uk ([185.25.241.215]:38948 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932091AbcFIIM3 (ORCPT ); Thu, 9 Jun 2016 04:12:29 -0400 Subject: Re: [RFC PATCH 05/15] tty: serial: samsung: fixup accessors for endian To: Matthew Leach , Krzysztof Kozlowski References: <20160608183110.13851-1-matthew@mattleach.net> <20160608183110.13851-6-matthew@mattleach.net> Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org From: Ben Dooks Organization: Codethink Limited. Message-ID: Date: Thu, 9 Jun 2016 09:12:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160608183110.13851-6-matthew@mattleach.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/06/16 19:31, Matthew Leach wrote: > Fix the serial access code to deal with kernels built for big endian > operation. > > Signed-off-by: Matthew Leach > --- > CC: Greg Kroah-Hartman > CC: Jiri Slaby > CC: linux-serial@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > drivers/tty/serial/samsung.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h > index fc5deaa..8818bdd 100644 > --- a/drivers/tty/serial/samsung.h > +++ b/drivers/tty/serial/samsung.h > @@ -118,9 +118,9 @@ struct s3c24xx_uart_port { > ((unsigned long *)(unsigned long)((port)->membase + (reg))) > > #define rd_regb(port, reg) (__raw_readb(portaddr(port, reg))) > -#define rd_regl(port, reg) (__raw_readl(portaddr(port, reg))) > +#define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg))) > > #define wr_regb(port, reg, val) __raw_writeb(val, portaddr(port, reg)) > -#define wr_regl(port, reg, val) __raw_writel(val, portaddr(port, reg)) > +#define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, reg)) I suppose for complete-ness we should have changed the readbs as well. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius From mboxrd@z Thu Jan 1 00:00:00 1970 From: ben.dooks@codethink.co.uk (Ben Dooks) Date: Thu, 9 Jun 2016 09:12:24 +0100 Subject: [RFC PATCH 05/15] tty: serial: samsung: fixup accessors for endian In-Reply-To: <20160608183110.13851-6-matthew@mattleach.net> References: <20160608183110.13851-1-matthew@mattleach.net> <20160608183110.13851-6-matthew@mattleach.net> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/06/16 19:31, Matthew Leach wrote: > Fix the serial access code to deal with kernels built for big endian > operation. > > Signed-off-by: Matthew Leach > --- > CC: Greg Kroah-Hartman > CC: Jiri Slaby > CC: linux-serial at vger.kernel.org > CC: linux-kernel at vger.kernel.org > --- > drivers/tty/serial/samsung.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h > index fc5deaa..8818bdd 100644 > --- a/drivers/tty/serial/samsung.h > +++ b/drivers/tty/serial/samsung.h > @@ -118,9 +118,9 @@ struct s3c24xx_uart_port { > ((unsigned long *)(unsigned long)((port)->membase + (reg))) > > #define rd_regb(port, reg) (__raw_readb(portaddr(port, reg))) > -#define rd_regl(port, reg) (__raw_readl(portaddr(port, reg))) > +#define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg))) > > #define wr_regb(port, reg, val) __raw_writeb(val, portaddr(port, reg)) > -#define wr_regl(port, reg, val) __raw_writel(val, portaddr(port, reg)) > +#define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, reg)) I suppose for complete-ness we should have changed the readbs as well. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius