From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH QMI LTE v2 03/13] gprs: release active contexts completely
Date: Fri, 14 Apr 2017 17:13:17 -0500 [thread overview]
Message-ID: <b01e87db-02bb-cd2a-88cd-0b8e5f4122cd@gmail.com> (raw)
In-Reply-To: <20170414213646.32066-4-jonas@southpole.se>
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
Hi Jonas,
On 04/14/2017 04:36 PM, Jonas Bonn wrote:
> The release_active_contexts method ask the driver to deactive all
> the active contexts it knows about; however, after doing so, the
> context state needs to be released, as well, so that the contexts
> do not continue to appear to be active.
> ---
> src/gprs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/gprs.c b/src/gprs.c
> index 6ed1c89..b6e11e8 100644
> --- a/src/gprs.c
> +++ b/src/gprs.c
> @@ -1614,6 +1614,9 @@ static void release_active_contexts(struct ofono_gprs *gprs)
>
> if (gc->driver->detach_shutdown != NULL)
> gc->driver->detach_shutdown(gc, ctx->context.cid);
> +
> + pri_reset_context_settings(ctx);
> + release_context(ctx);
Hmm, this seems wrong. The original commit (according to git blame, git
show 05b8fe47) was aimed at PPP contexts. The gprs_context driver will
call g_at_ppp_shutdown which in turn will result in eventual
ppp_disconnect. The context driver will then call
ofono_gprs_cid_deactivated.
For the other context drivers, it was assumed that the modem will be
sane enough to issue a +CGEV with a context deactivation.
I'm assuming you need this for QMI as well, so you might want to use
similar semantics. E.g. have detach_shutdown call STOP_NET and then
call ofono_gprs_cid_deactivated.
> }
> }
>
>
Regards,
-Denis
next prev parent reply other threads:[~2017-04-14 22:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 21:36 [PATCH QMI LTE v2 00/13] QMI LTE series Jonas Bonn
2017-04-14 21:36 ` [PATCH QMI LTE v2 01/13] qmi: duplicate callback data correctly Jonas Bonn
2017-04-14 21:49 ` Denis Kenzior
2017-04-14 21:36 ` [PATCH QMI LTE v2 02/13] qmi: fix typo Jonas Bonn
2017-04-14 21:49 ` Denis Kenzior
2017-04-14 21:36 ` [PATCH QMI LTE v2 03/13] gprs: release active contexts completely Jonas Bonn
2017-04-14 22:13 ` Denis Kenzior [this message]
2017-04-14 21:36 ` [PATCH QMI LTE v2 04/13] gprs: _cid_activated is an 'attaching' state Jonas Bonn
2017-04-14 22:29 ` Denis Kenzior
2017-04-14 21:36 ` [PATCH QMI LTE v2 05/13] gprs: set driver_attached when activating automatic contexts Jonas Bonn
2017-04-14 22:43 ` Denis Kenzior
2017-04-14 21:36 ` [PATCH QMI LTE v2 06/13] qmi: implement detach_shutdown method Jonas Bonn
2017-04-14 21:36 ` [PATCH QMI LTE v2 07/13] qmi: read_settings needs to call start network Jonas Bonn
2017-04-14 22:57 ` Denis Kenzior
2017-04-14 21:36 ` [PATCH QMI LTE v2 08/13] qmi: don't leak cbd and rely on destroy function Jonas Bonn
2017-04-14 23:00 ` Denis Kenzior
2017-04-14 21:36 ` [PATCH QMI LTE v2 09/13] qmi: activate default bearer context for LTE networks Jonas Bonn
2017-04-14 21:36 ` [PATCH QMI LTE v2 10/13] qmi: use destroy callback for activate_primary Jonas Bonn
2017-04-14 21:36 ` [PATCH QMI LTE v2 11/13] qmi: stop listening to packet service notifications Jonas Bonn
2017-04-14 21:36 ` [PATCH QMI LTE v2 12/13] qmi: rely on destroy callback Jonas Bonn
2017-04-14 21:36 ` [PATCH QMI LTE v2 13/13] qmi: consolidate ss_info handling functions Jonas Bonn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b01e87db-02bb-cd2a-88cd-0b8e5f4122cd@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.