All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"Mutanen, Mikko" <Mikko.Mutanen@fi.rohmeurope.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"Laine, Markus" <Markus.Laine@fi.rohmeurope.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"sre@kernel.org" <sre@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [RFC PATCH 2/3] power: (regmap:) Add linear_range helper
Date: Wed, 19 Feb 2020 08:14:11 +0000	[thread overview]
Message-ID: <b0237802eed73451f85835c6bd1164411b901778.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20200218134926.GH4232@sirena.org.uk>

Hello Mark,

On Tue, 2020-02-18 at 13:49 +0000, Mark Brown wrote:
> On Tue, Feb 18, 2020 at 07:23:38AM +0000, Vaittinen, Matti wrote:
> 
> > By the way - do you have some nice test cases for regulators hidden
> > somewhere? If so, do you think you could share them? I sure have
> > some
> > for BD718x7 but they are somewhat clumsy and require special HW.
> > (I've
> > never liked unit-tests but I must admit there are some specific
> > cases
> > where they would be pretty usable).
> 
> You can't really run tests on actual regulator drivers outside of
> test
> rigs as they're kind of important to the system they're running in.

Right. I was thinking of some tests which would only be testing the
vsel logic by feeding test ranges to functions and verifying the
resulting selectors/voltages were correct. Unit test style thing where
part of the code is stubbed out and rest is compiled into a test
executable. I know some people do such (and I usually don't see the
effort/benefit ratio to be too great there - although there are cases
where such tests can be beneficial). So I decided to ask if you are one
of those who do such testing and happened to have such for regulator
functions. But this is clear now.

I'll try running some tests on BD71847 break-out board at the end of
RFC phase - but I do appreciate all the testing on other systems as
well! Touching the regulator core is a bit scary as it can result ...
problems :/

Best Regards
	Matti Vaittinen

  reply	other threads:[~2020-02-19  8:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10 12:11 [RFC PATCH 0/3] Support ROHM BD99954 charger IC Matti Vaittinen
2020-02-10 12:11 ` [RFC PATCH 1/3] dt_bindings: ROHM BD99954 Charger Matti Vaittinen
2020-02-10 13:00   ` Vaittinen, Matti
2020-02-10 12:13 ` [RFC PATCH 2/3] power: (regmap:) Add linear_range helper Matti Vaittinen
2020-02-11 19:06   ` Mark Brown
2020-02-12  6:56     ` Vaittinen, Matti
2020-02-14 11:47       ` Mark Brown
2020-02-14 12:32         ` Vaittinen, Matti
2020-02-18  7:23           ` Vaittinen, Matti
2020-02-18 13:49             ` Mark Brown
2020-02-19  8:14               ` Vaittinen, Matti [this message]
2020-02-10 12:13 ` [RFC PATCH 3/3] power: supply: Support ROHM bd99954 charger Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0237802eed73451f85835c6bd1164411b901778.camel@fi.rohmeurope.com \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=Markus.Laine@fi.rohmeurope.com \
    --cc=Mikko.Mutanen@fi.rohmeurope.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mazziesaccount@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.