All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: remove noisy logs in intel_dp_dsc_get_output_bpp()
Date: Tue, 07 Jun 2022 11:07:46 +0300	[thread overview]
Message-ID: <b036ba299e738383186df4a9bc47b658a0fc43c1.camel@coelho.fi> (raw)
In-Reply-To: <871qw0rj99.fsf@intel.com>

On Tue, 2022-06-07 at 11:05 +0300, Jani Nikula wrote:
> On Tue, 07 Jun 2022, Luca Coelho <luca@coelho.fi> wrote:
> > From: Luca Coelho <luciano.coelho@intel.com>
> > 
> > The intel_dp_dsc_get_output_bpp() function outputs two lines of
> > unconditional logs, which was okay when it was called only once.  But
> > now, we also call this function from intel_dp_mode_valid(), which is
> > in turn called for every mode we need to validate.  This causes a lot
> > of useless noise.
> > 
> > Remove the unconditional prints to avoid spamming the logs.  Also
> > remove one more print that is not unconditional, but is related.
> > 
> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> 
> Some of these might be useful on the compute config path, but meh.

Yeah, as we discussed offline, it was not worth refactoring it for the
config path.  If needed, we can add them back in a less noisy way.


> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Thanks!

--
Cheers,
Luca.

  reply	other threads:[~2022-06-07  8:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07  7:44 [Intel-gfx] [PATCH] drm/i915: remove noisy logs in intel_dp_dsc_get_output_bpp() Luca Coelho
2022-06-07  8:05 ` Jani Nikula
2022-06-07  8:07   ` Luca Coelho [this message]
2022-06-07 11:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-06-07 14:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-06-07 19:10 ` [Intel-gfx] [PATCH] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b036ba299e738383186df4a9bc47b658a0fc43c1.camel@coelho.fi \
    --to=luca@coelho.fi \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.