All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kinsella, Ray" <mdr@ashroe.eu>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: thomas@monjalon.net, ferruh.yigit@intel.com,
	Jasvinder Singh <jasvinder.singh@intel.com>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	Conor Walsh <conor.walsh@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH] sort symbols map
Date: Tue, 5 Oct 2021 15:16:59 +0100	[thread overview]
Message-ID: <b06c97aa-7cd8-78b5-ced7-f50c1a7d4bcd@ashroe.eu> (raw)
In-Reply-To: <20211005091626.31885-1-david.marchand@redhat.com>



On 05/10/2021 10:16, David Marchand wrote:
> Fixed with ./devtools/update-abi.sh $(cat ABI_VERSION)
> 
> Fixes: e73a7ab22422 ("net/softnic: promote manage API")
> Fixes: 8f532a34c4f2 ("fib: promote API to stable")
> Fixes: 4aeb92396b85 ("rib: promote API to stable")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> I added "./devtools/update-abi.sh $(cat ABI_VERSION)" to my checks.
> 
> I should have caught it when merging fib and rib patches...
> But my eyes (or more likely brain) stopped at net/softnic bits.
> 
> What do you think?
> Should I wait a bit more and send a global patch to catch any missed
> sorting just before rc1?
> 
> In the meantime, if you merge .map updates, try to remember to run the
> command above.
> 
> Thanks.
> ---
>  drivers/net/softnic/version.map |  2 +-
>  lib/fib/version.map             | 21 ++++++++++-----------
>  lib/rib/version.map             | 33 ++++++++++++++++-----------------
>  3 files changed, 27 insertions(+), 29 deletions(-)
> 

Something to add to the Symbol Bot also, maybe?

Acked-by: Ray Kinsella <mdr@ashroe.eu>

  reply	other threads:[~2021-10-05 14:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05  9:16 [dpdk-dev] [PATCH] sort symbols map David Marchand
2021-10-05 14:16 ` Kinsella, Ray [this message]
2021-10-05 14:31   ` David Marchand
2021-10-05 15:06   ` David Marchand
2021-10-11 11:36 ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b06c97aa-7cd8-78b5-ced7-f50c1a7d4bcd@ashroe.eu \
    --to=mdr@ashroe.eu \
    --cc=conor.walsh@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jasvinder.singh@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.