From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCHv5 02/33] doc: add dpaa2 nic details
Date: Fri, 20 Jan 2017 10:17:13 +0530
Message-ID: <b076786e-c138-cdba-edad-163b82b73785@nxp.com>
References: <1484679174-4174-1-git-send-email-hemant.agrawal@nxp.com>
 <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com>
 <1484832240-2048-5-git-send-email-hemant.agrawal@nxp.com>
 <64565946.GzjslHbcRR@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <bruce.richardson@intel.com>, <shreyansh.jain@nxp.com>,
 <john.mcnamara@intel.com>, <ferruh.yigit@intel.com>,
 <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0051.outbound.protection.outlook.com [104.47.34.51])
 by dpdk.org (Postfix) with ESMTP id A699C2C37
 for <dev@dpdk.org>; Fri, 20 Jan 2017 05:47:22 +0100 (CET)
In-Reply-To: <64565946.GzjslHbcRR@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/19/2017 10:38 PM, Thomas Monjalon wrote:
> 2017-01-19 18:53, Hemant Agrawal:
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> +NXP DPAA2 PMD
>> +M: Hemant Agrawal <hemant.agrawal@nxp.com>
>> +F: drivers/bus/fslmc/
>> +F: drivers/common/dpaa2/
>> +F: drivers/net/dpaa2/
>> +F: drivers/pool/dpaa2/
>> +F: doc/guides/nics/dpaa2.rst
>
> Please introduce line by line in the patches
> adding these files.
>

Ok

>> +++ b/doc/guides/nics/features/dpaa2.ini
>> @@ -0,0 +1,8 @@
>> +;
>> +; Supported features of the 'dpaa2' network poll mode driver.
>> +;
>> +; Refer to default.ini for the full list of available PMD features.
>> +;
>> +[Features]
>> +ARMv8                = Y
>> +Usage doc            = Y
>
> You should introduce this file with the first PMD patch.
>

Ok

>> +* **Added a new driver for NXP DPAA2 - FSLMC bus.**
>> +
>> +  Added the new bus "fslmc" driver for NXP DPAA2 devices. See the
>> +  "Network Interface Controller Drivers" document for more details on this new
>> +  driver.
>> +
>> +* **Added a new driver for NXP DPAA2 Network PMD.**
>> +
>> +  Added the new "dpaa2" net driver for NXP DPAA2 devices. See the
>> +  "Network Interface Controller Drivers" document for more details on this new
>> +  driver.
>
> You can use sphinx references to create a link in the generated HTML.
>
> Please move doc patch after (or within) the code.
>
>
ok