From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 4/6] x86/gdbstub: Clean up includes
Date: Thu, 21 Apr 2022 15:09:00 +0200 [thread overview]
Message-ID: <b07b4f2c-b97c-5a33-4d50-d98903b18b25@suse.com> (raw)
In-Reply-To: <20220420141307.24153-5-andrew.cooper3@citrix.com>
On 20.04.2022 16:13, Andrew Cooper wrote:
> common/gdbstub.c wants struct gdb_context but only gets it transitively
> through asm/debugger.h. None of */gdbstub.c should include asm/debugger.h so
> include xen/gdbstub.h instead.
>
> Forward declare struct cpu_user_regs in xen/gdbstub.h so it doesn't depend on
> the include order to compile.
>
> x86/setup.c doesn't need xen/gdbstub.h at all, so drop it.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2022-04-21 13:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 14:13 [PATCH v5 0/6] Clean up common/arch split for debugger.h Andrew Cooper
2022-04-20 14:13 ` [PATCH v5 1/6] x86/debugger: Remove debugger_trap_entry() Andrew Cooper
2022-04-21 13:02 ` Jan Beulich
2022-04-21 17:23 ` Andrew Cooper
2022-04-22 7:27 ` Jan Beulich
2022-04-20 14:13 ` [PATCH v5 2/6] x86/gdbsx: Rename debug.c to gdbsx.c Andrew Cooper
2022-04-21 13:06 ` Jan Beulich
2022-04-21 17:29 ` Andrew Cooper
2022-04-25 13:40 ` Jan Beulich
2022-04-20 14:13 ` [PATCH v5 3/6] x86/gdbsx: Move domain_pause_for_debugger() into gdbsx Andrew Cooper
2022-04-21 13:08 ` Jan Beulich
2022-04-20 14:13 ` [PATCH v5 4/6] x86/gdbstub: Clean up includes Andrew Cooper
2022-04-21 13:09 ` Jan Beulich [this message]
2022-04-20 14:13 ` [PATCH v5 5/6] x86/debugger: Misc cleanup prior to splitting Andrew Cooper
2022-04-21 13:10 ` Jan Beulich
2022-04-20 14:13 ` [PATCH v5 6/6] xen: Split x86/debugger.h into common and arch specific parts Andrew Cooper
2022-04-21 13:12 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b07b4f2c-b97c-5a33-4d50-d98903b18b25@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.