All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geordan Neukum <gneukum1@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jeremy Sowden <jeremy@azazel.net>,
	Mao Wenan <maowenan@huawei.com>,
	YueHaibing <yuehaibing@huawei.com>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Geordan Neukum <gneukum1@gmail.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] staging: kpc2000: kpc_spi: remove function kp_spi_bytes_per_word()
Date: Sun,  2 Jun 2019 15:58:36 +0000	[thread overview]
Message-ID: <b086eac79a4061c7cd67bd587de9d302f9820610.1559488571.git.gneukum1@gmail.com> (raw)
In-Reply-To: <cover.1559488571.git.gneukum1@gmail.com>

The static function kp_spi_bytes_per_word() is defined in kpc2000_spi.c,
but it is completely unused. As this function is unused, it can and
should be removed.

Signed-off-by: Geordan Neukum <gneukum1@gmail.com>
---
 drivers/staging/kpc2000/kpc2000_spi.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
index 049b1e324031..b513432a26ed 100644
--- a/drivers/staging/kpc2000/kpc2000_spi.c
+++ b/drivers/staging/kpc2000/kpc2000_spi.c
@@ -162,20 +162,6 @@ union kp_spi_ffctrl {
 /***************
  * SPI Helpers *
  ***************/
-	static inline int
-kp_spi_bytes_per_word(int word_len)
-{
-	if (word_len <= 8){
-		return 1;
-	}
-	else if (word_len <= 16) {
-		return 2;
-	}
-	else { /* word_len <= 32 */
-		return 4;
-	}
-}
-
 	static inline u64
 kp_spi_read_reg(struct kp_spi_controller_state *cs, int idx)
 {
-- 
2.21.0


  parent reply	other threads:[~2019-06-02 15:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-02 15:58 [PATCH 0/5] staging: kpc2000: kpc_spi: Assorted small fixes Geordan Neukum
2019-06-02 15:58 ` [PATCH 1/5] staging: kpc2000: kpc_spi: Remove unnecessary consecutive newlines Geordan Neukum
2019-06-02 15:58 ` [PATCH 2/5] staging: kpc2000: kpc_spi: column-align switch and subordinate cases Geordan Neukum
2019-06-02 15:58 ` [PATCH 3/5] staging: kpc2000: kpc_spi: remove fifo_depth from kp_spi struct Geordan Neukum
2019-06-02 15:58 ` Geordan Neukum [this message]
2019-06-02 15:58 ` [PATCH 5/5] staging: kpc2000: kpc_spi: use devm_* API to manage mapped I/O space Geordan Neukum
2019-06-03 12:16   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b086eac79a4061c7cd67bd587de9d302f9820610.1559488571.git.gneukum1@gmail.com \
    --to=gneukum1@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeremy@azazel.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maowenan@huawei.com \
    --cc=natechancellor@gmail.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.