[v7 1/4] dt-bindings: media: rc: add keymap bindings for MagicBox M16S remote

[v7 1/4] dt-bindings: media: rc: add keymap bindings for MagicBox M16S remote

[Zhang Ning]

MagicBox M16S Tv box shipped with a simple NEC remote.

Signed-off-by: Zhang Ning <zhangn1985@qq.com>
---
 Documentation/devicetree/bindings/media/rc.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/rc.yaml b/Documentation/devicetree/bindings/media/rc.yaml
index d4c541c4b164..6491d1bdbac7 100644
--- a/Documentation/devicetree/bindings/media/rc.yaml
+++ b/Documentation/devicetree/bindings/media/rc.yaml
@@ -90,6 +90,7 @@ properties:
       - rc-kworld-plus-tv-analog
       - rc-leadtek-y04g0051
       - rc-lme2510
+      - rc-magicbox
       - rc-manli
       - rc-mecool-kii-pro
       - rc-mecool-kiii-pro
-- 
2.35.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

[v7 2/4] media: rc: add keymap for MagicBox M16S remote

[Zhang Ning]

MagicBox M16S Tv box shipped with a simple NEC remote.

Signed-off-by: Zhang Ning <zhangn1985@qq.com>
Signed-off-by: Sean Young <sean@mess.org>
---
 drivers/media/rc/keymaps/Makefile      |  1 +
 drivers/media/rc/keymaps/rc-magicbox.c | 58 ++++++++++++++++++++++++++
 include/media/rc-map.h                 |  1 +
 3 files changed, 60 insertions(+)
 create mode 100644 drivers/media/rc/keymaps/rc-magicbox.c

diff --git a/drivers/media/rc/keymaps/Makefile b/drivers/media/rc/keymaps/Makefile
index f513ff5caf4e..02c1c2150f03 100644
--- a/drivers/media/rc/keymaps/Makefile
+++ b/drivers/media/rc/keymaps/Makefile
@@ -71,6 +71,7 @@ obj-$(CONFIG_RC_MAP) += \
 			rc-kworld-plus-tv-analog.o \
 			rc-leadtek-y04g0051.o \
 			rc-lme2510.o \
+			rc-magicbox.o \
 			rc-manli.o \
 			rc-mecool-kiii-pro.o \
 			rc-mecool-kii-pro.o \
diff --git a/drivers/media/rc/keymaps/rc-magicbox.c b/drivers/media/rc/keymaps/rc-magicbox.c
new file mode 100644
index 000000000000..a1d9ff30d051
--- /dev/null
+++ b/drivers/media/rc/keymaps/rc-magicbox.c
@@ -0,0 +1,58 @@
+// SPDX-License-Identifier: GPL-2.0+
+//
+// Copyright (C) 2022 Zhang Ning <zhangn1985@qq.com>
+
+/*
+ * Keytable for the MagicBox M16S remote control
+ */
+
+#include <media/rc-map.h>
+#include <linux/module.h>
+
+static struct rc_map_table magicbox[] = {
+	{ 0x9f57, KEY_POWER },
+
+	/*
+	 * This key labeled "M" is used as magic key in vendor OS,
+	 * and mapped to KEY_MUTE.
+	 */
+	{ 0x9f8a, KEY_MUTE },
+
+	{ 0x9f43, KEY_UP },
+	{ 0x9f0a, KEY_DOWN },
+	{ 0x9f06, KEY_LEFT },
+	{ 0x9f0e, KEY_RIGHT },
+	{ 0x9f02, KEY_OK },
+
+	{ 0x9f47, KEY_HOME },
+	{ 0x9f4f, KEY_BACK },
+	{ 0x9f16, KEY_MENU },
+
+	{ 0x9fff, KEY_VOLUMEUP },
+	{ 0x9f5d, KEY_VOLUMEDOWN },
+};
+
+static struct rc_map_list magicbox_map = {
+	.map = {
+		.scan     = magicbox,
+		.size     = ARRAY_SIZE(magicbox),
+		.rc_proto = RC_PROTO_NEC,
+		.name     = RC_MAP_MAGICBOX,
+	}
+};
+
+static int __init init_rc_map_magicbox(void)
+{
+	return rc_map_register(&magicbox_map);
+}
+
+static void __exit exit_rc_map_magicbox(void)
+{
+	rc_map_unregister(&magicbox_map);
+}
+
+module_init(init_rc_map_magicbox)
+module_exit(exit_rc_map_magicbox)
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Zhang Ning <zhangn1985@qq.com>");
diff --git a/include/media/rc-map.h b/include/media/rc-map.h
index 793b54342dff..656217b8e91b 100644
--- a/include/media/rc-map.h
+++ b/include/media/rc-map.h
@@ -277,6 +277,7 @@ struct rc_map *rc_map_get(const char *name);
 #define RC_MAP_KWORLD_PLUS_TV_ANALOG     "rc-kworld-plus-tv-analog"
 #define RC_MAP_LEADTEK_Y04G0051          "rc-leadtek-y04g0051"
 #define RC_MAP_LME2510                   "rc-lme2510"
+#define RC_MAP_MAGICBOX                  "rc-magicbox"
 #define RC_MAP_MANLI                     "rc-manli"
 #define RC_MAP_MECOOL_KII_PRO            "rc-mecool-kii-pro"
 #define RC_MAP_MECOOL_KIII_PRO           "rc-mecool-kiii-pro"
-- 
2.35.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

[v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Zhang Ning]

Add manufactor bindings for Tmall
Add the board bindings for Magicbox M16S Tv Box

Signed-off-by: Zhang Ning <zhangn1985@qq.com>
---
 Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
index 61a6cabb375b..a67af2adf6a5 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.yaml
+++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
@@ -125,6 +125,7 @@ properties:
               - libretech,aml-s912-pc
               - minix,neo-u9h
               - nexbox,a1
+              - tmall,magicbox-m16s
               - tronsmart,vega-s96
               - videostrong,gxm-kiii-pro
               - wetek,core2
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 0496773a3c4d..a06477405963 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1271,6 +1271,8 @@ patternProperties:
     description: Tianma Micro-electronics Co., Ltd.
   "^tlm,.*":
     description: Trusted Logic Mobility
+  "^tmall,.*":
+    description: Alibaba Tmall
   "^tmt,.*":
     description: Tecon Microprocessor Technologies, LLC.
   "^topeet,.*":
-- 
2.35.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

[v7 4/4] arm64: dts: meson: Add MagicBox M16S support

[Zhang Ning]

MagicBox M16S or MagicBox 3Pro is popular Tv box in China.
with spec:

 - Amlogic S912-H (S912 with dolby and dts)
 - 2G ddr3
 - 16G emmc
 - Marvell sd8897 BT/wifi module
 - 100M ethernet
 - IR receiver
 - 4K HDMI
 - AV out
 - Rest hole
 - 5V2A power input
 - white LED

it's q201_v1 according u-boot log.
and it's almost same as Q201 reference design.

add a simple dts to support this Tv box.

Signed-off-by: Zhang Ning <zhangn1985@qq.com>
---
 arch/arm64/boot/dts/amlogic/Makefile          |  1 +
 .../dts/amlogic/meson-gxm-magicbox-m16s.dts   | 39 +++++++++++++++++++
 2 files changed, 40 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts

diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index 8773211df50e..e0907fb41829 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-libretech-cc.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxm-khadas-vim2.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxm-magicbox-m16s.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxm-mecool-kiii-pro.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxm-minix-neo-u9h.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts
new file mode 100644
index 000000000000..5ec905b90d87
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts
@@ -0,0 +1,39 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2022 Zhang Ning <zhangn1985@qq.com>
+ */
+
+/dts-v1/;
+
+#include "meson-gxm.dtsi"
+#include "meson-gx-p23x-q20x.dtsi"
+#include <dt-bindings/input/input.h>
+
+/ {
+	compatible = "tmall,magicbox-m16s", "amlogic,s912", "amlogic,meson-gxm";
+	model = "Tmall MagicBox M16S";
+
+	gpio-keys {
+		compatible = "gpio-keys-polled";
+		poll-interval = <100>;
+
+		key-power {
+			label = "power";
+			linux,code = <KEY_POWER>;
+			gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;
+		};
+	};
+};
+
+&ethmac {
+	phy-mode = "rmii";
+	phy-handle = <&internal_phy>;
+};
+
+&ir {
+	linux,rc-map-name = "rc-magicbox";
+};
+
+&sdio_pwrseq {
+	reset-gpios = <&gpio GPIODV_2 GPIO_ACTIVE_LOW>;
+};
-- 
2.35.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 26/07/2022 16:36, Zhang Ning wrote:
> Add manufactor bindings for Tmall
> Add the board bindings for Magicbox M16S Tv Box
> 
> Signed-off-by: Zhang Ning <zhangn1985@qq.com>

All your subjects are still partially wrong. I pointed this out in v5
and you still send v6 and v7 without proper patch prefix.

> ---
>  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 61a6cabb375b..a67af2adf6a5 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -125,6 +125,7 @@ properties:
>                - libretech,aml-s912-pc
>                - minix,neo-u9h
>                - nexbox,a1
> +              - tmall,magicbox-m16s

Previously the vendor was magicbox... now it is tmall. But you write
also Alibaba. It's a bit confusing.

Best regards,
Krzysztof

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 26/07/2022 16:36, Zhang Ning wrote:
> Add manufactor bindings for Tmall
> Add the board bindings for Magicbox M16S Tv Box
> 
> Signed-off-by: Zhang Ning <zhangn1985@qq.com>

All your subjects are still partially wrong. I pointed this out in v5
and you still send v6 and v7 without proper patch prefix.

> ---
>  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 61a6cabb375b..a67af2adf6a5 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -125,6 +125,7 @@ properties:
>                - libretech,aml-s912-pc
>                - minix,neo-u9h
>                - nexbox,a1
> +              - tmall,magicbox-m16s

Previously the vendor was magicbox... now it is tmall. But you write
also Alibaba. It's a bit confusing.

Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Zhang Ning]

On Wed, Jul 27, 2022 at 09:06:07AM +0200, Krzysztof Kozlowski wrote:
> On 26/07/2022 16:36, Zhang Ning wrote:
> > Add manufactor bindings for Tmall
> > Add the board bindings for Magicbox M16S Tv Box
> > 
> > Signed-off-by: Zhang Ning <zhangn1985@qq.com>
> 
> All your subjects are still partially wrong. I pointed this out in v5
> and you still send v6 and v7 without proper patch prefix.
> 
> > ---
> >  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
> >  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >  2 files changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > index 61a6cabb375b..a67af2adf6a5 100644
> > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > @@ -125,6 +125,7 @@ properties:
> >                - libretech,aml-s912-pc
> >                - minix,neo-u9h
> >                - nexbox,a1
> > +              - tmall,magicbox-m16s
> 
> Previously the vendor was magicbox... now it is tmall. But you write
> also Alibaba. It's a bit confusing.

Tmall is sub-company of Alibaba, if I use alibaba,tmall-magicbox-m16s
this will be too long.

and the first time I use magicbox,m16s, because I don't understand the
format before run checkpatch.pl



> 
> Best regards,
> Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 27/07/2022 16:41, Zhang Ning wrote:
> On Wed, Jul 27, 2022 at 09:06:07AM +0200, Krzysztof Kozlowski wrote:
>> On 26/07/2022 16:36, Zhang Ning wrote:
>>> Add manufactor bindings for Tmall
>>> Add the board bindings for Magicbox M16S Tv Box
>>>
>>> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
>>
>> All your subjects are still partially wrong. I pointed this out in v5
>> and you still send v6 and v7 without proper patch prefix.
>>
>>> ---
>>>  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
>>>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>>>  2 files changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> index 61a6cabb375b..a67af2adf6a5 100644
>>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> @@ -125,6 +125,7 @@ properties:
>>>                - libretech,aml-s912-pc
>>>                - minix,neo-u9h
>>>                - nexbox,a1
>>> +              - tmall,magicbox-m16s
>>
>> Previously the vendor was magicbox... now it is tmall. But you write
>> also Alibaba. It's a bit confusing.
> 
> Tmall is sub-company of Alibaba, if I use alibaba,tmall-magicbox-m16s
> this will be too long.

OK


Best regards,
Krzysztof

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 27/07/2022 16:41, Zhang Ning wrote:
> On Wed, Jul 27, 2022 at 09:06:07AM +0200, Krzysztof Kozlowski wrote:
>> On 26/07/2022 16:36, Zhang Ning wrote:
>>> Add manufactor bindings for Tmall
>>> Add the board bindings for Magicbox M16S Tv Box
>>>
>>> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
>>
>> All your subjects are still partially wrong. I pointed this out in v5
>> and you still send v6 and v7 without proper patch prefix.
>>
>>> ---
>>>  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
>>>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>>>  2 files changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> index 61a6cabb375b..a67af2adf6a5 100644
>>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> @@ -125,6 +125,7 @@ properties:
>>>                - libretech,aml-s912-pc
>>>                - minix,neo-u9h
>>>                - nexbox,a1
>>> +              - tmall,magicbox-m16s
>>
>> Previously the vendor was magicbox... now it is tmall. But you write
>> also Alibaba. It's a bit confusing.
> 
> Tmall is sub-company of Alibaba, if I use alibaba,tmall-magicbox-m16s
> this will be too long.

OK


Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 26/07/2022 16:36, Zhang Ning wrote:
> Add manufactor bindings for Tmall
> Add the board bindings for Magicbox M16S Tv Box
> 
> Signed-off-by: Zhang Ning <zhangn1985@qq.com>

Please send patches with correct subject PATCH.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

> ---
>  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  2 files changed, 3 insertions(+)

Best regards,
Krzysztof

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 26/07/2022 16:36, Zhang Ning wrote:
> Add manufactor bindings for Tmall
> Add the board bindings for Magicbox M16S Tv Box
> 
> Signed-off-by: Zhang Ning <zhangn1985@qq.com>

Please send patches with correct subject PATCH.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

> ---
>  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  2 files changed, 3 insertions(+)

Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Zhang Ning]

On Wed, Jul 27, 2022 at 05:27:25PM +0200, Krzysztof Kozlowski wrote:
> On 26/07/2022 16:36, Zhang Ning wrote:
> > Add manufactor bindings for Tmall
> > Add the board bindings for Magicbox M16S Tv Box
> > 
> > Signed-off-by: Zhang Ning <zhangn1985@qq.com>
> 
> Please send patches with correct subject PATCH.
I got confused, and don't know how to update..

ad152daedc5c dt-bindings: arm: amlogic: add MagicBox M16S bindings
3f7dbd336f36 dt-bindings: arm: amlogic: add Vero 4K+ bindings
2ca889b12016 dt-bindings: arm: amlogic: add H96-Max bindings

> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
for device, how to handle your Acked-by?

btw, he also said I'm wrong in handle Sean's Signed-of-by, still don't
know how to do in next version. Should I just not send this patch?
> 
> > ---
> >  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
> >  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >  2 files changed, 3 insertions(+)
> 
> Best regards,
> Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Christian Hewitt]

> On 28 Jul 2022, at 3:48 am, Zhang Ning <zhangn1985@qq.com> wrote:
> 
> On Wed, Jul 27, 2022 at 05:27:25PM +0200, Krzysztof Kozlowski wrote:
>> On 26/07/2022 16:36, Zhang Ning wrote:
>>> Add manufactor bindings for Tmall
>>> Add the board bindings for Magicbox M16S Tv Box
>>> 
>>> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
>> 
>> Please send patches with correct subject PATCH.
> I got confused, and don't know how to update..
> 
> ad152daedc5c dt-bindings: arm: amlogic: add MagicBox M16S bindings
> 3f7dbd336f36 dt-bindings: arm: amlogic: add Vero 4K+ bindings
> 2ca889b12016 dt-bindings: arm: amlogic: add H96-Max bindings
> 
>> 
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
> for device, how to handle your Acked-by?

Hello Zhang. Let’s work off-list to get things corrected before you send
another (hopefully final) version. I’m happy to explain and coach you on
the process.

Christian

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Christian Hewitt]

> On 28 Jul 2022, at 3:48 am, Zhang Ning <zhangn1985@qq.com> wrote:
> 
> On Wed, Jul 27, 2022 at 05:27:25PM +0200, Krzysztof Kozlowski wrote:
>> On 26/07/2022 16:36, Zhang Ning wrote:
>>> Add manufactor bindings for Tmall
>>> Add the board bindings for Magicbox M16S Tv Box
>>> 
>>> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
>> 
>> Please send patches with correct subject PATCH.
> I got confused, and don't know how to update..
> 
> ad152daedc5c dt-bindings: arm: amlogic: add MagicBox M16S bindings
> 3f7dbd336f36 dt-bindings: arm: amlogic: add Vero 4K+ bindings
> 2ca889b12016 dt-bindings: arm: amlogic: add H96-Max bindings
> 
>> 
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
> for device, how to handle your Acked-by?

Hello Zhang. Let’s work off-list to get things corrected before you send
another (hopefully final) version. I’m happy to explain and coach you on
the process.

Christian
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 28/07/2022 01:48, Zhang Ning wrote:
> On Wed, Jul 27, 2022 at 05:27:25PM +0200, Krzysztof Kozlowski wrote:
>> On 26/07/2022 16:36, Zhang Ning wrote:
>>> Add manufactor bindings for Tmall
>>> Add the board bindings for Magicbox M16S Tv Box
>>>
>>> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
>>
>> Please send patches with correct subject PATCH.
> I got confused, and don't know how to update..
> 
> ad152daedc5c dt-bindings: arm: amlogic: add MagicBox M16S bindings
> 3f7dbd336f36 dt-bindings: arm: amlogic: add Vero 4K+ bindings
> 2ca889b12016 dt-bindings: arm: amlogic: add H96-Max bindings

git format-patch -v8

> 
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
> for device, how to handle your Acked-by?
>
If split is the only change, you can add ti both of them


Best regards,
Krzysztof

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 28/07/2022 01:48, Zhang Ning wrote:
> On Wed, Jul 27, 2022 at 05:27:25PM +0200, Krzysztof Kozlowski wrote:
>> On 26/07/2022 16:36, Zhang Ning wrote:
>>> Add manufactor bindings for Tmall
>>> Add the board bindings for Magicbox M16S Tv Box
>>>
>>> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
>>
>> Please send patches with correct subject PATCH.
> I got confused, and don't know how to update..
> 
> ad152daedc5c dt-bindings: arm: amlogic: add MagicBox M16S bindings
> 3f7dbd336f36 dt-bindings: arm: amlogic: add Vero 4K+ bindings
> 2ca889b12016 dt-bindings: arm: amlogic: add H96-Max bindings

git format-patch -v8

> 
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
> for device, how to handle your Acked-by?
>
If split is the only change, you can add ti both of them


Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Sean Young]

On Thu, Jul 28, 2022 at 07:48:57AM +0800, Zhang Ning wrote:
> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
> for device, how to handle your Acked-by?
> 
> btw, he also said I'm wrong in handle Sean's Signed-of-by, still don't
> know how to do in next version. Should I just not send this patch?

Christian can you explain *on list* what is wrong with handling my
Signed-off-by? As far as I can see Ning has done the right thing.

Please keep the conversation on list so we're all in the loop.


Sean

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Sean Young]

On Thu, Jul 28, 2022 at 07:48:57AM +0800, Zhang Ning wrote:
> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
> for device, how to handle your Acked-by?
> 
> btw, he also said I'm wrong in handle Sean's Signed-of-by, still don't
> know how to do in next version. Should I just not send this patch?

Christian can you explain *on list* what is wrong with handling my
Signed-off-by? As far as I can see Ning has done the right thing.

Please keep the conversation on list so we're all in the loop.


Sean

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Christian Hewitt]

> On 29 Jul 2022, at 12:42 pm, Sean Young <sean@mess.org> wrote:
> 
> On Thu, Jul 28, 2022 at 07:48:57AM +0800, Zhang Ning wrote:
>> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
>> for device, how to handle your Acked-by?
>> 
>> btw, he also said I'm wrong in handle Sean's Signed-of-by, still don't
>> know how to do in next version. Should I just not send this patch?
> 
> Christian can you explain *on list* what is wrong with handling my
> Signed-off-by? As far as I can see Ning has done the right thing.

Sorry, this is my ignorance. I’ve only seen maintainers provide Acked-By
or Reviewed-By tags in response to my own past submissions. I’ve not had
Signed-Off-By responses on-list before. I’ve only seen maintainer SOB
being applied to patches as they are merged into the maintainers tree
and queued for sending upstream. Today is a learning day :)

> Please keep the conversation on list so we're all in the loop.

The board still has some hardware items to figure out and the next date
Amlogic patches will be picked for 5.21 is ~2.5 months away, so there
is no rush and I’ve encouraged Zhang to keep working via the Armbian
forum thread that he started [0]. I’m no expert (as you can see ^) but
I’m trying to coach and explain/spot the common etiquette and process
nits (which I’ve made myself in the past) before he sends the next rev.
of patches for review.

Christian

[0] https://forum.armbian.com/topic/22301-help-to-review-porting-mainline-u-boot-and-linux-to-tmall-magicbox-m16s-amlogic-s912-h-tv-box/

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Christian Hewitt]

> On 29 Jul 2022, at 12:42 pm, Sean Young <sean@mess.org> wrote:
> 
> On Thu, Jul 28, 2022 at 07:48:57AM +0800, Zhang Ning wrote:
>> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
>> for device, how to handle your Acked-by?
>> 
>> btw, he also said I'm wrong in handle Sean's Signed-of-by, still don't
>> know how to do in next version. Should I just not send this patch?
> 
> Christian can you explain *on list* what is wrong with handling my
> Signed-off-by? As far as I can see Ning has done the right thing.

Sorry, this is my ignorance. I’ve only seen maintainers provide Acked-By
or Reviewed-By tags in response to my own past submissions. I’ve not had
Signed-Off-By responses on-list before. I’ve only seen maintainer SOB
being applied to patches as they are merged into the maintainers tree
and queued for sending upstream. Today is a learning day :)

> Please keep the conversation on list so we're all in the loop.

The board still has some hardware items to figure out and the next date
Amlogic patches will be picked for 5.21 is ~2.5 months away, so there
is no rush and I’ve encouraged Zhang to keep working via the Armbian
forum thread that he started [0]. I’m no expert (as you can see ^) but
I’m trying to coach and explain/spot the common etiquette and process
nits (which I’ve made myself in the past) before he sends the next rev.
of patches for review.

Christian

[0] https://forum.armbian.com/topic/22301-help-to-review-porting-mainline-u-boot-and-linux-to-tmall-magicbox-m16s-amlogic-s912-h-tv-box/
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic