From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031471AbdDTKRJ (ORCPT ); Thu, 20 Apr 2017 06:17:09 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:33522 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031421AbdDTKRF (ORCPT ); Thu, 20 Apr 2017 06:17:05 -0400 Subject: Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out. To: Chanwoo Choi , MyungJoo Ham , Rob Herring References: <20170301111943.12170-1-enric.balletbo@collabora.com> <20170301111943.12170-2-enric.balletbo@collabora.com> <58B7C9BF.1040708@samsung.com> <58E44698.5020605@samsung.com> Cc: Lee Jones , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Benson Leung , Olof Johansson From: Enric Balletbo i Serra Message-ID: Date: Thu, 20 Apr 2017 12:16:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <58E44698.5020605@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/04/17 03:21, Chanwoo Choi wrote: > Hi Enric, > > On 2017년 03월 02일 16:29, Chanwoo Choi wrote: >> Hi, >> >> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote: >>> From: Benson Leung >>> >>> This is the driver for the USB Type C cable detection mechanism >>> built into the ChromeOS Embedded Controller on systems that >>> have USB Type-C ports. >>> >>> At present, this allows for the presence of display out, but in >>> future, it may also be used to notify host and device type cables >>> and the presence of power. >>> >>> Signed-off-by: Benson Leung >>> Signed-off-by: Enric Balletbo i Serra >>> --- >>> Changes since v1: >>> Requested by Chanwoo Choi >>> - Rename files changing _ for - >>> - Remove the unneeded blank line on bottom of header. >>> - Remove kobject.h and cros_ec_commands.h includes. >>> - Remove the debug message as is not necessary. >>> - Use the tab for indentation instead of space for if sentence. >>> - Define each variable on different lines when the variables should be >>> initialized. >>> - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now. >>> - Add one blank line to split out between state and property setting. >>> - Add the author information (header and module) >>> >>> Enric Balletbo >>> - As Rob suggested to rename the compatible name to something indicating that >>> is USB Type C related I also renamed the file names, extcon-cros-ec -> >>> extcon-usbc-cros-ec, I think it's more clear. >>> >>> drivers/extcon/Kconfig | 7 + >>> drivers/extcon/Makefile | 1 + >>> drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++ >>> include/linux/mfd/cros_ec_commands.h | 75 +++++++ >>> 4 files changed, 498 insertions(+) >>> create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c >>> >> >> Looks good to me. >> Acked-by: Chanwoo Choi >> >> I think this patch should be handled with patches[1]. >> [1] https://lkml.org/lkml/2017/2/14/655 >> >> I think that one maintainer among following subsystems >> (mfd, chrome h/w platform, rtc and extcon) >> will apply their git repository, and then one maintainer >> will send the pull request of immutable branch for these patches. >> > > As I mentioned, these patch should be handled with related patches[1]. > [1] https://lkml.org/lkml/2017/2/14/655 > > So, I can't apply these patch on extcon git because there is a merge conflict > and we should handle these patches with immutable branch between subsystem maintainer. > > The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1, > please take care of these patches. > CC'ied : Olof Johansson Olof, Benson, Could at least the following patch in this series [1] picked as soon as possible if it's ok. 9630769 New [01/13] mfd: cros_ec: Add helper for event notifier This specific patch is blocking this and others like the rtc-cros-ec to land and the series were send some time ago without received bad feedback. [1] https://lkml.org/lkml/2017/3/17/321 Many thanks, Enric From mboxrd@z Thu Jan 1 00:00:00 1970 From: Enric Balletbo i Serra Subject: Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out. Date: Thu, 20 Apr 2017 12:16:56 +0200 Message-ID: References: <20170301111943.12170-1-enric.balletbo@collabora.com> <20170301111943.12170-2-enric.balletbo@collabora.com> <58B7C9BF.1040708@samsung.com> <58E44698.5020605@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <58E44698.5020605-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chanwoo Choi , MyungJoo Ham , Rob Herring Cc: Lee Jones , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Benson Leung , Olof Johansson List-Id: devicetree@vger.kernel.org On 05/04/17 03:21, Chanwoo Choi wrote: > Hi Enric, > > On 2017년 03월 02일 16:29, Chanwoo Choi wrote: >> Hi, >> >> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote: >>> From: Benson Leung >>> >>> This is the driver for the USB Type C cable detection mechanism >>> built into the ChromeOS Embedded Controller on systems that >>> have USB Type-C ports. >>> >>> At present, this allows for the presence of display out, but in >>> future, it may also be used to notify host and device type cables >>> and the presence of power. >>> >>> Signed-off-by: Benson Leung >>> Signed-off-by: Enric Balletbo i Serra >>> --- >>> Changes since v1: >>> Requested by Chanwoo Choi >>> - Rename files changing _ for - >>> - Remove the unneeded blank line on bottom of header. >>> - Remove kobject.h and cros_ec_commands.h includes. >>> - Remove the debug message as is not necessary. >>> - Use the tab for indentation instead of space for if sentence. >>> - Define each variable on different lines when the variables should be >>> initialized. >>> - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now. >>> - Add one blank line to split out between state and property setting. >>> - Add the author information (header and module) >>> >>> Enric Balletbo >>> - As Rob suggested to rename the compatible name to something indicating that >>> is USB Type C related I also renamed the file names, extcon-cros-ec -> >>> extcon-usbc-cros-ec, I think it's more clear. >>> >>> drivers/extcon/Kconfig | 7 + >>> drivers/extcon/Makefile | 1 + >>> drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++ >>> include/linux/mfd/cros_ec_commands.h | 75 +++++++ >>> 4 files changed, 498 insertions(+) >>> create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c >>> >> >> Looks good to me. >> Acked-by: Chanwoo Choi >> >> I think this patch should be handled with patches[1]. >> [1] https://lkml.org/lkml/2017/2/14/655 >> >> I think that one maintainer among following subsystems >> (mfd, chrome h/w platform, rtc and extcon) >> will apply their git repository, and then one maintainer >> will send the pull request of immutable branch for these patches. >> > > As I mentioned, these patch should be handled with related patches[1]. > [1] https://lkml.org/lkml/2017/2/14/655 > > So, I can't apply these patch on extcon git because there is a merge conflict > and we should handle these patches with immutable branch between subsystem maintainer. > > The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1, > please take care of these patches. > CC'ied : Olof Johansson Olof, Benson, Could at least the following patch in this series [1] picked as soon as possible if it's ok. 9630769 New [01/13] mfd: cros_ec: Add helper for event notifier This specific patch is blocking this and others like the rtc-cros-ec to land and the series were send some time ago without received bad feedback. [1] https://lkml.org/lkml/2017/3/17/321 Many thanks, Enric -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html