From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BAC1C76196 for ; Tue, 28 Mar 2023 09:35:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6911A85925; Tue, 28 Mar 2023 11:34:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=mysnt.onmicrosoft.com header.i=@mysnt.onmicrosoft.com header.b="HigHSOmi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D8BC78591B; Tue, 28 Mar 2023 11:34:54 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0709.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::709]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DEEA485BC7 for ; Tue, 28 Mar 2023 11:34:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=frieder.schrempf@kontron.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SgmnrndOH4M1YB39YMv32lyRT39BastqEwsjRxEG6evGWlBbaucHaEbbF1DM6oQAMaC9A5/Q+08xcoLe3LEx/iHTcmReyb4jKFAWKLX6HRehVmgX2KJD7uw1TdygF43Pni2Bnyv9UlBl7MkyDdcyKa4ICW3ZQEb0vyVCpDplr/R9qe9wdXr4zjSBbulZFk6tDAuMeQGu3XvkHK9aWS1qtnhYmSu1JEQOvLgwx+DuzfnHMOHtxIy06KTiiVXd5mNQvlkc7LnQhWq3woNe/TZp26I6kDx3x6vW1Vkl7h9V3qtPbpF249g2+H0FEEj9PZGiqPGwEV0zlfW7JuP6GZ4oRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=smkAYVvp14ZS0nbSQEwCmkSwAPfYs7izXSFN2FfB77w=; b=T5YO33MQk7KcRR5Vl7gXV+nqFF1MJQjOXI+eGOpuusLwiu20sdHilsNTnuSlgbcERHnHjz2asr6WG4eVsCcsV/UqnRrtkqDg/5Oqkpgs+CBdrWmkBsb7htGFaXTQVTwbY8Tc1Coh599tnhmkyzRt/ov9zDBEgRSOgZJy3R6CeTEeBDZ29fy2xVHHgcXeJdtPhL37dSvPNMa1h2hJ+4MzT1+G8aVXI1g9yxVDqeLdeRSF7MksbkJ4ALlGbO6OQei13ixYk7ONlpCyO1P0okM2XABCcXtDalKnZNAH4WtjGCmm2wdFHH8Sh3YXZZUEAQPY6wPn2bvY4kOqBbC0KkXwfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kontron.de; dmarc=pass action=none header.from=kontron.de; dkim=pass header.d=kontron.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mysnt.onmicrosoft.com; s=selector2-mysnt-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=smkAYVvp14ZS0nbSQEwCmkSwAPfYs7izXSFN2FfB77w=; b=HigHSOmiyDn/ZEgyAgL5m2XW4S2gDzOyAc4nQEp+3pxJ1eXaHDVaB8ezVrKA+qbXn/GMDBB7ZncHHqQSFZNGFi0O/08FbxlSHa6X/eUzrbF1P3U8IGgIVSZDJFIYOe2+ZJF9tb3XJOokj6QRST/QDX3aimIILEbShRrNGdrqCO4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kontron.de; Received: from PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:263::10) by AS2PR10MB7801.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:64a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.16; Tue, 28 Mar 2023 09:34:44 +0000 Received: from PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM ([fe80::7ec3:9d2c:15ac:e1af]) by PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM ([fe80::7ec3:9d2c:15ac:e1af%3]) with mapi id 15.20.6254.016; Tue, 28 Mar 2023 09:34:44 +0000 Message-ID: Date: Tue, 28 Mar 2023 11:34:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2] imx: imx8mm: Add suppoer for Mettler-Toledo snowflake board. Content-Language: en-US, de-DE To: Sebastian Andrzej Siewior Cc: u-boot@lists.denx.de, "NXP i.MX U-Boot Team" , Fabio Estevam , Manuel Traut , Stefano Babic References: <20230310135021.kRabfq7r@linutronix.de> <95b3bb48-6dcf-6468-362a-f0609494afee@kontron.de> <5df21ee8-7599-c3c0-5b9d-48426a624415@kontron.de> <20230328074723.PIEFvY0Q@linutronix.de> <20230328093013.sCzkQX3l@linutronix.de> From: Frieder Schrempf In-Reply-To: <20230328093013.sCzkQX3l@linutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0186.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::20) To PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:263::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5681:EE_|AS2PR10MB7801:EE_ X-MS-Office365-Filtering-Correlation-Id: 55c79aaa-14a3-4813-45f3-08db2f6fa9e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WtLL5LIAhd4JZ6AWkk6B+69Kv4iaQo55fOJJm6/4SBi5rZPwI8i9uj7joWYP2F0Vbi9HL9V0sEFVxIeR3y/1lKiulpwSeX3RZN1q0yauYLwFQvzvYDTWFRUidWQduA5CMQx28VlPpjic2ufzxajy6e9rd139s0nAWOhzQKD2dtmU6qWKJy1iMnW2JMbXiNcEsV3c1GXvRdHu5F0qPYs8M2DMJN9Qk8QtQJZb2ttgEtY+be4PBV2wBY0rC4v8vxqqlm4KQbb5OI5GrOq8WDt4MZuut7dO7os8EZJqKfHB1MX1IzsWI4skEZLGzBu076Vu5Qq1yd4SnJReqx7B/R/Obk/kW3Ah2TAISm852Ie4rqXDSZOqIex6C719zwDN6DWr4XH73cBxlBGHp0pSCxSmmNt3VPO4sSFzLhNAZ2Mj6dqZjI10vJ3BxDNK6q7N3Fgvfizh96d8HPakPwJ92ND1JZS12yYdjXufYgqwfQA8YzJ8ZgTqSPl9ex9uoFLW6bJnB4fp1iprlcc34Uam8b16lLQQnh8llpMTm6B6ldN1iz51MsU/1dekxCQtVegkg1rTAMkJUiAUE1q+o35O+rErkoqGcv0GyZGwEPPsyajuk+e5+QC1n6y0QQWwDnd3DXnSYGTt9uEGC/zOQ4HpCZO3q97mKqGe0ZPEfBvl2g96YEI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(366004)(39860400002)(376002)(396003)(451199021)(53546011)(6512007)(6506007)(41300700001)(186003)(966005)(6486002)(83380400001)(2616005)(31686004)(478600001)(54906003)(316002)(38100700002)(4326008)(66476007)(44832011)(2906002)(66946007)(66556008)(6916009)(8676002)(31696002)(86362001)(36756003)(5660300002)(8936002)(32563001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDN6aXo1N0x1OEZpRUxCa1J6QzlNOXY3SzJFM2JycG5UaUNkVFN6UFZMc3JJ?= =?utf-8?B?bFhIWEVOMGFwSmJQU2I4Qk5FazdQK1N4eWVlcTZKaGhaeHhxRm1wamlTVHNH?= =?utf-8?B?aVd1eFV4TE9sNE1aOWRyVFB1SUpXLytHc3dTemczR1ZkRnRNeUViUFNYRWx3?= =?utf-8?B?bSszK1BKUXZocStkNVhHcVN1OG4wSHo0QlVueG9IeWUwM3A2c3MyMkdHekxS?= =?utf-8?B?emtHMTh3bzFqdFJXZGlJN25WVVN2UnV4RFY5OGZKTGx6d3BvbklOaW5lbThm?= =?utf-8?B?aUVLSlhuY0lQUE5Fd1FiWE1VN1NzMlBkUWlXWEJHdGJ5QzdkUjlwQWlOZ3NB?= =?utf-8?B?RVphVGc3OWZlMUFrVHJzaFVCc3lzUVZRMC9PL3ZtNnhJNzUzYXdhQ1JtMkFo?= =?utf-8?B?bE82VEsvaEs4K0NBM0NEL3BMWjBvNnpkSjkvcUR1L0FBR3hqcTNpa3ZybWNI?= =?utf-8?B?cU1BOUpxVk1TaDBuK0dqRitOdHN1ZWRzSkRleHpqb2xVMGxtemNKa3loS0FI?= =?utf-8?B?dllUOTBHQ09JS1VudjE1Vnl5UjdGUUQ4alI1VXdCdVphWHRWL09abVFWWExo?= =?utf-8?B?VHM1OU5SZEhuUWpvdVlQVk5qQTBCT2ZuMElhOXFMU3hOZ29hakFXUEJLRlZz?= =?utf-8?B?ZGxhOGpVUnNtUFI5WkkwQmx3OURQaUJ6c2lnZEdZR0FNeW15bEtJUUxVL0pO?= =?utf-8?B?RTA2T2pEZEVnbEthTkw1VXgxUXk0aWY5b0lOVVBUYkxRR2ZTUUdmbzJ4eG9N?= =?utf-8?B?Um1vTForUEVWOEd5RzFCalZid1ZtY0lCRkR5aFFBSm9BeTVlZnM1VU1zZ2Nm?= =?utf-8?B?ZlUyNUI3NGRXcmsxZzlGMDVaS01JSW1DQXRqVDRGTWZiSXRNRkVHMVVnaVo2?= =?utf-8?B?SWtNcEg5UGIrU1QrUExWbTFTdG1pU3RYMWNrOGM0QTE4ZllBQlZWVWxjWFdh?= =?utf-8?B?OXlaM0JScGJXR25jWUtQTFFJWWgwdE1WNU5CYkN1azNkbHpyZjlHaDdaRTcz?= =?utf-8?B?RXYwUytadGIrOHhVMFhYeUFxRmFmdVo5R1Jnd2U3MGwzZWJORlB1RHRBem16?= =?utf-8?B?Tyt0WVhPT2czWjJoMmdjWXExY3QwOU9ncHpaT1VSVDd4b1F2MXBDbzFrRFZ2?= =?utf-8?B?dXpRK3dRSUNYVzFya3JCZjkwY3N1bEFqTGFWK0RzM0p3WDJ2V3N3WEVQNDJY?= =?utf-8?B?ZXdKMlQzWXBRWXVlbUFVSHZDTG5tYmlwdVk1ekVJOWRFWHR0dzJUNU83eHlq?= =?utf-8?B?L1ZPQmlxWEF5MERiREp5N1hzS2FmOEJTY0o2WmNSaDZ2cGYwaUVKRjRQL3lW?= =?utf-8?B?ODhWQ1hvQk9EcHNqblNKR2tYRXV5c2hNZzNUcTIvOEZhNUdoVmV6REFrNmxN?= =?utf-8?B?dGs0YVpXZ0kzU1MrdmQ1aGgzWjdWbnU1QmFEempuR3JlQ0xwb0h1WHJQWUFR?= =?utf-8?B?cmtXZ3VzL2NuZzhRcStzcjNRTmFuWFhrVHlaYnBUZmZLcjJkUEE2aVZJdGZp?= =?utf-8?B?U1hkNU1hT1FOc04ybEtoSmNkRlgySHQ5YVQ4T2xxM3dIMUZOZGY4T1FLaDF6?= =?utf-8?B?RTl2QWowWTBqbjllYmNGZkZkWWo0NGxRbS9kTzFLRDRtaWV0d1VuNWFLUHVF?= =?utf-8?B?YlU0RmE0WFdoN1YvNVJwTUNsUGt6OVR4TWZlb3pzTTdEYjE4Z05acFc1SkNH?= =?utf-8?B?MWhHbDN6Nm1pZlJ6VVNlNDROVmZldjZCbkVwNVRHVjNJUkV0WVJvUjc0UG9K?= =?utf-8?B?TW41cG5PSW5zTWpTazJJNDlsQ2tRR0kwQUlEUjNtVmdHczN6bE5BaXJ2cy9k?= =?utf-8?B?WkJReUgxUU5EL3BpMW9PeVJjaXlQUkZYaFFJRHRUVU42OWgvS21CNTduMExu?= =?utf-8?B?K1QrRURtdjhWcVVSR3NKeUtwRkxxbXZ0REJmYmlpdVVHT0NYRkk4a0tLaWor?= =?utf-8?B?WUlpb2x0a3VVS3Q3a3QzV1ViU2psakcrUGRFdFhkb0lkakRNeWdZQ0pEc3ZF?= =?utf-8?B?V1RVNUhFQnd2VGpNVTZKbUk4S2dBOE9GTXhQMkdkb0lTNVZ1bWN1MHV6aHVN?= =?utf-8?B?cHJMbkVCNEpVMzdlN3FweWlFeFNiRE5hSGxJcVpmQm5rSnBUdUNEV3pDT1Z1?= =?utf-8?B?WXUzMHIza0lqUm5TZS92Zkx4QzJNT1h5a1hXQ3JjdktNcU9PZFZ3TFBaMnlh?= =?utf-8?Q?3V4a/hRhtESal0WteOt46y7P5C4lG0f+19p6IY5DpemI?= X-OriginatorOrg: kontron.de X-MS-Exchange-CrossTenant-Network-Message-Id: 55c79aaa-14a3-4813-45f3-08db2f6fa9e8 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 09:34:44.2943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TaIa4IqKWzCSgr25PF8TkWfqVgFoVQwsq33CoLQnhv77DA7AxPajapLa9bu4ZCUEcH6rjDMhcxK86EbmmVhQ2RL268Wm5BdloUn9VUK/RVM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7801 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 28.03.23 11:30, Sebastian Andrzej Siewior wrote: > On 2023-03-28 09:53:28 [+0200], Frieder Schrempf wrote: >> On 28.03.23 09:47, Sebastian Andrzej Siewior wrote: >>> The board is similar to "Kontron SL i.MX8M Mini" SoM. There are two variants. >>> Snowflake_v2 has an external SDCard Interface. LEIG is the same, but without >>> display and without external SDCard Interface. Both variants support >>> only 1GiB of main memory. >>> >>> Signed-off-by: Manuel Traut >>> Signed-off-by: Sebastian Andrzej Siewior >>> --- >>> v1…v2: >>> - Clarify details about the board and whether or not there is an >>> external SD-card interface. >> >> What about my other review comments to v1? > > I update the Name to "Kontron SL i.MX8M Mini" SoM in the description but > forgot to add it to the changelog. Was there something else missed? You can easily answer that yourself, by looking at the comments I made in [1]. There are comments for the DT compatible, the PMIC node, the I2C1 pinctrl node and the DDR init code you haven't responded to. [1] https://patchwork.ozlabs.org/project/uboot/patch/20230310135021.kRabfq7r@linutronix.de/#3078257